Page MenuHomePhabricator

espositofulvio (Fulvio Esposito)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2015, 2:26 PM (227 w, 3 d)

Recent Activity

May 10 2016

espositofulvio added a comment to D11781: Refactored pthread usage in libcxx.

@espositofulvio: Thanks for the patch! :)

Committed as r268734.

May 10 2016, 2:37 AM

Apr 16 2016

espositofulvio added a comment to D11781: Refactored pthread usage in libcxx.

Hi, could I know the status of this? I'd like to push this forward.

@espositofulvio: Are you working on this? (just checking since this has gone stale for a while). @EricWF: I can create a separate diff for further review if this one is too cluttered.

Apr 16 2016, 7:48 AM

Sep 5 2015

espositofulvio updated the diff for D11781: Refactored pthread usage in libcxx.
  • Addressed possible ABI breaks
  • Reverted to not using a __config_file as @jroelofs has two separate patches for that
Sep 5 2015, 5:12 AM

Aug 19 2015

espositofulvio added inline comments to D11781: Refactored pthread usage in libcxx.
Aug 19 2015, 2:39 AM
espositofulvio added a comment to D11781: Refactored pthread usage in libcxx.

This patch has a long way to go but it has also come a long way. Here are a couple of problems I see with it.

  1. This patch adds a lot of headers. libc++ has historically tried to keep the number of headers to a minimum for the reason that filesystem operations are expensive and its cheaper to include a few big headers as opposed to many small ones.
Aug 19 2015, 2:16 AM

Aug 12 2015

espositofulvio added a comment to D11781: Refactored pthread usage in libcxx.

This feels a bit like a regression. Before, libc++ works fine by just pointing into the include directory.

Aug 12 2015, 3:46 AM
espositofulvio added inline comments to D11963: Create a __config_site file to capture configuration decisions..
Aug 12 2015, 1:14 AM
espositofulvio added a comment to D11781: Refactored pthread usage in libcxx.

How does this change interact with D11963 ?

Aug 12 2015, 12:55 AM

Aug 11 2015

espositofulvio set the repository for D11781: Refactored pthread usage in libcxx to rL LLVM.
Aug 11 2015, 3:42 PM
espositofulvio updated the diff for D11781: Refactored pthread usage in libcxx.

Thread library selection is done at configure time by CMake now.

Aug 11 2015, 3:39 PM
espositofulvio added inline comments to D11781: Refactored pthread usage in libcxx.
Aug 11 2015, 3:28 PM
espositofulvio added inline comments to D11781: Refactored pthread usage in libcxx.
Aug 11 2015, 2:24 AM

Aug 10 2015

espositofulvio added inline comments to D11781: Refactored pthread usage in libcxx.
Aug 10 2015, 4:06 PM
espositofulvio added inline comments to D11781: Refactored pthread usage in libcxx.
Aug 10 2015, 3:16 PM
espositofulvio added a comment to D11781: Refactored pthread usage in libcxx.
Aug 10 2015, 1:40 PM
espositofulvio updated the diff for D11781: Refactored pthread usage in libcxx.

Added CloudABI to the list of platform using pthread

Aug 10 2015, 1:39 PM
espositofulvio added inline comments to D11781: Refactored pthread usage in libcxx.
Aug 10 2015, 1:31 PM

Aug 8 2015

espositofulvio added inline comments to D11781: Refactored pthread usage in libcxx.
Aug 8 2015, 1:23 PM
espositofulvio added a comment to D11781: Refactored pthread usage in libcxx.

This version looks much better (well, the previous one is cleaner, but this one looks like it shouldn't break the ABI - did you test this? It looks like it should work, but I've not actually tried it).

Aug 8 2015, 1:12 PM
espositofulvio set the repository for D11781: Refactored pthread usage in libcxx to rL LLVM.
Aug 8 2015, 12:28 PM
espositofulvio updated the diff for D11781: Refactored pthread usage in libcxx.

To avoid breaking public api and ABI, the os abstraction layer is made up of typedefs for pthread types + plain functions that are called from the std:: stuff.
The recursive mutex layer is identical for pthread to the mutex layer because pthread internally select locking implementation depending on the mutex attributes, but we need both because on Windows the recursive stuff must be implemented with a counter.

Aug 8 2015, 12:19 PM

Aug 7 2015

espositofulvio added inline comments to D11781: Refactored pthread usage in libcxx.
Aug 7 2015, 2:42 AM

Aug 6 2015

espositofulvio added inline comments to D11781: Refactored pthread usage in libcxx.
Aug 6 2015, 4:04 PM
espositofulvio added inline comments to D11781: Refactored pthread usage in libcxx.
Aug 6 2015, 7:21 AM

Aug 5 2015

espositofulvio added a reviewer for D11781: Refactored pthread usage in libcxx: danalbert.
Aug 5 2015, 4:23 PM
espositofulvio retitled D11781: Refactored pthread usage in libcxx from to Refactored pthread usage in libcxx.
Aug 5 2015, 2:40 PM