Page MenuHomePhabricator

ericLemanissier (Eric Lemanissier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2016, 6:38 AM (150 w, 7 h)

Recent Activity

Aug 1 2016

ericLemanissier added a comment to D22513: [clang-tidy] add check cppcoreguidelines-special-member-functions.

I have an segfault on all the source files of my project when I enable this check (it works ok when I disable this check). Sorry I don't have time to post a minimal source file producing the segfault. I will maybe tomorrow, or in two weeks.

Aug 1 2016, 3:06 AM · Restricted Project

Jul 19 2016

ericLemanissier updated subscribers of D22513: [clang-tidy] add check cppcoreguidelines-special-member-functions.
Jul 19 2016, 7:38 AM · Restricted Project

Jul 18 2016

ericLemanissier updated subscribers of D16376: clang-tidy check: cppcoreguidelines-rule-of-five-and-zero.
Jul 18 2016, 8:49 AM

Jul 14 2016

ericLemanissier added a comment to D22196: Fix Bug "28480 - cppcoreguidelines-pro-bounds-array-to-pointer-decay handling __PRETTY_FUNCTION__".

having studied cpp core guidelines in more depth, I completely understand that the problem in the case I described is that the function receiving PRETTY_FUNCTION takes a const char* parameter, whereas it should take a czstring or szstring_span. As a consequence this patch is not a good thing.

Jul 14 2016, 6:17 AM
ericLemanissier added a comment to D22196: Fix Bug "28480 - cppcoreguidelines-pro-bounds-array-to-pointer-decay handling __PRETTY_FUNCTION__".
Jul 14 2016, 6:16 AM

Jul 12 2016

ericLemanissier abandoned D22196: Fix Bug "28480 - cppcoreguidelines-pro-bounds-array-to-pointer-decay handling __PRETTY_FUNCTION__".

Well, C++ Core Guidelines advises in this case to correct function receiving PRETTY_FUNCTION: the parameter type should not be const char* ( https://github.com/isocpp/CppCoreGuidelines/issues/640 )
I'm not sure if it should be cstring_span, czstring_span, or czstring.
In case it is not possible to change this function, I guess the only solution is static_cast<const char*>(__PRETTY_FUNCTION)

Jul 12 2016, 3:24 AM

Jul 10 2016

ericLemanissier retitled D22196: Fix Bug "28480 - cppcoreguidelines-pro-bounds-array-to-pointer-decay handling __PRETTY_FUNCTION__" from to Fix Bug "28480 - cppcoreguidelines-pro-bounds-array-to-pointer-decay handling __PRETTY_FUNCTION__".
Jul 10 2016, 6:44 AM