- User Since
- Jan 7 2017, 9:01 PM (238 w, 3 d)
Jan 29 2019
Looks fine to me, although I confess I did not build and run it because I don't have the time to set up the environment again, took a few hours last time I built from scratch (side note, if there's an easy way to speed up llvm/clang compilation up I'd love to hear it :) ).
You didn't change the tests that I can see, so if those are still passing then it seems to be a fairly successful refactor. However I'm very much a clang newbie (just to be clear), whether this satisfies the original request for a refactor I cannot comment on.
Dec 28 2018
Nov 26 2018
Nov 5 2018
Nov 1 2018
Oct 29 2018
Oct 18 2018
Jul 31 2018
Jun 29 2018
@klimek having gotten that out of the way, I do occasionally drink too much and have sudden urges to re-implement things from scratch. Close it if you need to, since I can't commit to anything, but.... it it happens to be still open on one of those nights, who knows, maybe I'll end up doing it :)
Jun 28 2018
@klimek fair point. To be honest, I've pretty much lost interest / momentum on this feature, I very much doubt I will ever go back and re-implement from scratch as you suggest.
Not meaning to sound rude, I just don't want to waste anyone's time who is waiting for this (seems there are a few).
Jun 16 2018
Apr 11 2018
As far as I know, there are no updates required from me for this pull request-- I rebased on the main trunk recently, and will do it again tonight to be sure. So it should be compiling/working just fine.
I believe it is just awaiting final approval from somebody.
Apr 10 2018
Apr 8 2018
Apr 4 2018
Feb 23 2018
@dtzWill thanks for the suggestion, I have submitted this change to the weekly review corner.
Rebased on current master. No functional changes, just a minor conflict where a variable got re-named
Jan 31 2018
Oct 17 2017
Jul 13 2017
Gaaah. I'm so sorry. I wrote that last comment months ago and never submitted. No wonder you guys weren't responding.
Apr 23 2017
Apr 18 2017
Rebased on latest
Mar 28 2017
Apologies-- forgot to update a comment
Mar 27 2017
Addressed all comments, except for the one about FormatToken.MatchingParen (see reply comment)
Mar 26 2017
Sorry I took so long! Option implemented completely in WhitespaceManager.cpp, so no overhead if the option isn't used. Also some minor style fixes.
Mar 14 2017
@sylvestre.ledru No, unfortunately not. My apologies, I've been taken up with work mostly.
I will make a marked attempt to do it this weekend :)
Feb 1 2017
Thanks :) I should get a chance to return to this next week.
Jan 25 2017
Jan 16 2017
Jan 14 2017
Forgot to set "AlignConsecutiveMacros = false" in getLLVMStyle(), causing some tests added in the past week to fail
Jan 11 2017
Jan 10 2017
Well, your patch is here for me to try, and it looks like it's been accepted. So I guess I should just pull my finger out and try it :)
Thanks for your response-- I'll let you know if I come across any issues.
Jan 9 2017
Hey bmharper :) I've got a review open that conflicts with this one, just having a look to see what I'll need to refactor