Page MenuHomePhabricator

enyquist (Erik Nyquist)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2017, 9:01 PM (152 w, 5 d)

Recent Activity

Jan 29 2019

enyquist added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

Looks fine to me, although I confess I did not build and run it because I don't have the time to set up the environment again, took a few hours last time I built from scratch (side note, if there's an easy way to speed up llvm/clang compilation up I'd love to hear it :) ).
You didn't change the tests that I can see, so if those are still passing then it seems to be a fairly successful refactor. However I'm very much a clang newbie (just to be clear), whether this satisfies the original request for a refactor I cannot comment on.

Jan 29 2019, 8:11 PM · Restricted Project, Unknown Object (Project)

Dec 28 2018

Bmooij awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Dec 28 2018, 8:34 AM · Restricted Project, Unknown Object (Project)

Nov 26 2018

enyquist added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

@smilewithani @lassi.niemisto @mewmew feel free to take a stab at it

Nov 26 2018, 10:47 AM · Restricted Project, Unknown Object (Project)

Nov 5 2018

veegee awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Love token.
Nov 5 2018, 4:43 AM · Restricted Project, Unknown Object (Project)

Nov 1 2018

Maldus512 awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Nov 1 2018, 7:01 AM · Restricted Project, Unknown Object (Project)

Oct 29 2018

micah-s awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Love token.
Oct 29 2018, 6:31 PM · Restricted Project, Unknown Object (Project)

Oct 18 2018

AlexAltea awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Oct 18 2018, 9:46 PM · Restricted Project, Unknown Object (Project)

Jul 31 2018

ve4edj awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Love token.
Jul 31 2018, 11:31 AM · Restricted Project, Unknown Object (Project)
lassi.niemisto awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Jul 31 2018, 4:14 AM · Restricted Project, Unknown Object (Project)

Jun 29 2018

enyquist added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

@klimek having gotten that out of the way, I do occasionally drink too much and have sudden urges to re-implement things from scratch. Close it if you need to, since I can't commit to anything, but.... it it happens to be still open on one of those nights, who knows, maybe I'll end up doing it :)

Jun 29 2018, 7:31 PM · Restricted Project, Unknown Object (Project)

Jun 28 2018

enyquist added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

@klimek fair point. To be honest, I've pretty much lost interest / momentum on this feature, I very much doubt I will ever go back and re-implement from scratch as you suggest.
Not meaning to sound rude, I just don't want to waste anyone's time who is waiting for this (seems there are a few).

Jun 28 2018, 11:24 AM · Restricted Project, Unknown Object (Project)

Jun 16 2018

Dr-Emann awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Jun 16 2018, 7:19 PM · Restricted Project, Unknown Object (Project)

Apr 11 2018

enyquist added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

As far as I know, there are no updates required from me for this pull request-- I rebased on the main trunk recently, and will do it again tonight to be sure. So it should be compiling/working just fine.
I believe it is just awaiting final approval from somebody.

Apr 11 2018, 1:33 PM · Restricted Project, Unknown Object (Project)
enyquist updated the summary of D28462: clang-format: Add new style option AlignConsecutiveMacros.
Apr 11 2018, 1:32 PM · Restricted Project, Unknown Object (Project)

Apr 10 2018

markoshorro awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Love token.
Apr 10 2018, 5:27 AM · Restricted Project, Unknown Object (Project)

Apr 8 2018

elvinio awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Apr 8 2018, 11:49 PM · Restricted Project, Unknown Object (Project)

Apr 4 2018

TimF awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Apr 4 2018, 11:45 PM · Restricted Project, Unknown Object (Project)

Feb 23 2018

enyquist added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

@dtzWill thanks for the suggestion, I have submitted this change to the weekly review corner.

Feb 23 2018, 6:33 PM · Restricted Project, Unknown Object (Project)
enyquist updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.

Rebased on current master. No functional changes, just a minor conflict where a variable got re-named

Feb 23 2018, 5:20 PM · Restricted Project, Unknown Object (Project)

Jan 31 2018

tannewt awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Jan 31 2018, 2:24 PM · Restricted Project, Unknown Object (Project)

Oct 17 2017

jzr awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Oct 17 2017, 5:16 PM · Restricted Project, Unknown Object (Project)

Jul 13 2017

enyquist added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

Gaaah. I'm so sorry. I wrote that last comment months ago and never submitted. No wonder you guys weren't responding.

Jul 13 2017, 3:58 PM · Restricted Project, Unknown Object (Project)

Apr 23 2017

enyquist added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Apr 23 2017, 8:32 PM · Restricted Project, Unknown Object (Project)
enyquist updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.

Addressed comments

Apr 23 2017, 4:05 PM · Restricted Project, Unknown Object (Project)
enyquist added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Apr 23 2017, 4:03 PM · Restricted Project, Unknown Object (Project)

Apr 18 2017

enyquist updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.

Rebased on latest

Apr 18 2017, 8:24 PM · Restricted Project, Unknown Object (Project)

Mar 28 2017

enyquist updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.

Apologies-- forgot to update a comment

Mar 28 2017, 10:16 PM · Restricted Project, Unknown Object (Project)
enyquist added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Mar 28 2017, 7:43 PM · Restricted Project, Unknown Object (Project)
enyquist updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.
Mar 28 2017, 7:43 PM · Restricted Project, Unknown Object (Project)

Mar 27 2017

enyquist updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.

Addressed all comments, except for the one about FormatToken.MatchingParen (see reply comment)

Mar 27 2017, 7:59 PM · Restricted Project, Unknown Object (Project)
enyquist added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Mar 27 2017, 7:51 PM · Restricted Project, Unknown Object (Project)

Mar 26 2017

enyquist updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.

Sorry I took so long! Option implemented completely in WhitespaceManager.cpp, so no overhead if the option isn't used. Also some minor style fixes.

Mar 26 2017, 7:43 PM · Restricted Project, Unknown Object (Project)

Mar 14 2017

enyquist added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

@sylvestre.ledru No, unfortunately not. My apologies, I've been taken up with work mostly.
I will make a marked attempt to do it this weekend :)

Mar 14 2017, 9:55 AM · Restricted Project, Unknown Object (Project)

Feb 1 2017

enyquist added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

Thanks :) I should get a chance to return to this next week.

Feb 1 2017, 11:47 AM · Restricted Project, Unknown Object (Project)

Jan 25 2017

rian.sanderson awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Love token.
Jan 25 2017, 11:44 PM · Restricted Project, Unknown Object (Project)

Jan 16 2017

enyquist added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Jan 16 2017, 10:19 AM · Restricted Project, Unknown Object (Project)

Jan 14 2017

enyquist updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.

Forgot to set "AlignConsecutiveMacros = false" in getLLVMStyle(), causing some tests added in the past week to fail

Jan 14 2017, 9:01 PM · Restricted Project, Unknown Object (Project)

Jan 11 2017

enyquist updated D28462: clang-format: Add new style option AlignConsecutiveMacros.
Jan 11 2017, 7:01 PM · Restricted Project, Unknown Object (Project)

Jan 10 2017

enyquist added a comment to D21279: Fix some issues in clang-format's AlignConsecutive modes.

Well, your patch is here for me to try, and it looks like it's been accepted. So I guess I should just pull my finger out and try it :)
Thanks for your response-- I'll let you know if I come across any issues.

Jan 10 2017, 10:47 AM · Unknown Object (Project)

Jan 9 2017

enyquist added a comment to D21279: Fix some issues in clang-format's AlignConsecutive modes.

Hey bmharper :) I've got a review open that conflicts with this one, just having a look to see what I'll need to refactor
(https://reviews.llvm.org/D28462).

Jan 9 2017, 4:57 PM · Unknown Object (Project)

Jan 8 2017

enyquist updated D28462: clang-format: Add new style option AlignConsecutiveMacros.
Jan 8 2017, 9:15 PM · Restricted Project, Unknown Object (Project)
enyquist updated D28462: clang-format: Add new style option AlignConsecutiveMacros.
Jan 8 2017, 9:03 PM · Restricted Project, Unknown Object (Project)
enyquist updated D28462: clang-format: Add new style option AlignConsecutiveMacros.
Jan 8 2017, 9:00 PM · Restricted Project, Unknown Object (Project)
enyquist updated D28462: clang-format: Add new style option AlignConsecutiveMacros.
Jan 8 2017, 9:00 PM · Restricted Project, Unknown Object (Project)
enyquist retitled D28462: clang-format: Add new style option AlignConsecutiveMacros from to clang-format: Add new style option AlignConsecutiveMacros.
Jan 8 2017, 7:50 PM · Restricted Project, Unknown Object (Project)