Page MenuHomePhabricator

enrico271 (Enrico Tanuwidjaja)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 12 2019, 12:01 PM (28 w, 1 d)

Recent Activity

Sep 19 2019

enrico271 added a comment to D67512: [Analysis] Allow -scalar-evolution-max-iterations more than once.

scalar-evolution-max-iterations flag allows us to override the 100 iterations limit for constant derived loop, which we need for optimization, as we have many constant derived loops with > 100 iterations

Sep 19 2019, 10:57 AM · Restricted Project

Sep 12 2019

enrico271 added a comment to D67512: [Analysis] Allow -scalar-evolution-max-iterations more than once.

@xbolva00 Thanks for your input!
The idea is similar to this change: https://reviews.llvm.org/D34219. I don't view it as a workaround, but rather it increases flexibility in the flag usage. The expected behavior is already well documented:

The cl::ZeroOrMore modifier ... indicates that your program will allow the option to be specified zero or more times.
If an option is specified multiple times for an option of the cl::opt class, only the last value will be retained.

I see a bunch of other flags use cl::ZeroOrMore as well so I believe this is no different.

Sep 12 2019, 1:57 PM · Restricted Project
enrico271 updated the summary of D67512: [Analysis] Allow -scalar-evolution-max-iterations more than once.
Sep 12 2019, 12:14 PM · Restricted Project
enrico271 created D67512: [Analysis] Allow -scalar-evolution-max-iterations more than once.
Sep 12 2019, 12:10 PM · Restricted Project