Page MenuHomePhabricator

emmettneyman (Emmett Neyman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 1 2018, 3:06 PM (59 w, 1 d)

Recent Activity

Thu, Jul 18

emmettneyman updated the diff for D64380: Add 'require_designated_init' and 'required' attribute to clang.

Created diagnostic group, added behavior and documentation for private fields, added documentation regarding GCC attribute

Thu, Jul 18, 12:16 PM · Restricted Project

Tue, Jul 16

emmettneyman planned changes to D64380: Add 'require_designated_init' and 'required' attribute to clang.

Changes planned:

  • Move diagnostics into a diagnostic group.
  • Add behavior and test cases for private members of structs/classes.
  • Investigate behavior of GCC designated_init attribute
Tue, Jul 16, 1:23 PM · Restricted Project

Thu, Jul 11

emmettneyman added inline comments to D64380: Add 'require_designated_init' and 'required' attribute to clang.
Thu, Jul 11, 4:16 PM · Restricted Project
emmettneyman updated the diff for D64380: Add 'require_designated_init' and 'required' attribute to clang.

Added documentation about using the attributes with unions.

Thu, Jul 11, 3:50 PM · Restricted Project
emmettneyman added inline comments to D64380: Add 'require_designated_init' and 'required' attribute to clang.
Thu, Jul 11, 11:17 AM · Restricted Project
emmettneyman updated the diff for D64380: Add 'require_designated_init' and 'required' attribute to clang.

Small changes: adding auto

Thu, Jul 11, 10:42 AM · Restricted Project

Wed, Jul 10

emmettneyman planned changes to D64380: Add 'require_designated_init' and 'required' attribute to clang.

Working on adding more information to the documentation and adding more in-depth unit tests.

Wed, Jul 10, 4:55 PM · Restricted Project
emmettneyman added inline comments to D64380: Add 'require_designated_init' and 'required' attribute to clang.
Wed, Jul 10, 4:51 PM · Restricted Project
emmettneyman updated the diff for D64380: Add 'require_designated_init' and 'required' attribute to clang.

Addressed several of the comments regarding naming and style.

Wed, Jul 10, 4:50 PM · Restricted Project
emmettneyman planned changes to D64380: Add 'require_designated_init' and 'required' attribute to clang.
Wed, Jul 10, 12:30 PM · Restricted Project

Tue, Jul 9

emmettneyman added inline comments to D64380: Add 'require_designated_init' and 'required' attribute to clang.
Tue, Jul 9, 5:35 PM · Restricted Project
emmettneyman added a comment to D64380: Add 'require_designated_init' and 'required' attribute to clang.

I don't see any cases where [[clang::required]] is tested, am I missing something?

Tue, Jul 9, 5:33 PM · Restricted Project
emmettneyman updated the diff for D64380: Add 'require_designated_init' and 'required' attribute to clang.

slight change to specification reference format

Tue, Jul 9, 4:54 PM · Restricted Project
emmettneyman updated the diff for D64380: Add 'require_designated_init' and 'required' attribute to clang.

Remove cppreference link, add reference to C++ spec.

Tue, Jul 9, 4:46 PM · Restricted Project
emmettneyman updated the diff for D64380: Add 'require_designated_init' and 'required' attribute to clang.

Updated tests and diagnostic messages with new attribute spelling

Tue, Jul 9, 3:31 PM · Restricted Project
emmettneyman updated the summary of D64380: Add 'require_designated_init' and 'required' attribute to clang.
Tue, Jul 9, 2:49 PM · Restricted Project
emmettneyman updated the summary of D64380: Add 'require_designated_init' and 'required' attribute to clang.
Tue, Jul 9, 2:43 PM · Restricted Project
emmettneyman updated the summary of D64380: Add 'require_designated_init' and 'required' attribute to clang.
Tue, Jul 9, 2:41 PM · Restricted Project
emmettneyman updated the diff for D64380: Add 'require_designated_init' and 'required' attribute to clang.

Changed attribute spelling from GNU to CXX11 and renamed the 'required' attribute to 'designated_init_required'

Tue, Jul 9, 2:39 PM · Restricted Project
emmettneyman planned changes to D64380: Add 'require_designated_init' and 'required' attribute to clang.
Tue, Jul 9, 11:49 AM · Restricted Project
emmettneyman updated the diff for D64380: Add 'require_designated_init' and 'required' attribute to clang.

Small changes in response to feedback

Tue, Jul 9, 10:57 AM · Restricted Project

Mon, Jul 8

emmettneyman added reviewers for D64380: Add 'require_designated_init' and 'required' attribute to clang: EricWF, doug.gregor.
Mon, Jul 8, 6:00 PM · Restricted Project
emmettneyman updated the summary of D64380: Add 'require_designated_init' and 'required' attribute to clang.
Mon, Jul 8, 5:53 PM · Restricted Project
emmettneyman updated the diff for D64380: Add 'require_designated_init' and 'required' attribute to clang.

Undo clang-format changes to SemaDecl.cpp and SemaDeclAttr.cpp

Mon, Jul 8, 5:08 PM · Restricted Project
emmettneyman created D64380: Add 'require_designated_init' and 'required' attribute to clang.
Mon, Jul 8, 4:31 PM · Restricted Project

Aug 16 2018

emmettneyman committed rC339933: Update README and Dockerfile to include llvm-proto-fuzzer.
Update README and Dockerfile to include llvm-proto-fuzzer
Aug 16 2018, 1:14 PM
emmettneyman committed rL339933: Update README and Dockerfile to include llvm-proto-fuzzer.
Update README and Dockerfile to include llvm-proto-fuzzer
Aug 16 2018, 1:14 PM
emmettneyman closed D50829: Update README and Dockerfile to include llvm-proto-fuzzer.
Aug 16 2018, 1:14 PM
emmettneyman updated the diff for D50829: Update README and Dockerfile to include llvm-proto-fuzzer.

Rebased and ready to land

Aug 16 2018, 1:13 PM
emmettneyman updated the diff for D50829: Update README and Dockerfile to include llvm-proto-fuzzer.

Added to README

Aug 16 2018, 11:27 AM

Aug 15 2018

emmettneyman added a comment to D50829: Update README and Dockerfile to include llvm-proto-fuzzer.

Is there anything I should add to the documentation? Anything I should remove?

Aug 15 2018, 5:46 PM
emmettneyman created D50829: Update README and Dockerfile to include llvm-proto-fuzzer.
Aug 15 2018, 5:45 PM
emmettneyman committed rL339832: Implementation of nested loops in cxx_loop_proto.
Implementation of nested loops in cxx_loop_proto
Aug 15 2018, 4:06 PM
emmettneyman committed rC339832: Implementation of nested loops in cxx_loop_proto.
Implementation of nested loops in cxx_loop_proto
Aug 15 2018, 4:06 PM
emmettneyman closed D50670: Implementation of nested loops in cxx_loop_proto.
Aug 15 2018, 4:06 PM
emmettneyman updated the diff for D50670: Implementation of nested loops in cxx_loop_proto.

Updated comments, rebased, and ready to land

Aug 15 2018, 4:04 PM
emmettneyman updated the diff for D50670: Implementation of nested loops in cxx_loop_proto.

Changed modifying global var to scoped class

Aug 15 2018, 3:47 PM
emmettneyman updated the diff for D50670: Implementation of nested loops in cxx_loop_proto.

Made the inner loop optional and moved all modifications of inner_loop to one function.

Aug 15 2018, 2:37 PM
emmettneyman added inline comments to D50670: Implementation of nested loops in cxx_loop_proto.
Aug 15 2018, 1:16 PM
emmettneyman updated the diff for D50670: Implementation of nested loops in cxx_loop_proto.

Small changes to generated IR, my last change hadn't saved

Aug 15 2018, 11:32 AM
emmettneyman updated the diff for D50670: Implementation of nested loops in cxx_loop_proto.

Small changes to generated IR

Aug 15 2018, 11:21 AM
emmettneyman added a comment to D50670: Implementation of nested loops in cxx_loop_proto.

Does this hit new coverage in the vectorizer?

Aug 15 2018, 11:18 AM

Aug 14 2018

emmettneyman retitled D50670: Implementation of nested loops in cxx_loop_proto from Implementation of multiple loops in cxx_loop_proto to Implementation of nested loops in cxx_loop_proto.
Aug 14 2018, 6:12 PM
emmettneyman updated the diff for D50670: Implementation of nested loops in cxx_loop_proto.

Changed the multiloop protos to nested loop protos. All the protos have an inner loop and an outer loop.

Aug 14 2018, 6:11 PM
emmettneyman added a comment to D50670: Implementation of nested loops in cxx_loop_proto.

No, it doesn't actually. I thought it would try to combine the separate loops into one block of vectorized instructions but after looking at the coverage of multiple loops vs single loop, they cover exactly the same parts of the Loop Vectorizer. Should I switch my focus to nested loops instead? I think nested loops will increase coverage.

Aug 14 2018, 11:43 AM

Aug 13 2018

emmettneyman created D50670: Implementation of nested loops in cxx_loop_proto.
Aug 13 2018, 3:37 PM

Aug 9 2018

emmettneyman committed rC339392: Added LLVM metadata to generated IR to increase vectorization width.
Added LLVM metadata to generated IR to increase vectorization width
Aug 9 2018, 2:59 PM
emmettneyman committed rL339392: Added LLVM metadata to generated IR to increase vectorization width.
Added LLVM metadata to generated IR to increase vectorization width
Aug 9 2018, 2:59 PM
emmettneyman closed D50530: Added LLVM metadata to generated IR to increase vectorization width.
Aug 9 2018, 2:59 PM
emmettneyman updated the diff for D50530: Added LLVM metadata to generated IR to increase vectorization width.

Rebased and ready to land

Aug 9 2018, 2:58 PM
emmettneyman updated the diff for D50530: Added LLVM metadata to generated IR to increase vectorization width.

Switched the include statement to the cpp file

Aug 9 2018, 1:21 PM
emmettneyman added inline comments to D50530: Added LLVM metadata to generated IR to increase vectorization width.
Aug 9 2018, 1:21 PM
emmettneyman created D50530: Added LLVM metadata to generated IR to increase vectorization width.
Aug 9 2018, 12:54 PM

Aug 8 2018

emmettneyman committed rC339305: Added another optimization pass to make vectorizing possible.
Added another optimization pass to make vectorizing possible
Aug 8 2018, 5:59 PM
emmettneyman committed rL339305: Added another optimization pass to make vectorizing possible.
Added another optimization pass to make vectorizing possible
Aug 8 2018, 5:59 PM
emmettneyman closed D50482: Added another optimization pass to make vectorizing possible.
Aug 8 2018, 5:59 PM
emmettneyman updated the diff for D50482: Added another optimization pass to make vectorizing possible.
Rebase
Aug 8 2018, 5:57 PM
emmettneyman added inline comments to D50482: Added another optimization pass to make vectorizing possible.
Aug 8 2018, 5:43 PM
emmettneyman updated the diff for D50482: Added another optimization pass to make vectorizing possible.
  • Inlined function
Aug 8 2018, 5:31 PM
emmettneyman added inline comments to D50482: Added another optimization pass to make vectorizing possible.
Aug 8 2018, 5:28 PM
emmettneyman updated the diff for D50482: Added another optimization pass to make vectorizing possible.
  • minor style fix
Aug 8 2018, 5:00 PM
emmettneyman created D50482: Added another optimization pass to make vectorizing possible.
Aug 8 2018, 4:54 PM

Aug 6 2018

emmettneyman committed rC339080: Changed how LLVM IR was generated to increase vectorization.
Changed how LLVM IR was generated to increase vectorization
Aug 6 2018, 4:12 PM
emmettneyman committed rL339080: Changed how LLVM IR was generated to increase vectorization.
Changed how LLVM IR was generated to increase vectorization
Aug 6 2018, 4:12 PM
emmettneyman closed D50342: Changed how LLVM IR was generated to increase vectorization.
Aug 6 2018, 4:12 PM
emmettneyman updated the diff for D50342: Changed how LLVM IR was generated to increase vectorization.
Rebased and ready to land
Aug 6 2018, 4:11 PM
emmettneyman updated the diff for D50342: Changed how LLVM IR was generated to increase vectorization.

Some small fixes to improve simplicity of generated IR

Aug 6 2018, 3:51 PM
emmettneyman added inline comments to D50342: Changed how LLVM IR was generated to increase vectorization.
Aug 6 2018, 3:50 PM
emmettneyman updated the diff for D50342: Changed how LLVM IR was generated to increase vectorization.

Added back more descriptive variable and loop names

Aug 6 2018, 2:00 PM
emmettneyman updated the diff for D50342: Changed how LLVM IR was generated to increase vectorization.

Changed pc to unknown

Aug 6 2018, 1:06 PM
emmettneyman added inline comments to D50342: Changed how LLVM IR was generated to increase vectorization.
Aug 6 2018, 1:05 PM
emmettneyman created D50342: Changed how LLVM IR was generated to increase vectorization.
Aug 6 2018, 10:53 AM

Aug 3 2018

emmettneyman committed rL338943: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.
LLVM Proto Fuzzer - Run Functions on Suite of Inputs
Aug 3 2018, 6:19 PM
emmettneyman committed rC338943: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.
LLVM Proto Fuzzer - Run Functions on Suite of Inputs
Aug 3 2018, 6:19 PM
emmettneyman closed D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.
Aug 3 2018, 6:19 PM
emmettneyman updated the diff for D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.

ready to land

Aug 3 2018, 6:17 PM
emmettneyman updated the diff for D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.

New input arrays and minor fixes

Aug 3 2018, 5:41 PM
emmettneyman updated the diff for D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.

Added static to some functions, made small fixes

Aug 3 2018, 3:03 PM
emmettneyman added inline comments to D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.
Aug 3 2018, 2:49 PM
emmettneyman updated the diff for D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.

Refactored code to avoid memcpy-ing function

Aug 3 2018, 1:58 PM
emmettneyman added a comment to D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.

An unrelated question:
Right now I have a mix of static and non-static functions in handle_llvm.cpp. Should they all be static?

Aug 3 2018, 11:00 AM
emmettneyman added inline comments to D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.
Aug 3 2018, 10:57 AM

Aug 2 2018

emmettneyman updated the diff for D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.

Replaced hardcoded numbers with variables

Aug 2 2018, 11:01 AM
emmettneyman added inline comments to D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.
Aug 2 2018, 10:58 AM
emmettneyman created D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs.
Aug 2 2018, 9:44 AM

Jul 31 2018

emmettneyman accepted D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp..
Jul 31 2018, 8:49 AM

Jul 26 2018

emmettneyman committed rL338091: added shared library to fix buildbot.
added shared library to fix buildbot
Jul 26 2018, 5:43 PM
emmettneyman committed rC338091: added shared library to fix buildbot.
added shared library to fix buildbot
Jul 26 2018, 5:43 PM
emmettneyman closed D49895: added shared library to fix buildbot.
Jul 26 2018, 5:43 PM
emmettneyman created D49895: added shared library to fix buildbot.
Jul 26 2018, 5:42 PM
emmettneyman abandoned D49892: Added shared library to fix build bot.
Jul 26 2018, 5:31 PM
emmettneyman created D49892: Added shared library to fix build bot.
Jul 26 2018, 5:22 PM
emmettneyman committed rC338077: Updated llvm-proto-fuzzer to execute the compiled code.
Updated llvm-proto-fuzzer to execute the compiled code
Jul 26 2018, 3:23 PM
emmettneyman committed rL338077: Updated llvm-proto-fuzzer to execute the compiled code.
Updated llvm-proto-fuzzer to execute the compiled code
Jul 26 2018, 3:23 PM
emmettneyman closed D49526: Updated llvm-proto-fuzzer to execute the compiled code.
Jul 26 2018, 3:23 PM
emmettneyman updated the diff for D49526: Updated llvm-proto-fuzzer to execute the compiled code.

Made some minor fixes

Jul 26 2018, 2:32 PM
emmettneyman updated the diff for D49526: Updated llvm-proto-fuzzer to execute the compiled code.

Changed int to CodeGenOpt::Level and fixed unique_ptr issue

Jul 26 2018, 1:03 PM
emmettneyman added a comment to D49526: Updated llvm-proto-fuzzer to execute the compiled code.

Do we need to parse the arguments for opt-level, or can we just hardcode -O2 and remove the argument parsing code?

Jul 26 2018, 1:00 PM
emmettneyman updated the diff for D49526: Updated llvm-proto-fuzzer to execute the compiled code.

Small change to fix line length

Jul 26 2018, 11:50 AM
emmettneyman updated the diff for D49526: Updated llvm-proto-fuzzer to execute the compiled code.
  • Code style fixes
  • Removed FPasses
  • Allowed CL Args to specify opt level for OptLLVM()
Jul 26 2018, 11:48 AM