- User Since
- Jun 13 2022, 3:13 PM (14 w, 5 d)
Fri, Aug 26
Thanks for reverting @reames - when you have a second maybe you could have a look over this updated patch?
Sorry for the failed test - I ran update_test_checks against test/Transforms/InstCombine/freeze.ll,
and the changes I verified using Alive2 https://alive2.llvm.org/ce/z/4ABLcz
Aug 24 2022
These NFC variable name changes were in anticipation of functional changes from D131142, but since that patch no longer changes the test in question (llvm/test/Transforms/InstCombine/integer-round-up-pow2-alignment.ll), these NFC changes made by update_test_checks.py separated out here probably can be abandoned.
This patch now does not affect integer-round-up-pow2-alignment.ll (since those changes merged via rGf82c55fa082711f520a7359393b483956b69bf08). So, the NFC changes (changes of variable names) that update_test_checks would make don't have to be addressed at this time (I don't think). I did pull those NFC changes to this test out anyway as D132564, but as said I don't think this needs to be messed with just now.
Rebase & Address comments
Address comments (bad hex values in comments for 112 and 15)
changed commit msg
Aug 11 2022
Aug 10 2022
Needed to run update_test_checks.py against add.ll
Added clarifying comment in test
Updated on top of vector tests
Added vector tests
Aug 9 2022
Aug 5 2022
Update on top of new negative multiple use tests in and-xor-or.ll
Added multiple use negative tests
Aug 4 2022
I need a few more test cases I'd neglected (multiple use negative case at least) I am realizing, will update patch.
Aug 3 2022
I wasn't sure whether to subsume D130080 or make this revision a child of that one.
Hadn't run clang-format
Jun 19 2022
Prefer less IsAnd constructs in matching logic, update test results.
Jun 18 2022
Added tests to make sure other sign-bit tests are picked up as well
Added four more negative tests that violate constraints.
Assertions in test CHECK lines now generated via utils/update_test_checks.py
Oh dang my bad on that - I had actually read in the testing infra guide about those scripts, and really ought to have used them - I'll do so now.
Fixed one more incorrect use of capturing in CHECK line.
Fixed more incorrect use of capture in CHECK line in one test.
A few of the tests contained incorrect syntax in the CHECK lines. They were re-capturing variables (i.e. [[x:%.*]]) instead of matching where needed [[x]].
Jun 17 2022
Not using m_c matchers on first match and added "Negative" tests and tests for commutativity of inputs and compares.
Ah of course - sorry for that - I will submit a new diff for this revision (including suggested changes) against the main branch (not previous diff).
Jun 16 2022
Updated patch to cover the inverted form as well and wrote 5 more tests.
Trying to ensure we only reduce iff intermediate values have one use only.
Jun 15 2022
I am in the process of writing more regression tests, but I may need to ask a few questions on that - thank you for your help thus far.