- User Since
- Jul 18 2016, 2:10 PM (160 w, 5 d)
Oct 8 2018
Sep 19 2018
I did try a copy of D50949 again, locally and without this diff, to see if I can avoid messing with this structure altogether. But then I get a SEGV.
Change Optional to unique_ptr instead, to at least save an allocation and keep the same semantics. Reverified with ninja check-clang.
rebase atop D50948 (correctly this time) to exclude those changes
Sep 18 2018
Rebase atop updated dependency D50948. Small cleanups to this diff.
Rebase past dependency commit C341499, fix a conflict
Sep 5 2018
that's great news, thanks!
I'll drop this one, since this is not the logic change we want.
Hi @rsmith ! Thanks for taking a look at this. I'd much prefer to fix the underlying problem and not swat at these symptoms, so thanks for the analysis of what's actually going on here. :) Let me take a stab at fixing the real problem in the manner you describe.
Sep 4 2018
Abandoning in favor of https://reviews.llvm.org/D51608 which works better.
Sep 3 2018
Sep 2 2018
Aug 19 2018
This broke some tests. It fixes the test case added here under test/Modules but causes errors in test/CodeGenCXX and other dirs.
fix dopey copy-paste error. Tested again with ninja check-clang-modules
Aug 18 2018
Aug 17 2018
Rebase + fix conflicts for very old diff. Works again.
Aug 13 2018
Dropped in favor of other fix as mentioned above
Jul 31 2018
awesome! thanks again @rsmith
hi @rsmith have a look and let me know if this change looks sensible :) Please make sure I have the right mental model for inheritance in the module case
Jul 27 2018
cc @rsmith as this has to do with modules.
Rebase very old diff
Jan 23 2018
Jan 18 2018
remove unneeded changes
Fixes, but first, a question for reviewers:
Thanks very much for looking at this @vsk ! I actually found an ASAN bug in my new code, mixing and matching malloc/free and operators new/delete.
Jan 17 2018
Add a needed null-check on input string's data ptr.
Jan 16 2018
Change string-copy-on-demand logic; do only if not IsNullTerminated.
Jan 14 2018
Jan 10 2018
Thanks all! Seems I'm unable to land this.
Jan 3 2018
Update: now works properly with modules as well.
Jan 2 2018
Fixed local var names. Using arc diff which hopefully submits latest changes w/ full context
Hi @arphaman, thanks very much! Sorry, I didn't notice there was activity on this old patch until now.
Oct 6 2017
Sep 28 2017
Sep 27 2017
I submitted this patch relative to the clang project root, hopefully that's ok.
Jul 9 2017
ah! Thanks @dylanmckay, didn't see that option in docs :)
Jul 5 2017
Mar 2 2017
I'm not so sure about what caused my random-garbage values, actually. Looks like TemplateArgument::Type and ArgKind::Type both come out to 1, correctly. The word Type in the original could be a variable inherited somewhere, just a guess. Of course if it were the clang type clang::Type, itself, that would be a parse error.
Nov 15 2016
Ping, this is done (and fixed, tests worked ok)
Nov 13 2016
Ping. Also note, looks good on windows; local run of check-clang went ok.
Oct 28 2016
This is a duplicate of the other failing diff D25153 but with the mentioned correction.
Ping, can anyone help with committing this? It's accepted, just needs to be landed. (I don't have commit access.) Thanks!
Oct 20 2016
Fixed an error. A newline is sometimes not appended prior to this #include.
Oct 19 2016
ping - seems I'm unable to commit this myself. Thanks!
Oct 17 2016
I'll need help landing this... I also tried git svn dcommit but command hung there forever.
Oct 15 2016
Thank you! I tried with`arc land` but got a 403...