Page MenuHomePhabricator

elsteveogrande (Steve O'Brien)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2016, 2:10 PM (160 w, 5 d)

Recent Activity

Oct 8 2018

elsteveogrande accepted D52956: Support `-fno-visibility-inlines-hidden`.

lgtm!

Oct 8 2018, 10:24 AM · Restricted Project

Sep 19 2018

elsteveogrande added a comment to D50948: lambdas in modules: change storage for LambdaDefinitionData.

I did try a copy of D50949 again, locally and without this diff, to see if I can avoid messing with this structure altogether. But then I get a SEGV.

Sep 19 2018, 12:26 PM
elsteveogrande updated the diff for D50948: lambdas in modules: change storage for LambdaDefinitionData.

Change Optional to unique_ptr instead, to at least save an allocation and keep the same semantics. Reverified with ninja check-clang.

Sep 19 2018, 11:13 AM
elsteveogrande updated the diff for D50949: lambdas in modules: handle lambdas in .pcm [de]serialization.

rebase atop D50948 (correctly this time) to exclude those changes

Sep 19 2018, 7:58 AM

Sep 18 2018

elsteveogrande added inline comments to D50948: lambdas in modules: change storage for LambdaDefinitionData.
Sep 18 2018, 3:36 PM
elsteveogrande updated the diff for D50949: lambdas in modules: handle lambdas in .pcm [de]serialization.

Rebase atop updated dependency D50948. Small cleanups to this diff.

Sep 18 2018, 6:04 AM
elsteveogrande updated the summary of D50949: lambdas in modules: handle lambdas in .pcm [de]serialization.
Sep 18 2018, 6:04 AM
elsteveogrande updated the diff for D50948: lambdas in modules: change storage for LambdaDefinitionData.

Rebase past dependency commit C341499, fix a conflict

Sep 18 2018, 5:59 AM
elsteveogrande added a child revision for D50948: lambdas in modules: change storage for LambdaDefinitionData: D50949: lambdas in modules: handle lambdas in .pcm [de]serialization.
Sep 18 2018, 5:51 AM
elsteveogrande updated the summary of D50949: lambdas in modules: handle lambdas in .pcm [de]serialization.
Sep 18 2018, 5:51 AM

Sep 5 2018

elsteveogrande abandoned D51608: [modules] when deserializing method, ensure it has correct exception spec.

that's great news, thanks!

Sep 5 2018, 7:59 PM
elsteveogrande abandoned D50947: lambdas in modules: make PendingFakeDefinitionData a set.

I'll drop this one, since this is not the logic change we want.

Sep 5 2018, 7:52 PM
elsteveogrande reclaimed D50947: lambdas in modules: make PendingFakeDefinitionData a set.
Sep 5 2018, 3:06 PM
elsteveogrande abandoned D50947: lambdas in modules: make PendingFakeDefinitionData a set.
Sep 5 2018, 3:06 PM
elsteveogrande added inline comments to D50947: lambdas in modules: make PendingFakeDefinitionData a set.
Sep 5 2018, 9:30 AM
elsteveogrande added a comment to D51608: [modules] when deserializing method, ensure it has correct exception spec.

Hi @rsmith ! Thanks for taking a look at this. I'd much prefer to fix the underlying problem and not swat at these symptoms, so thanks for the analysis of what's actually going on here. :) Let me take a stab at fixing the real problem in the manner you describe.

Sep 5 2018, 6:24 AM

Sep 4 2018

elsteveogrande added reviewers for D50948: lambdas in modules: change storage for LambdaDefinitionData: twoh, modocache.
Sep 4 2018, 8:44 AM
elsteveogrande added reviewers for D50949: lambdas in modules: handle lambdas in .pcm [de]serialization: twoh, modocache.
Sep 4 2018, 8:44 AM
elsteveogrande added reviewers for D50947: lambdas in modules: make PendingFakeDefinitionData a set: twoh, modocache.
Sep 4 2018, 8:40 AM
elsteveogrande added reviewers for D51608: [modules] when deserializing method, ensure it has correct exception spec: twoh, modocache.
Sep 4 2018, 8:31 AM
elsteveogrande added reviewers for D50943: Decl: allow "setInvalidDecl" for TagDecls: twoh, modocache.
Sep 4 2018, 8:31 AM
elsteveogrande added a reviewer for D50943: Decl: allow "setInvalidDecl" for TagDecls: dblaikie.
Sep 4 2018, 7:25 AM
elsteveogrande abandoned D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing.

Abandoning in favor of https://reviews.llvm.org/D51608 which works better.

Sep 4 2018, 7:10 AM

Sep 3 2018

elsteveogrande created D51608: [modules] when deserializing method, ensure it has correct exception spec.
Sep 3 2018, 8:29 PM
elsteveogrande abandoned D51580: (WIP) fix spurious exception spec error, PR38627.
Sep 3 2018, 9:52 AM

Sep 2 2018

elsteveogrande planned changes to D51580: (WIP) fix spurious exception spec error, PR38627.
Sep 2 2018, 8:08 PM
elsteveogrande created D51580: (WIP) fix spurious exception spec error, PR38627.
Sep 2 2018, 8:08 PM

Aug 19 2018

elsteveogrande planned changes to D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing.

This broke some tests. It fixes the test case added here under test/Modules but causes errors in test/CodeGenCXX and other dirs.

Aug 19 2018, 2:12 PM
elsteveogrande added a reviewer for D50948: lambdas in modules: change storage for LambdaDefinitionData: dblaikie.
Aug 19 2018, 1:48 PM
elsteveogrande added a reviewer for D50947: lambdas in modules: make PendingFakeDefinitionData a set: dblaikie.
Aug 19 2018, 1:48 PM
elsteveogrande added a reviewer for D50949: lambdas in modules: handle lambdas in .pcm [de]serialization: dblaikie.
Aug 19 2018, 1:48 PM
elsteveogrande retitled D50949: lambdas in modules: handle lambdas in .pcm [de]serialization from Handle lambdas in .pcm [de]serialization to lambdas in modules: handle lambdas in .pcm [de]serialization.
Aug 19 2018, 1:40 PM
elsteveogrande retitled D50948: lambdas in modules: change storage for LambdaDefinitionData from Change how LambdaDefinitionData is stored to lambdas in modules: change storage for LambdaDefinitionData.
Aug 19 2018, 1:39 PM
elsteveogrande added a reviewer for D50948: lambdas in modules: change storage for LambdaDefinitionData: rsmith.
Aug 19 2018, 1:39 PM
elsteveogrande retitled D50947: lambdas in modules: make PendingFakeDefinitionData a set from make PendingFakeDefinitionData a set, not map of decl data -> enum to lambdas in modules: make PendingFakeDefinitionData a set.
Aug 19 2018, 1:39 PM
elsteveogrande created D50949: lambdas in modules: handle lambdas in .pcm [de]serialization.
Aug 19 2018, 1:38 PM
elsteveogrande created D50948: lambdas in modules: change storage for LambdaDefinitionData.
Aug 19 2018, 1:37 PM
elsteveogrande created D50947: lambdas in modules: make PendingFakeDefinitionData a set.
Aug 19 2018, 1:36 PM
elsteveogrande updated the diff for D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing.

fix dopey copy-paste error. Tested again with ninja check-clang-modules

Aug 19 2018, 9:24 AM
elsteveogrande added inline comments to D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing.
Aug 19 2018, 9:18 AM

Aug 18 2018

elsteveogrande created D50943: Decl: allow "setInvalidDecl" for TagDecls.
Aug 18 2018, 7:02 PM
elsteveogrande updated the summary of D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing.
Aug 18 2018, 6:51 PM
elsteveogrande updated the summary of D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing.
Aug 18 2018, 6:50 PM
elsteveogrande created D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing.
Aug 18 2018, 6:49 PM
elsteveogrande added a comment to D42043: c-index: CXString: fix MSAN read-past-end bug.

hi @vsk + @arphaman , it's been a while -- I brought this old diff up to date, wondering if you could take a look again. Thanks!

Aug 18 2018, 9:53 AM

Aug 17 2018

elsteveogrande updated the diff for D42043: c-index: CXString: fix MSAN read-past-end bug.

Rebase + fix conflicts for very old diff. Works again.

Aug 17 2018, 10:35 PM

Aug 13 2018

elsteveogrande abandoned D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.

Dropped in favor of other fix as mentioned above

Aug 13 2018, 12:33 PM

Jul 31 2018

elsteveogrande added a comment to rL338438: [serialization] PR34728: Don't assume that only a suffix of template.

awesome! thanks again @rsmith

Jul 31 2018, 10:07 PM
elsteveogrande added inline comments to D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.
Jul 31 2018, 7:43 PM
elsteveogrande added a comment to D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.

hi @rsmith have a look and let me know if this change looks sensible :) Please make sure I have the right mental model for inheritance in the module case

Jul 31 2018, 10:27 AM

Jul 27 2018

elsteveogrande updated subscribers of D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.
Jul 27 2018, 9:15 PM
elsteveogrande added a comment to D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.

cc @rsmith as this has to do with modules.

Jul 27 2018, 8:14 AM
elsteveogrande updated the diff for D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.

Rebase very old diff

Jul 27 2018, 7:06 AM

Jan 23 2018

elsteveogrande added a comment to D42043: c-index: CXString: fix MSAN read-past-end bug.

Hi @vsk + @arphaman : I did find such problems with either MSAN (with poison-in-dtor) and ASAN, so we should be able to discover these instances pretty easily :)

Jan 23 2018, 7:38 AM

Jan 18 2018

elsteveogrande updated the diff for D42043: c-index: CXString: fix MSAN read-past-end bug.

remove unneeded changes

Jan 18 2018, 8:31 PM
elsteveogrande updated the diff for D42043: c-index: CXString: fix MSAN read-past-end bug.

Fixes, but first, a question for reviewers:

Jan 18 2018, 8:27 PM
elsteveogrande added inline comments to D42043: c-index: CXString: fix MSAN read-past-end bug.
Jan 18 2018, 12:30 PM
elsteveogrande created D42259: c-index-test: small fix to CXString handling and disposal.
Jan 18 2018, 12:10 PM
elsteveogrande added a comment to D42043: c-index: CXString: fix MSAN read-past-end bug.

Thanks very much for looking at this @vsk ! I actually found an ASAN bug in my new code, mixing and matching malloc/free and operators new/delete.

Jan 18 2018, 11:23 AM

Jan 17 2018

elsteveogrande updated the diff for D42043: c-index: CXString: fix MSAN read-past-end bug.

Add a needed null-check on input string's data ptr.

Jan 17 2018, 11:17 AM

Jan 16 2018

elsteveogrande updated the diff for D42043: c-index: CXString: fix MSAN read-past-end bug.

Change string-copy-on-demand logic; do only if not IsNullTerminated.

Jan 16 2018, 7:34 AM

Jan 14 2018

elsteveogrande updated the summary of D42043: c-index: CXString: fix MSAN read-past-end bug.
Jan 14 2018, 1:11 PM
elsteveogrande updated the summary of D42043: c-index: CXString: fix MSAN read-past-end bug.
Jan 14 2018, 1:11 PM
elsteveogrande created D42043: c-index: CXString: fix MSAN read-past-end bug.
Jan 14 2018, 1:06 PM

Jan 10 2018

elsteveogrande added a comment to D41916: SmallVector: fix use-after-poison MSAN error in destructor.

Thanks all! Seems I'm unable to land this.

Jan 10 2018, 3:27 PM
elsteveogrande updated the summary of D41916: SmallVector: fix use-after-poison MSAN error in destructor.
Jan 10 2018, 1:36 PM
elsteveogrande added reviewers for D41916: SmallVector: fix use-after-poison MSAN error in destructor: eugenis, morehouse.
Jan 10 2018, 1:36 PM
elsteveogrande created D41916: SmallVector: fix use-after-poison MSAN error in destructor.
Jan 10 2018, 1:31 PM

Jan 3 2018

elsteveogrande updated the diff for D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.

Update: now works properly with modules as well.

Jan 3 2018, 8:52 PM

Jan 2 2018

elsteveogrande added a reviewer for D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types: arphaman.
Jan 2 2018, 1:50 PM
elsteveogrande updated the diff for D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.

Fixed local var names. Using arc diff which hopefully submits latest changes w/ full context

Jan 2 2018, 1:50 PM
elsteveogrande added a comment to D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.

Hi @arphaman, thanks very much! Sorry, I didn't notice there was activity on this old patch until now.

Jan 2 2018, 12:44 PM

Oct 6 2017

elsteveogrande added a comment to D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.

Hi @bruno, @rsmith, does this approach look ok?

Oct 6 2017, 9:35 AM

Sep 28 2017

elsteveogrande added a reviewer for D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types: bruno.
Sep 28 2017, 12:05 PM

Sep 27 2017

elsteveogrande added a comment to D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.

I submitted this patch relative to the clang project root, hopefully that's ok.

Sep 27 2017, 8:50 AM
elsteveogrande updated the summary of D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.
Sep 27 2017, 8:48 AM
elsteveogrande created D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.
Sep 27 2017, 8:47 AM

Jul 9 2017

elsteveogrande abandoned D35033: AVR: avr target support in `CMakeLists.txt`.

ah! Thanks @dylanmckay, didn't see that option in docs :)

Jul 9 2017, 6:13 AM

Jul 5 2017

elsteveogrande added a reviewer for D35033: AVR: avr target support in `CMakeLists.txt`: dylanmckay.
Jul 5 2017, 2:11 PM
elsteveogrande updated the summary of D35033: AVR: avr target support in `CMakeLists.txt`.
Jul 5 2017, 2:08 PM
elsteveogrande created D35033: AVR: avr target support in `CMakeLists.txt`.
Jul 5 2017, 2:04 PM

Mar 2 2017

elsteveogrande abandoned D30548: clang: TemplateBase: correct assignment of `Type`, using qualified name.
Mar 2 2017, 1:30 PM
elsteveogrande planned changes to D30548: clang: TemplateBase: correct assignment of `Type`, using qualified name.

I'm not so sure about what caused my random-garbage values, actually. Looks like TemplateArgument::Type and ArgKind::Type both come out to 1, correctly. The word Type in the original could be a variable inherited somewhere, just a guess. Of course if it were the clang type clang::Type, itself, that would be a parse error.

Mar 2 2017, 1:30 PM
elsteveogrande added inline comments to D30548: clang: TemplateBase: correct assignment of `Type`, using qualified name.
Mar 2 2017, 12:46 PM
elsteveogrande added reviewers for D30548: clang: TemplateBase: correct assignment of `Type`, using qualified name: klimek, rsmith.
Mar 2 2017, 12:45 PM
elsteveogrande updated the summary of D30548: clang: TemplateBase: correct assignment of `Type`, using qualified name.
Mar 2 2017, 12:43 PM
elsteveogrande created D30548: clang: TemplateBase: correct assignment of `Type`, using qualified name.
Mar 2 2017, 12:37 PM

Nov 15 2016

elsteveogrande added a comment to D26089: preprocessor supports `-dI` flag [Fixed].

Ping, this is done (and fixed, tests worked ok)

Nov 15 2016, 7:06 AM

Nov 13 2016

elsteveogrande added a comment to D26089: preprocessor supports `-dI` flag [Fixed].

Ping. Also note, looks good on windows; local run of check-clang went ok.

Nov 13 2016, 8:26 PM

Oct 28 2016

elsteveogrande set the repository for D26089: preprocessor supports `-dI` flag [Fixed] to rL LLVM.
Oct 28 2016, 11:10 AM
elsteveogrande added a reviewer for D26089: preprocessor supports `-dI` flag [Fixed]: rsmith.
Oct 28 2016, 11:10 AM
elsteveogrande added a comment to D26089: preprocessor supports `-dI` flag [Fixed].

This is a duplicate of the other failing diff D25153 but with the mentioned correction.

Oct 28 2016, 11:07 AM
elsteveogrande retitled D26089: preprocessor supports `-dI` flag [Fixed] from to preprocessor supports `-dI` flag [Fixed].
Oct 28 2016, 10:54 AM
elsteveogrande added inline comments to D25153: preprocessor supports `-dI` flag.
Oct 28 2016, 10:50 AM
elsteveogrande added a comment to D25153: preprocessor supports `-dI` flag.

Ping, can anyone help with committing this? It's accepted, just needs to be landed. (I don't have commit access.) Thanks!

Oct 28 2016, 6:10 AM

Oct 20 2016

elsteveogrande updated the diff for D25153: preprocessor supports `-dI` flag.

Fixed an error. A newline is sometimes not appended prior to this #include.

Oct 20 2016, 2:04 PM

Oct 19 2016

elsteveogrande added a comment to D25153: preprocessor supports `-dI` flag.

ping - seems I'm unable to commit this myself. Thanks!

Oct 19 2016, 3:47 PM

Oct 17 2016

elsteveogrande added a comment to D25153: preprocessor supports `-dI` flag.

I'll need help landing this... I also tried git svn dcommit but command hung there forever.

Oct 17 2016, 6:13 AM

Oct 15 2016

elsteveogrande added a comment to D25153: preprocessor supports `-dI` flag.

Thank you! I tried with`arc land` but got a 403...

Oct 15 2016, 2:31 PM
elsteveogrande added a comment to D25153: preprocessor supports `-dI` flag.

Ping

Oct 15 2016, 1:58 PM