Page MenuHomePhabricator
People eddy-geek

eddy-geek (Edward O)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 1 2019, 1:29 PM (231 w, 2 d)

Recent Activity
View All

Jun 1 2021

eddy-geek updated subscribers of D103188: [clang-tidy] modernize-loop-convert: limit use of auto.
@Eugene.Zelenko wrote:

Frankly, I don't think that length-based criteria is reasonable one. Readability of code is much more important than line/file length.

Jun 1 2021, 10:16 AM · Restricted Project
eddy-geek updated subscribers of D103188: [clang-tidy] modernize-loop-convert: limit use of auto.
Jun 1 2021, 12:45 AM · Restricted Project

May 27 2021

eddy-geek updated subscribers of D103188: [clang-tidy] modernize-loop-convert: limit use of auto.

Builds ok, ready for review. I can't edit reviewers now, can someone help? @sammccall / @njames93 / @Eugene.Zelenko / @Mordante ?

May 27 2021, 8:12 AM · Restricted Project

May 26 2021

eddy-geek updated the diff for D103188: [clang-tidy] modernize-loop-convert: limit use of auto.

*Trigger rebuild (windows failed to git clone)*

May 26 2021, 1:51 PM · Restricted Project
eddy-geek updated the diff for D103188: [clang-tidy] modernize-loop-convert: limit use of auto.

*Trigger rebuild (windows failed to git clone)*

May 26 2021, 1:48 PM · Restricted Project
eddy-geek updated the diff for D103188: [clang-tidy] modernize-loop-convert: limit use of auto.

*Trigger rebuild (windows failed to git clone)*

May 26 2021, 11:55 AM · Restricted Project
eddy-geek updated the diff for D103188: [clang-tidy] modernize-loop-convert: limit use of auto.

Fix test output

May 26 2021, 11:37 AM · Restricted Project
eddy-geek updated the diff for D103188: [clang-tidy] modernize-loop-convert: limit use of auto.

Fix test build

May 26 2021, 11:21 AM · Restricted Project
eddy-geek added a comment to D103188: [clang-tidy] modernize-loop-convert: limit use of auto.

I haven't been able to build locally so far -- OOM on my machine, not sure if I can do something lighter than:

cmake -G Ninja -DLLVM_ENABLE_PROJECTS=clang\;clang-tools-extra -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$PWD -DCMAKE_EXPORT_COMPILE_COMMANDS=ON ../llvm
ninja check-clang-tools
May 26 2021, 10:40 AM · Restricted Project
eddy-geek requested review of D103188: [clang-tidy] modernize-loop-convert: limit use of auto.
May 26 2021, 10:35 AM · Restricted Project