Page MenuHomePhabricator

dwightguth (Dwight Guth)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 20 2019, 11:40 AM (7 w, 3 d)

Recent Activity

Oct 7 2019

dwightguth added a comment to D67855: [X86] Add new calling convention that guarantees tail call optimization.

It's ready on my end. I don't have commit access, so...

Oct 7 2019, 1:48 PM · Restricted Project
dwightguth added a comment to D67855: [X86] Add new calling convention that guarantees tail call optimization.

@rnk @paquette what does this need to move forward? I think I addressed all your comments.

Oct 7 2019, 6:27 AM · Restricted Project

Sep 25 2019

dwightguth updated the diff for D67855: [X86] Add new calling convention that guarantees tail call optimization.

Updated documentation text in LangRef.rst

Sep 25 2019, 9:22 AM · Restricted Project

Sep 24 2019

dwightguth updated the diff for D67855: [X86] Add new calling convention that guarantees tail call optimization.

add test for disable-tail-calls

Sep 24 2019, 10:32 AM · Restricted Project
dwightguth added a comment to D67855: [X86] Add new calling convention that guarantees tail call optimization.

I added tests for musttail and mixed calling conventions. But I'm a little unsure what the correct behavior should be here for disable-tail-calls. When you do a musttail call, disable-tail-calls is ignored. When you do a fastcc call with -tailcallopt, disable-tail-calls is not ignored. This seems a little inconsistent to me, but is beyond the scope of this revision. Which of these two behaviors should be implemented by tailcc, though? Currently it does the same thing as fastcc with -tailcallopt. I can add a test for that behavior, but if we want the other behavior, I need to know before I write that test because it affects the test's output.

Sep 24 2019, 9:25 AM · Restricted Project
dwightguth updated the diff for D67855: [X86] Add new calling convention that guarantees tail call optimization.

add tests for mixed calling convention and musttail

Sep 24 2019, 9:20 AM · Restricted Project
dwightguth added inline comments to D67855: [X86] Add new calling convention that guarantees tail call optimization.
Sep 24 2019, 8:51 AM · Restricted Project

Sep 23 2019

dwightguth updated the diff for D67855: [X86] Add new calling convention that guarantees tail call optimization.
  • use FileCheck for test
  • refactor out named boolean variable
  • add more tests
Sep 23 2019, 11:43 AM · Restricted Project

Sep 20 2019

dwightguth created D67855: [X86] Add new calling convention that guarantees tail call optimization.
Sep 20 2019, 1:08 PM · Restricted Project