Page MenuHomePhabricator

dwiberg (David Wiberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2013, 6:00 AM (378 w, 3 d)

Recent Activity

Aug 20 2017

dwiberg added a comment to D35396: [lit] Remove %T.
In D35396#840758, @rnk wrote:

@rnk will probably know. What is the story with mkdir -p %t on Windows?

It works because LLVM requires Unix core utilities to be available. We have some advice on where to get them tucked away here: https://llvm.org/docs/GettingStartedVS.html#software It should probably be more prominent.

Aug 20 2017, 10:49 PM

Aug 17 2015

dwiberg added a comment to D11876: [Support] Always wait for GraphViz before opening the viewer.

This looks good to me. I do however not have commit rights which means I can't give an official approval. I did encounter the issue this patch fixes when testing the changes in D11877.

Aug 17 2015, 12:52 PM

Aug 9 2015

dwiberg added a comment to D11877: [Support] On Windows, generate PDF files for graphs and open with associated viewer.

I agree that my PDF viewer is better than my PS viewer so I like direction of the patch. Many variable- and type names however still refers to PostScript which I think should be fixed.

Aug 9 2015, 7:40 AM