Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People dwang

dwang (Duo Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 16 2023, 1:09 PM (19 w, 2 d)

Recent Activity
View All

Jun 12 2023

dwang updated the diff for D151511: [CMake] Enable building with UBSAN + clang-cl on windows.

rebase against main

Jun 12 2023, 4:09 PM · Restricted Project, Restricted Project
dwang updated the diff for D151511: [CMake] Enable building with UBSAN + clang-cl on windows.
  • format code
Jun 12 2023, 11:33 AM · Restricted Project, Restricted Project
dwang added a comment to D151511: [CMake] Enable building with UBSAN + clang-cl on windows.

@pgousseau Thanks for the review!
Can you maybe commit this patch for me? I do not have push permission.

Jun 12 2023, 11:14 AM · Restricted Project, Restricted Project

Jun 9 2023

dwang added a comment to D151511: [CMake] Enable building with UBSAN + clang-cl on windows.

For the UBSAN crashes, I found an alternative workaround here: https://github.com/llvm/llvm-project/issues/31914. Since the errors only reproduce on windows, this seems like a cleaner fix.
I have pushed an update to outline the necessary changes.

Jun 9 2023, 12:49 PM · Restricted Project, Restricted Project
dwang updated the diff for D151511: [CMake] Enable building with UBSAN + clang-cl on windows.

Workaround UBSAN false-positive on 0-sized objects with __declspec(empty_bases)

Jun 9 2023, 12:43 PM · Restricted Project, Restricted Project
dwang added a comment to D152412: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses.

@vitalybuka Thanks for the quick review!

Jun 9 2023, 10:48 AM · Restricted Project, Restricted Project

Jun 8 2023

dwang added inline comments to D151511: [CMake] Enable building with UBSAN + clang-cl on windows.
Jun 8 2023, 10:17 AM · Restricted Project, Restricted Project
dwang added reviewers for D152412: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses: rjmccall, eli.friedman, asl.
Jun 8 2023, 9:51 AM · Restricted Project, Restricted Project

Jun 7 2023

dwang updated the summary of D152412: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses.
Jun 7 2023, 5:20 PM · Restricted Project, Restricted Project
dwang requested review of D152412: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses.
Jun 7 2023, 5:13 PM · Restricted Project, Restricted Project

Jun 6 2023

dwang added a comment to D151511: [CMake] Enable building with UBSAN + clang-cl on windows.

For the ubsan ignore list, the newly added files reported ubsan crashes similiar to the one reported in: https://github.com/llvm/llvm-project/issues/61775

Jun 6 2023, 5:04 PM · Restricted Project, Restricted Project
dwang added a reviewer for D151511: [CMake] Enable building with UBSAN + clang-cl on windows: ychen.
Jun 6 2023, 4:53 PM · Restricted Project, Restricted Project
dwang updated the diff for D151511: [CMake] Enable building with UBSAN + clang-cl on windows.

rebase

Jun 6 2023, 4:52 PM · Restricted Project, Restricted Project
dwang updated the diff for D151511: [CMake] Enable building with UBSAN + clang-cl on windows.

fix error message & newline at end of file

Jun 6 2023, 4:31 PM · Restricted Project, Restricted Project

May 26 2023

dwang updated the summary of D151511: [CMake] Enable building with UBSAN + clang-cl on windows.
May 26 2023, 10:39 AM · Restricted Project, Restricted Project
dwang retitled D151511: [CMake] Enable building with UBSAN + clang-cl on windows from [CMake] Enable building with UBSAN + clang on windows to [CMake] Enable building with UBSAN + clang-cl on windows.
May 26 2023, 10:35 AM · Restricted Project, Restricted Project
dwang retitled D151511: [CMake] Enable building with UBSAN + clang-cl on windows from [CMake] Enable building with UBSAN on windows to [CMake] Enable building with UBSAN + clang on windows.
May 26 2023, 10:33 AM · Restricted Project, Restricted Project
dwang retitled D151511: [CMake] Enable building with UBSAN + clang-cl on windows from [CMake] Enable building with UBSAN + enable_ubsan_clang_cl on windows to [CMake] Enable building with UBSAN on windows.
May 26 2023, 10:30 AM · Restricted Project, Restricted Project
dwang retitled D151511: [CMake] Enable building with UBSAN + clang-cl on windows from Enable building with UBSAN + enable_ubsan_clang_cl on windows to [CMake] Enable building with UBSAN + enable_ubsan_clang_cl on windows.
May 26 2023, 10:25 AM · Restricted Project, Restricted Project
dwang updated the diff for D151511: [CMake] Enable building with UBSAN + clang-cl on windows.
  • Update ubsan_ignorelist to exempt false-positives for 0-sized objects. Build crashes if those files are not exempted.
  • Refine HandleLLVMOptions.cmake
May 26 2023, 10:14 AM · Restricted Project, Restricted Project

May 25 2023

dwang requested review of D151511: [CMake] Enable building with UBSAN + clang-cl on windows.
May 25 2023, 3:40 PM · Restricted Project, Restricted Project