- User Since
- Jul 28 2016, 11:55 AM (168 w, 5 d)
Jul 23 2018
This is not needed after https://reviews.llvm.org/D42762 was committed. The approach there of using a VSIX package is better than the script-based approach here.
Jul 3 2018
It's great to see your work on Visual Studio extension integration via VSIX. I'm happy to try out your change. I have a few questions:
Nov 17 2016
The parameter array needed to be initialized so that assignments involving unique pointers work properly. The memory could be uninitialized according to C++ semantics.. Visual C++ was zeroing the memory and GCC was not. This is why the tests passed on Windows and failed on Linux. I updated Sema/DeclSpec.cpp to zero the parameter array before it is used.
Nov 14 2016
I sync'ed to the head of the tree. I tried to reproduce the failures that you saw and couldn't. I'm building on Windows 10 x64 using Visual Studio. What platform/OS did you build on? I built and test both Debug and RelWithDebugInfo.
Nov 9 2016
Thanks for the code review feedback - I've addressed it. Yes, we should use reset() instead of release(). I also deleted the unnecessary braces. I don't have commit access, so if this looks good, could someone commit this on my behalf?