Page MenuHomePhabricator

dtarditi (David Tarditi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 28 2016, 11:55 AM (168 w, 5 d)

Recent Activity

Jul 23 2018

dtarditi abandoned D48886: VS 2017 clang integration.

This is not needed after https://reviews.llvm.org/D42762 was committed. The approach there of using a VSIX package is better than the script-based approach here.

Jul 23 2018, 5:38 PM

Jul 3 2018

dtarditi updated subscribers of D48886: VS 2017 clang integration.

It's great to see your work on Visual Studio extension integration via VSIX. I'm happy to try out your change. I have a few questions:

Jul 3 2018, 1:28 PM
dtarditi updated subscribers of D48886: VS 2017 clang integration.
Jul 3 2018, 11:37 AM
dtarditi changed the repository for D48886: VS 2017 clang integration from rC Clang to rL LLVM.
Jul 3 2018, 11:20 AM
dtarditi updated subscribers of D48886: VS 2017 clang integration.
Jul 3 2018, 10:42 AM
dtarditi created D48886: VS 2017 clang integration.
Jul 3 2018, 10:37 AM

Nov 17 2016

dtarditi updated the diff for D26435: Use unique_ptr for cached tokens for default arguments in C++..

The parameter array needed to be initialized so that assignments involving unique pointers work properly. The memory could be uninitialized according to C++ semantics.. Visual C++ was zeroing the memory and GCC was not. This is why the tests passed on Windows and failed on Linux. I updated Sema/DeclSpec.cpp to zero the parameter array before it is used.

Nov 17 2016, 9:35 AM

Nov 14 2016

dtarditi added a comment to D26435: Use unique_ptr for cached tokens for default arguments in C++..

I sync'ed to the head of the tree. I tried to reproduce the failures that you saw and couldn't. I'm building on Windows 10 x64 using Visual Studio. What platform/OS did you build on? I built and test both Debug and RelWithDebugInfo.

Nov 14 2016, 5:25 PM

Nov 9 2016

dtarditi updated the diff for D26435: Use unique_ptr for cached tokens for default arguments in C++..

Thanks for the code review feedback - I've addressed it. Yes, we should use reset() instead of release(). I also deleted the unnecessary braces. I don't have commit access, so if this looks good, could someone commit this on my behalf?

Nov 9 2016, 10:20 AM

Nov 8 2016

dtarditi retitled D26435: Use unique_ptr for cached tokens for default arguments in C++. from to Use unique_ptr for cached tokens for default arguments in C++..
Nov 8 2016, 5:19 PM

Jul 28 2016

dtarditi retitled D22930: [Parser] only correct delayed typos for conditional expressions when needed. from to [Parser] only correct delayed typos for conditional expressions when needed..
Jul 28 2016, 12:53 PM