Page MenuHomePhabricator

dsprenkels (Daan Sprenkels)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2019, 11:05 AM (52 w, 3 d)

Recent Activity

Fri, Apr 3

dsprenkels added a comment to D77299: [InstCombine] convert bitcast-shuffle to vector trunc.

(But still deferring approval to somebody with more experience.)

Fri, Apr 3, 6:57 AM · Restricted Project

Thu, Apr 2

dsprenkels added a comment to D77299: [InstCombine] convert bitcast-shuffle to vector trunc.

In the spirit of https://llvm.org/docs/CodeReview.html#non-experts-should-review-code, I am reviewing the code. But I defer the approval of this patch to somebody else who has more experience than me. (I found only a single nit.)

Thu, Apr 2, 10:17 AM · Restricted Project

Tue, Mar 31

dsprenkels committed rG464b9aeafe29: [InstCombine] Transform extelt-trunc -> bitcast-extelt (authored by dsprenkels).
[InstCombine] Transform extelt-trunc -> bitcast-extelt
Tue, Mar 31, 3:20 AM
dsprenkels closed D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.
Tue, Mar 31, 3:19 AM · Restricted Project

Mon, Mar 30

dsprenkels added a comment to D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.
  • Updated ExtractCast.ll test.
Mon, Mar 30, 4:24 PM · Restricted Project
dsprenkels updated the diff for D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.
Mon, Mar 30, 3:52 PM · Restricted Project
dsprenkels committed rG5227fa0c72ce: Recommit "[InstCombine] Update assertions in InstCombine test; NFC" (authored by dsprenkels).
Recommit "[InstCombine] Update assertions in InstCombine test; NFC"
Mon, Mar 30, 3:18 PM
dsprenkels committed rG273b0d776605: Revert "[InstCombine] Update assertions in InstCombine test; NFC" (authored by dsprenkels).
Revert "[InstCombine] Update assertions in InstCombine test; NFC"
Mon, Mar 30, 2:12 PM
dsprenkels added a reverting change for rG4243bd494d67: [InstCombine] Update assertions in InstCombine test; NFC: rG273b0d776605: Revert "[InstCombine] Update assertions in InstCombine test; NFC".
Mon, Mar 30, 2:12 PM
dsprenkels committed rG4243bd494d67: [InstCombine] Update assertions in InstCombine test; NFC (authored by dsprenkels).
[InstCombine] Update assertions in InstCombine test; NFC
Mon, Mar 30, 1:38 PM
dsprenkels added a comment to D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.

Let me look at the failed test in a couple of hours.

Mon, Mar 30, 10:49 AM · Restricted Project
dsprenkels updated the diff for D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.
  • Updated the test.
  • Changed uint32_ts to uint64_t and added an assert to catch overflows.
Mon, Mar 30, 9:43 AM · Restricted Project
dsprenkels updated the diff for D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.

Update the new trunc-extractelement.ll test file.

Mon, Mar 30, 12:30 AM · Restricted Project

Sun, Mar 29

dsprenkels updated the diff for D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.

The new preliminary tests have been submitted in https://reviews.llvm.org/D77024. I removed the test for now and will submit another update when the other diff has been committed.

Sun, Mar 29, 1:23 PM · Restricted Project
dsprenkels added a comment to D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.

My git lingo might be off here. Are you saying you don't have commit permissions for LLVM yet?

Sun, Mar 29, 1:23 PM · Restricted Project
dsprenkels created D77024: [NFC][InstCombine] Add preliminary tests for D76983.
Sun, Mar 29, 1:23 PM · Restricted Project
dsprenkels added a comment to D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.

@spatel Thanks for the review. I will soon look into it!

Sun, Mar 29, 7:59 AM · Restricted Project

Sat, Mar 28

dsprenkels added a comment to D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.

I didn't look at the logic closely, but seems to be on the right track from the tests (feel free to include Alive2 links in the review if you tested any/all of these).
I see at least 2 variations where we need more code logic (and more tests):

Sat, Mar 28, 10:12 AM · Restricted Project
dsprenkels updated the diff for D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.

Do not canonicalize if the extractvector operand has other users.
Do not canonicalize if it would result in an invalid bitcast instruction.

Sat, Mar 28, 9:40 AM · Restricted Project
dsprenkels added a comment to D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.

It was a bit unclear to me how involved the tests should be for this patch. At this time, I kept them pretty minimal, but I could add more if that's desired.

Sat, Mar 28, 5:23 AM · Restricted Project
dsprenkels created D76983: [InstCombine] Transform extractelement-trunc -> bitcast-extractelement.
Sat, Mar 28, 5:23 AM · Restricted Project

Dec 17 2019

dsprenkels added a comment to D60365: [AVR] Fix codegen for rotate instructions.

Awesome. Thanks for reviewing!

Dec 17 2019, 12:28 AM · Restricted Project

Nov 5 2019

dsprenkels added a comment to D69501: [CommandLine] Add inline ArgName printing.

I don't have commit right. This is one of my first patches. Can you do it for me please?

Nov 5 2019, 12:15 AM · Restricted Project

Oct 29 2019

dsprenkels updated the diff for D69501: [CommandLine] Add inline ArgName printing.

Fixed formatting using clang-format.

Oct 29 2019, 8:21 AM · Restricted Project
dsprenkels added a comment to D69501: [CommandLine] Add inline ArgName printing.

@jhenderson, you were right. I forgot how to upload patches correctly, and that is how the context got lost. The new diff (226891) should be exported correctly. Thanks for the heads-up.

Oct 29 2019, 6:52 AM · Restricted Project
dsprenkels updated the diff for D69501: [CommandLine] Add inline ArgName printing.

Updated the diff to one generated in the correct way.

Oct 29 2019, 6:43 AM · Restricted Project
dsprenkels updated the diff for D69501: [CommandLine] Add inline ArgName printing.

Updated the diff incorporating the new comments.

Oct 29 2019, 6:43 AM · Restricted Project
dsprenkels updated the diff for D69501: [CommandLine] Add inline ArgName printing.

Updated the diff, incorporating @hintonda's suggestions.

Oct 29 2019, 5:38 AM · Restricted Project

Oct 28 2019

dsprenkels added a comment to D69501: [CommandLine] Add inline ArgName printing.

@jhenderson, I added the test.

Oct 28 2019, 9:47 AM · Restricted Project
dsprenkels added a reviewer for D69501: [CommandLine] Add inline ArgName printing: hintonda.
Oct 28 2019, 9:45 AM · Restricted Project
dsprenkels updated the diff for D69501: [CommandLine] Add inline ArgName printing.

Added OptionErrorMessage test case in CommandLineTest for PR42943.

Oct 28 2019, 9:28 AM · Restricted Project
dsprenkels updated the summary of D69501: [CommandLine] Add inline ArgName printing.
Oct 28 2019, 2:45 AM · Restricted Project
dsprenkels created D69501: [CommandLine] Add inline ArgName printing.
Oct 28 2019, 2:44 AM · Restricted Project

Jun 8 2019

Herald added a project to D37052: Add default address space for functions to the data layout (1/3): Restricted Project.
Jun 8 2019, 1:56 AM · Restricted Project

Jun 2 2019

dsprenkels added inline comments to D60365: [AVR] Fix codegen for rotate instructions.
Jun 2 2019, 3:39 AM · Restricted Project
dsprenkels updated the diff for D60365: [AVR] Fix codegen for rotate instructions.

Removed the pattern for RORRd.

Jun 2 2019, 3:33 AM · Restricted Project

Jun 1 2019

dsprenkels added inline comments to D60365: [AVR] Fix codegen for rotate instructions.
Jun 1 2019, 5:59 AM · Restricted Project

May 19 2019

dsprenkels updated the diff for D60365: [AVR] Fix codegen for rotate instructions.
  • Use the temporary registers r1 and r0, instead of scavenging spare registers.
    • And update the test case.
  • Add the definition const unsigned ZERO_REGISTER = AVR::R1 for future use.
May 19 2019, 3:05 AM · Restricted Project

May 16 2019

dsprenkels added a comment to D60365: [AVR] Fix codegen for rotate instructions.

Thank you for the feedback. I will try to update the patch code this weekend.

May 16 2019, 2:24 AM · Restricted Project

Apr 13 2019

dsprenkels added a reviewer for D60365: [AVR] Fix codegen for rotate instructions: shepmaster.
Apr 13 2019, 2:43 PM · Restricted Project

Apr 6 2019

dsprenkels created D60365: [AVR] Fix codegen for rotate instructions.
Apr 6 2019, 11:20 AM · Restricted Project
dsprenkels updated the summary of D60365: [AVR] Fix codegen for rotate instructions.
Apr 6 2019, 11:20 AM · Restricted Project