Page MenuHomePhabricator

drti (Raoul Gough)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 11 2021, 7:12 AM (14 w, 18 h)

Recent Activity

Yesterday

drti added inline comments to D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.
Thu, Jun 17, 2:05 PM · Unknown Object (Project)

Mon, May 24

drti added a comment to D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.

Ping

Mon, May 24, 2:56 AM · Unknown Object (Project)

May 13 2021

drti added a comment to D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.

@ychen I've rebased and fixed some pre-merge build and formatting issues. Could you please have another look at this review? If it looks OK could I also ask you to commit it for me, please? It's my first submission and I don't have commit rights myself.
Regards,
Raoul

May 13 2021, 12:22 PM · Unknown Object (Project)
drti updated the diff for D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.

[CodeGen] Add extension points for TargetPassConfig::addMachinePasses

May 13 2021, 2:39 AM · Unknown Object (Project)
drti updated the diff for D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.

[CodeGen] Add extension points for TargetPassConfig::addMachinePasses

May 13 2021, 2:04 AM · Unknown Object (Project)

May 10 2021

drti updated the diff for D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.
[CodeGen] Add extension points for TargetPassConfig::addMachinePasses
May 10 2021, 7:27 AM · Unknown Object (Project)

Apr 19 2021

drti added a comment to D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.

@ychen apologies for that, the base revision should now be efc013ec4d950a68e6f80dd98cda35e1a96a6fc8 from the main repo.

Apr 19 2021, 2:19 AM · Unknown Object (Project)
drti updated the diff for D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.

[CodeGen] Add extension points for TargetPassConfig::addMachinePasses

Apr 19 2021, 2:13 AM · Unknown Object (Project)

Apr 15 2021

drti added a comment to D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.

@ychen I've updated this review with your suggested changes. I've removed the extension filtering in TargetPassConfig, simplified the test and added an example. The example doesn't try to use the new pass manager because the last time I checked it still wasn't useful for machine passes. What do you think?

Apr 15 2021, 1:20 PM · Unknown Object (Project)
drti updated the diff for D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.

[CodeGen] Simplify unit test for TargetPassConfig::addExtension and
add example plugin module

Apr 15 2021, 1:16 PM · Unknown Object (Project)

Mar 25 2021

drti added a comment to D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.

Could you add an example like llvm/examples/Bye and a test using llc -load?

Mar 25 2021, 2:07 PM · Unknown Object (Project)

Mar 16 2021

drti added a comment to D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.

Thanks very much @ychen for looking at my review, and thanks for pointing me at the examples/Bye/Bye.cpp example code. I didn't know we could do that kind of thing in the build and I'll post an update with a new example later this week.

Mar 16 2021, 1:19 PM · Unknown Object (Project)

Mar 13 2021

drti added a comment to D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.

Hi this is my first submission to the LLVM project. I selected reviewers by looking at the recent commit history of TargetPassConfig.h so I hope I haven't gone too far wrong with that. Evan Cheng is listed in the CODE_OWNERS.txt for "parts of code generator not covered by someone else" but I couldn't find his user name on Phabricator (perhaps he doesn't have one).

Mar 13 2021, 3:29 PM · Unknown Object (Project)
drti requested review of D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses.
Mar 13 2021, 3:25 PM · Unknown Object (Project)