User Details
- User Since
- Mar 11 2021, 7:12 AM (98 w, 4 d)
Thu, Jan 26
Hi @arsenm I'm not really sure what the process is here. I'm happy to change the code just wanted some clarification on your opinion - have commented on the issues you raised.
Dec 24 2022
Dec 10 2022
Dec 5 2022
[CodeGen] Add extension points for TargetPassConfig::addMachinePasses
Nov 28 2022
[CodeGen] Add extension points for TargetPassConfig::addMachinePasses
Nov 22 2022
Hi @arsenm thanks for taking a look at this. I'm in the process of rebasing and re-testing but it will take me a little while to get back up to speed on this. I think it makes sense to put it in the "Plan Changes" stage for now.
Sep 13 2021
@ychen could you please take another look at this review? I'll understand if you don't have time for this - perhaps you could let me know if I should look for another reviewer. It's been quite a while now...
Aug 24 2021
ping
Aug 20 2021
ping
Aug 3 2021
ping
Jul 26 2021
ping
Jul 9 2021
ping
Jun 28 2021
[CodeGen] Add extension points for TargetPassConfig::addMachinePasses
Jun 17 2021
May 24 2021
Ping
May 13 2021
@ychen I've rebased and fixed some pre-merge build and formatting issues. Could you please have another look at this review? If it looks OK could I also ask you to commit it for me, please? It's my first submission and I don't have commit rights myself.
Regards,
Raoul
[CodeGen] Add extension points for TargetPassConfig::addMachinePasses
[CodeGen] Add extension points for TargetPassConfig::addMachinePasses
May 10 2021
[CodeGen] Add extension points for TargetPassConfig::addMachinePasses
Apr 19 2021
@ychen apologies for that, the base revision should now be efc013ec4d950a68e6f80dd98cda35e1a96a6fc8 from the main repo.
[CodeGen] Add extension points for TargetPassConfig::addMachinePasses
Apr 15 2021
@ychen I've updated this review with your suggested changes. I've removed the extension filtering in TargetPassConfig, simplified the test and added an example. The example doesn't try to use the new pass manager because the last time I checked it still wasn't useful for machine passes. What do you think?
[CodeGen] Simplify unit test for TargetPassConfig::addExtension and
add example plugin module
Mar 25 2021
Mar 16 2021
Thanks very much @ychen for looking at my review, and thanks for pointing me at the examples/Bye/Bye.cpp example code. I didn't know we could do that kind of thing in the build and I'll post an update with a new example later this week.
Mar 13 2021
Hi this is my first submission to the LLVM project. I selected reviewers by looking at the recent commit history of TargetPassConfig.h so I hope I haven't gone too far wrong with that. Evan Cheng is listed in the CODE_OWNERS.txt for "parts of code generator not covered by someone else" but I couldn't find his user name on Phabricator (perhaps he doesn't have one).