Page MenuHomePhabricator

dpotop (Dumitru Potop)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2021, 2:17 PM (38 w, 3 d)

Recent Activity

Nov 19 2021

dpotop accepted D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..

This is the first time I am solicited as a reviewer, probably because I raised the issue on discourse (https://llvm.discourse.group/t/bufferization-error-related-to-memref-clone/4665).
The patch implements a solution to the problem we signalled.
The code seems complete, and a test has been provided.
I am not yet competent enough to judge conformance to coding rules. If you think this should have made me resign as a reviewer, please let me know.

Nov 19 2021, 9:40 AM · Restricted Project

May 15 2021

dpotop updated the diff for D102435: Add alignment attribute to memref.global.

Minor formatting based on git-clang-format.

May 15 2021, 1:57 AM · Restricted Project
dpotop updated the diff for D102435: Add alignment attribute to memref.global.

Executing git pull --rebase to correct a testing error.

May 15 2021, 12:11 AM · Restricted Project

May 14 2021

dpotop added inline comments to D102435: Add alignment attribute to memref.global.
May 14 2021, 12:50 AM · Restricted Project
dpotop updated the diff for D102435: Add alignment attribute to memref.global.

Add alignment attribute to memref.global

May 14 2021, 12:10 AM · Restricted Project

May 13 2021

dpotop requested review of D102435: Add alignment attribute to memref.global.
May 13 2021, 12:46 PM · Restricted Project

May 11 2021

dpotop added a comment to D101492: [mlir] Support alignment in LLVM dialect GlobalOp.

Thank you for the help!
Now I'll be moving to the memref dialect to add the attribute to the global
operation, and then complete the lowering to LLVMIR.
Dumitru

May 11 2021, 2:23 PM · Restricted Project
dpotop updated the diff for D101492: [mlir] Support alignment in LLVM dialect GlobalOp.

Support alignment in LLVM dialect GlobalOp

May 11 2021, 10:44 AM · Restricted Project
dpotop updated the diff for D101492: [mlir] Support alignment in LLVM dialect GlobalOp.

Further corrections to support alignment in LLVMIR dialect GlobalOp

May 11 2021, 8:17 AM · Restricted Project

Apr 29 2021

dpotop added a comment to D101492: [mlir] Support alignment in LLVM dialect GlobalOp.

No problem for the other modifications, I'll implement them.
However, I have a problem with the following one.

Apr 29 2021, 11:40 PM · Restricted Project
dpotop added a comment to D101492: [mlir] Support alignment in LLVM dialect GlobalOp.

Lots of "done" comments.

Apr 29 2021, 1:38 PM · Restricted Project
dpotop updated the diff for D101492: [mlir] Support alignment in LLVM dialect GlobalOp.

Further fancy formatting.

Apr 29 2021, 1:37 PM · Restricted Project
dpotop added inline comments to D101492: [mlir] Support alignment in LLVM dialect GlobalOp.
Apr 29 2021, 1:15 PM · Restricted Project
dpotop updated the summary of D101492: [mlir] Support alignment in LLVM dialect GlobalOp.
Apr 29 2021, 1:08 PM · Restricted Project
dpotop updated the diff for D101492: [mlir] Support alignment in LLVM dialect GlobalOp.

Code corrections and improvements in response to comments.

Apr 29 2021, 12:51 PM · Restricted Project
dpotop updated the diff for D101492: [mlir] Support alignment in LLVM dialect GlobalOp.

Correcting formatting issues signalled by clang-tidy.

Apr 29 2021, 10:37 AM · Restricted Project
dpotop updated the diff for D101492: [mlir] Support alignment in LLVM dialect GlobalOp.

Support alignment in LLVM dialect GlobalOp - add dedicated syntax, accessors

Apr 29 2021, 4:36 AM · Restricted Project
dpotop updated the diff for D101492: [mlir] Support alignment in LLVM dialect GlobalOp.

Corrections and additions to D101492: adding alignment to the LLVMIR dialect

Apr 29 2021, 12:07 AM · Restricted Project

Apr 28 2021

dpotop added a comment to D101492: [mlir] Support alignment in LLVM dialect GlobalOp.

Le mer. 28 avr. 2021 à 23:52, Mehdi AMINI via Phabricator <
reviews@reviews.llvm.org> a écrit :

Apr 28 2021, 3:05 PM · Restricted Project
dpotop requested review of D101492: [mlir] Support alignment in LLVM dialect GlobalOp.
Apr 28 2021, 2:40 PM · Restricted Project