Page MenuHomePhabricator

dmitry (Dmitry Borisenkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 22 2016, 9:03 AM (165 w, 3 d)

Recent Activity

Jan 23 2018

dmitry added inline comments to D42027: [Support][NFC] Improve isa implementation.
Jan 23 2018, 10:50 PM
dmitry updated the diff for D42027: [Support][NFC] Improve isa implementation.

Removed dereferenced_type specialization for non-dereferenceable type. Thus we could use detection idiom (e.g. std::experimental:: detected_or) with it in future.

Jan 23 2018, 9:44 AM

Jan 22 2018

dmitry added a comment to D42027: [Support][NFC] Improve isa implementation.

ping

Jan 22 2018, 11:13 AM
dmitry updated the summary of D42027: [Support][NFC] Improve isa implementation.
Jan 22 2018, 11:13 AM

Jan 13 2018

dmitry updated the diff for D42027: [Support][NFC] Improve isa implementation.
Jan 13 2018, 4:29 AM
dmitry added reviewers for D42027: [Support][NFC] Improve isa implementation: chandlerc, mehdi_amini, rsmith, zturner.
Jan 13 2018, 3:58 AM
dmitry updated the summary of D42027: [Support][NFC] Improve isa implementation.
Jan 13 2018, 3:55 AM
dmitry updated the summary of D42027: [Support][NFC] Improve isa implementation.
Jan 13 2018, 3:29 AM
dmitry updated the summary of D42027: [Support][NFC] Improve isa implementation.
Jan 13 2018, 3:29 AM
dmitry created D42027: [Support][NFC] Improve isa implementation.
Jan 13 2018, 3:28 AM
dmitry added a comment to D41699: [OpenCL] Change sampler representation.

@yaxunl there are two benefits of this change.

  1. As pointed by Anastasia. Currently, we have values of addressing mode flags so that they produce valid addressing mode if to combine some of them (see Anastasia's example). And the spec (https://www.khronos.org/registry/OpenCL/sdk/1.0/docs/man/xhtml/sampler_t.html) says addressing mode must be one of CLK_ADDRESS_REPEAT, CLK_ADDRESS_CLAMP_TO_EDGE, CLK_ADDRESS_CLAMP, CLK_ADDRESS_NONE. Though the spec doesn't require it, it's still better to diagnose if a developer specified multiple addressing modes.
  2. In current implementation filtering modes and normalized coordinates might be omitted when initializing samplers. The spec again says that these fields must be one of the predefined enums. Thus having defaults (i.e. constants of 0 values) allow a developer to omit some of the modes and write less portable code which is harder to debug.
Jan 13 2018, 3:09 AM

Jan 3 2018

dmitry created D41699: [OpenCL] Change sampler representation.
Jan 3 2018, 3:15 AM

Nov 29 2017

dmitry added a comment to D40252: Define __IMAGE_SUPPORT__ macro for SPIR.

@yaxunl, I moved IMAGE_SUPPORT macro definition so that now it's guarded by LangOpts.OpenCL
Could you kindly take a second look to the review. Thanks.

Nov 29 2017, 4:52 AM

Nov 27 2017

dmitry updated the diff for D40252: Define __IMAGE_SUPPORT__ macro for SPIR.

Guarded #define IMAGE_SUPPORT 1 with OpenCL

Nov 27 2017, 5:59 AM

Nov 24 2017

dmitry added a comment to D40252: Define __IMAGE_SUPPORT__ macro for SPIR.

Ping. @yaxunl, could you kindly review the patch? It's just a few lines of code.

Nov 24 2017, 1:53 AM

Nov 20 2017

dmitry updated the summary of D40252: Define __IMAGE_SUPPORT__ macro for SPIR.
Nov 20 2017, 7:24 AM
dmitry created D40252: Define __IMAGE_SUPPORT__ macro for SPIR.
Nov 20 2017, 7:18 AM

Apr 26 2017

dmitry added a reviewer for D31764: Fix typos handling in an overloadable call.: george.burgess.iv.
Apr 26 2017, 1:23 AM

Apr 21 2017

dmitry added a comment to D32290: Add reassociation profitability check to TTI.

@mcrosier, I can't. The main motivation is an out-of-tree target, but that it might be beneficial for other targets as well.

Apr 21 2017, 6:26 AM

Apr 20 2017

dmitry created D32290: Add reassociation profitability check to TTI.
Apr 20 2017, 5:59 AM
dmitry added a comment to D31764: Fix typos handling in an overloadable call..

Ping. Richard, do you think you'll be able to take a look at this small change?

Apr 20 2017, 3:28 AM

Apr 6 2017

dmitry updated subscribers of D31764: Fix typos handling in an overloadable call..
Apr 6 2017, 8:49 AM
dmitry retitled D31764: Fix typos handling in an overloadable call. from Fix typos handling is in an overloadable call. to Fix typos handling in an overloadable call..
Apr 6 2017, 8:47 AM
dmitry created D31764: Fix typos handling in an overloadable call..
Apr 6 2017, 8:41 AM

Apr 5 2017

dmitry added a comment to D31458: [OpenCL] Fix semantic check for device_side_enqueue..

@yaxunl, could you kindly review the patch? It's quite short this time.

Apr 5 2017, 8:26 AM

Mar 29 2017

dmitry created D31458: [OpenCL] Fix semantic check for device_side_enqueue..
Mar 29 2017, 6:29 AM

Feb 16 2017

dmitry added inline comments to D30037: [OpenCL] Fix type compatibility check..
Feb 16 2017, 3:09 AM
dmitry created D30037: [OpenCL] Fix type compatibility check..
Feb 16 2017, 3:01 AM

Feb 15 2017

dmitry updated the diff for D28058: [OpenCL] Correct ndrange_t implementation.

Byval attribute was added for ndrange in enqueue kernel call.

Feb 15 2017, 7:07 AM

Jan 13 2017

dmitry added a comment to D28058: [OpenCL] Correct ndrange_t implementation.

@yaxunl, we already have the similar issue for atomics. Probably we can extend typedef semantic checks but I don't think it's a good idea since C and C++ have the similar problem but they don't provide special treatment for types from their standard libraries. I think the proposed approach conforms to general practice and I also think that it's better than to check canonical type and therefore to restrict ndrange_t with a particular non-standard implementation or do you envision something different from the canonical type checking in mind?

Jan 13 2017, 9:15 AM

Jan 11 2017

dmitry added a comment to D28058: [OpenCL] Correct ndrange_t implementation.

Ping!

Jan 11 2017, 6:26 AM

Dec 22 2016

dmitry retitled D28058: [OpenCL] Correct ndrange_t implementation from to [OpenCL] Correct ndrange_t implementation.
Dec 22 2016, 7:58 AM