Page MenuHomePhabricator

dingxiangfei2009 (X)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 23 2023, 6:42 AM (14 w, 10 h)

Recent Activity

Mar 17 2023

dingxiangfei2009 added inline comments to D144682: [MergeFuncs] Compare load instruction metadata.
Mar 17 2023, 11:40 AM · Restricted Project, Restricted Project
dingxiangfei2009 updated the diff for D144682: [MergeFuncs] Compare load instruction metadata.

Fix typo "carries -> carry"

Mar 17 2023, 11:40 AM · Restricted Project, Restricted Project

Mar 7 2023

dingxiangfei2009 added inline comments to D144682: [MergeFuncs] Compare load instruction metadata.
Mar 7 2023, 12:10 PM · Restricted Project, Restricted Project
dingxiangfei2009 updated the diff for D144682: [MergeFuncs] Compare load instruction metadata.

Sorry, wrong patch.

Mar 7 2023, 12:09 PM · Restricted Project, Restricted Project
dingxiangfei2009 updated the diff for D144682: [MergeFuncs] Compare load instruction metadata.

Sorry for the delay. The suggestions have been applied.

Mar 7 2023, 12:05 PM · Restricted Project, Restricted Project

Mar 2 2023

dingxiangfei2009 added inline comments to D144682: [MergeFuncs] Compare load instruction metadata.
Mar 2 2023, 7:02 AM · Restricted Project, Restricted Project

Feb 27 2023

dingxiangfei2009 added a comment to D144682: [MergeFuncs] Compare load instruction metadata.

I am not sure why llvm-reduce is failing on an MIR test. I could not reproduce it locally after rebasing to the latest main.

Feb 27 2023, 3:18 PM · Restricted Project, Restricted Project
dingxiangfei2009 added inline comments to D144682: [MergeFuncs] Compare load instruction metadata.
Feb 27 2023, 1:14 PM · Restricted Project, Restricted Project
dingxiangfei2009 updated the diff for D144682: [MergeFuncs] Compare load instruction metadata.

The extra attributes are removed from the test function arguments.

Feb 27 2023, 1:11 PM · Restricted Project, Restricted Project
dingxiangfei2009 updated the diff for D144682: [MergeFuncs] Compare load instruction metadata.

A dangling comment line is removed from the test case.

Feb 27 2023, 1:09 PM · Restricted Project, Restricted Project
dingxiangfei2009 updated the diff for D144682: [MergeFuncs] Compare load instruction metadata.

As requested, the new test case is properly processed by update_test_checks.py. In addition, the adhoc metadata comparison is replaced with a generic comparator.

Feb 27 2023, 1:07 PM · Restricted Project, Restricted Project
dingxiangfei2009 added inline comments to D144682: [MergeFuncs] Compare load instruction metadata.
Feb 27 2023, 5:33 AM · Restricted Project, Restricted Project

Feb 26 2023

dingxiangfei2009 added a comment to D144682: [MergeFuncs] Compare load instruction metadata.

I am not able to reproduce the build failures from fuzzer test locally using ninja check-fuzzer. I am not sure what I have missed.

Feb 26 2023, 12:18 PM · Restricted Project, Restricted Project
dingxiangfei2009 updated the diff for D144682: [MergeFuncs] Compare load instruction metadata.

Update test: dereferenceable in the function argument is shrinked to just cover the pointer value.

Feb 26 2023, 6:01 AM · Restricted Project, Restricted Project
dingxiangfei2009 updated the diff for D144682: [MergeFuncs] Compare load instruction metadata.

The diff is updated to check other metadata kinds applicable to loads, except !nontemporal which seems to affect choice of machine instruction.

Feb 26 2023, 5:57 AM · Restricted Project, Restricted Project

Feb 24 2023

dingxiangfei2009 added a comment to D144682: [MergeFuncs] Compare load instruction metadata.

Thanks for the review, @nikic ! I am searching for other uses of metadata for optimization.

Feb 24 2023, 2:08 AM · Restricted Project, Restricted Project
dingxiangfei2009 updated the diff for D144682: [MergeFuncs] Compare load instruction metadata.

A regression test is added. The full context is attached as requested.

Feb 24 2023, 2:06 AM · Restricted Project, Restricted Project

Feb 23 2023

dingxiangfei2009 requested review of D144682: [MergeFuncs] Compare load instruction metadata.
Feb 23 2023, 3:34 PM · Restricted Project, Restricted Project