Page MenuHomePhabricator

dfki-jugr (Julian Gross)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 1:31 AM (123 w, 4 d)

Recent Activity

Jan 11 2022

dfki-jugr committed rG4b01968b5eae: [MLIR] Update allocs to memref.allocs in documentation. (authored by dfki-jugr).
[MLIR] Update allocs to memref.allocs in documentation.
Jan 11 2022, 2:24 AM
dfki-jugr closed D116999: [MLIR] Update allocs to memref.allocs in documentation..
Jan 11 2022, 2:24 AM · Restricted Project
dfki-jugr added a reviewer for D116999: [MLIR] Update allocs to memref.allocs in documentation.: mehdi_amini.
Jan 11 2022, 2:15 AM · Restricted Project
dfki-jugr requested review of D116999: [MLIR] Update allocs to memref.allocs in documentation..
Jan 11 2022, 2:13 AM · Restricted Project

Dec 15 2021

dfki-jugr committed rG524d6a2d6ae0: [mlir] Added documentation for bufferization to memref conversion pass. (authored by dfki-jugr).
[mlir] Added documentation for bufferization to memref conversion pass.
Dec 15 2021, 1:22 AM
dfki-jugr closed D115326: [mlir] Added documentation for bufferization to memref conversion pass..
Dec 15 2021, 1:22 AM · Restricted Project

Dec 8 2021

dfki-jugr added inline comments to D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..
Dec 8 2021, 2:45 AM · Restricted Project
dfki-jugr added reviewers for D115326: [mlir] Added documentation for bufferization to memref conversion pass.: mehdi_amini, herhut.
Dec 8 2021, 2:44 AM · Restricted Project
dfki-jugr requested review of D115326: [mlir] Added documentation for bufferization to memref conversion pass..
Dec 8 2021, 2:43 AM · Restricted Project

Dec 1 2021

dfki-jugr added inline comments to D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..
Dec 1 2021, 4:39 AM · Restricted Project

Nov 30 2021

dfki-jugr abandoned D114780: Added missing link references..
Nov 30 2021, 4:16 AM · Restricted Project
dfki-jugr added a comment to D114780: Added missing link references..

I think only Pass and Transforms are needed. I already submitted it. Thanks!

Nov 30 2021, 4:15 AM · Restricted Project
dfki-jugr updated the summary of D114780: Added missing link references..
Nov 30 2021, 1:33 AM · Restricted Project
dfki-jugr requested review of D114780: Added missing link references..
Nov 30 2021, 1:31 AM · Restricted Project
dfki-jugr committed rGae1ea0bead75: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy. (authored by dfki-jugr).
[mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy.
Nov 30 2021, 1:17 AM
dfki-jugr closed D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..
Nov 30 2021, 1:17 AM · Restricted Project

Nov 29 2021

dfki-jugr updated the diff for D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..

Addressed comments.

Nov 29 2021, 2:33 AM · Restricted Project
dfki-jugr retitled D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy. from Decompose MemRef Clone operation into Alloc and Copy. to [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..
Nov 29 2021, 1:01 AM · Restricted Project
dfki-jugr updated the summary of D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..
Nov 29 2021, 1:00 AM · Restricted Project
dfki-jugr updated the diff for D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..

All files are renamed to "bufferization to memref" after the bufferization
dialect has been created.
Addressed further comments.

Nov 29 2021, 12:59 AM · Restricted Project

Nov 23 2021

dfki-jugr added inline comments to D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..
Nov 23 2021, 7:53 AM · Restricted Project
dfki-jugr updated the diff for D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..

Add dynamic shaped allocs and test cases.
Addressed comments.

Nov 23 2021, 7:52 AM · Restricted Project

Nov 22 2021

dfki-jugr added inline comments to D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..
Nov 22 2021, 4:25 AM · Restricted Project

Nov 19 2021

dfki-jugr added reviewers for D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy.: herhut, pifon2a, dpotop.
Nov 19 2021, 4:21 AM · Restricted Project
dfki-jugr requested review of D114233: [mlir] Decompose Bufferization Clone operation into Memref Alloc and Copy..
Nov 19 2021, 4:18 AM · Restricted Project

Sep 29 2021

dfki-jugr committed rG09cd4a71ed1e: Introduced AllocationOpInterface to create deallocation operations on-the-fly… (authored by dfki-mako).
Introduced AllocationOpInterface to create deallocation operations on-the-fly…
Sep 29 2021, 6:55 AM
dfki-jugr closed D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..
Sep 29 2021, 6:55 AM · Restricted Project

May 20 2021

dfki-jugr added inline comments to D102785: [mlir][memref] Fix canonicalization of memref.clone.
May 20 2021, 2:55 AM · Restricted Project

May 17 2021

dfki-jugr committed rG1fbb484ea45f: [WIP][mlir] Resolve memref dependency in canonicalize pass. (authored by dfki-jugr).
[WIP][mlir] Resolve memref dependency in canonicalize pass.
May 17 2021, 2:35 AM
dfki-jugr closed D102060: [WIP][mlir] Resolve memref dependency in canonicalize pass..
May 17 2021, 2:35 AM · Restricted Project

May 10 2021

dfki-jugr committed rGfc253e69f9b9: Fixed bug in buffer deallocation pass using unranked memref types. (authored by dfki-jugr).
Fixed bug in buffer deallocation pass using unranked memref types.
May 10 2021, 1:51 AM
dfki-jugr closed D101760: Fixed bug in buffer deallocation pass using unranked memref types..
May 10 2021, 1:51 AM · Restricted Project

May 7 2021

dfki-jugr added a comment to D98041: [MLIR] Create memref dialect and move dialect-specific ops from std..

@mehdi_amini Try to fix the issue here: https://reviews.llvm.org/D102060

May 7 2021, 3:43 AM · Restricted Project
dfki-jugr added a reviewer for D102060: [WIP][mlir] Resolve memref dependency in canonicalize pass.: mehdi_amini.
May 7 2021, 3:42 AM · Restricted Project
dfki-jugr requested review of D102060: [WIP][mlir] Resolve memref dependency in canonicalize pass..
May 7 2021, 3:41 AM · Restricted Project

May 6 2021

dfki-jugr added a comment to D98041: [MLIR] Create memref dialect and move dialect-specific ops from std..

Any progress on splitting memref.dim into tensor.dim?

May 6 2021, 3:29 AM · Restricted Project
dfki-jugr added a comment to D98041: [MLIR] Create memref dialect and move dialect-specific ops from std..

@mehdi_amini We tried to resolve the dependency, but ran into the problem that the canonicalize test did not recognize the memref ops. Before splitting the dialect, this was not an issue since the ops were part of the std-dialect. Now, we get an error that the splitted memref ops are not registered in MLIR context. That's the reason why this dependency is needed. As mentioned above, we are not experts in this particular field of MLIR and are looking forward to get some support how to get rid of this dependency. Maybe we can pre-register the memref-dialect somehow?

May 6 2021, 2:55 AM · Restricted Project

May 5 2021

dfki-jugr added a comment to D98041: [MLIR] Create memref dialect and move dialect-specific ops from std..

@mehdi_amini We have already discussed this "issue" with @herhut and we detected that the includes can not be removed in a straight forward way. It looks like removing those includes causes memref dependencies that can not be resolved properly. Unfortunately, we are not experts in this particular field of MLIR core. However, we are definitely looking forward to address your concerns. If we are able to get some support regarding these implicitely existing memref dependencies.

May 5 2021, 1:39 AM · Restricted Project

May 4 2021

dfki-jugr updated the diff for D101760: Fixed bug in buffer deallocation pass using unranked memref types..

Addressed comments.

May 4 2021, 2:02 AM · Restricted Project

May 3 2021

dfki-jugr added a reviewer for D101760: Fixed bug in buffer deallocation pass using unranked memref types.: herhut.
May 3 2021, 8:05 AM · Restricted Project
dfki-jugr requested review of D101760: Fixed bug in buffer deallocation pass using unranked memref types..
May 3 2021, 8:05 AM · Restricted Project

Mar 29 2021

dfki-jugr committed rG06b03800f3fc: [mlir] Introduce CloneOp and adapt test cases in BufferDeallocation. (authored by dfki-jugr).
[mlir] Introduce CloneOp and adapt test cases in BufferDeallocation.
Mar 29 2021, 1:20 AM
dfki-jugr closed D99172: [mlir] Introduce CloneOp and adapt test cases in BufferDeallocation..
Mar 29 2021, 1:20 AM · Restricted Project

Mar 26 2021

dfki-jugr added inline comments to D99172: [mlir] Introduce CloneOp and adapt test cases in BufferDeallocation..
Mar 26 2021, 3:50 AM · Restricted Project
dfki-jugr updated the diff for D99172: [mlir] Introduce CloneOp and adapt test cases in BufferDeallocation..

Addressed comments.

Mar 26 2021, 3:50 AM · Restricted Project

Mar 24 2021

dfki-jugr added a comment to D98041: [MLIR] Create memref dialect and move dialect-specific ops from std..

It looks like this patch simply moved std.dim to memref.dim, without doing the "splitting" which we had discussed. I now have code that only operates on tensors that is needing to pull in the memref dialect just for this. Can you split memref.dim into tensor.dim for the tensor case?

Mar 24 2021, 7:17 AM · Restricted Project
dfki-jugr added inline comments to D99172: [mlir] Introduce CloneOp and adapt test cases in BufferDeallocation..
Mar 24 2021, 6:55 AM · Restricted Project
dfki-jugr updated the diff for D99172: [mlir] Introduce CloneOp and adapt test cases in BufferDeallocation..

Addressed comments.

Mar 24 2021, 6:55 AM · Restricted Project

Mar 23 2021

dfki-jugr added reviewers for D99172: [mlir] Introduce CloneOp and adapt test cases in BufferDeallocation.: herhut, silvas, mehdi_amini.
Mar 23 2021, 4:14 AM · Restricted Project
dfki-jugr requested review of D99172: [mlir] Introduce CloneOp and adapt test cases in BufferDeallocation..
Mar 23 2021, 4:13 AM · Restricted Project

Mar 17 2021

dfki-jugr committed rGea51e7d4f878: Added documentation for SSA like property in Bufferization. (authored by dfki-jugr).
Added documentation for SSA like property in Bufferization.
Mar 17 2021, 4:50 AM
dfki-jugr closed D95522: Added documentation for SSA like property in Bufferization..
Mar 17 2021, 4:50 AM · Restricted Project

Mar 15 2021

dfki-jugr committed rGe2310704d890: [MLIR] Create memref dialect and move dialect-specific ops from std. (authored by dfki-jugr).
[MLIR] Create memref dialect and move dialect-specific ops from std.
Mar 15 2021, 3:17 AM
dfki-jugr closed D98041: [MLIR] Create memref dialect and move dialect-specific ops from std..
Mar 15 2021, 3:17 AM · Restricted Project

Mar 11 2021

dfki-jugr updated the diff for D98041: [MLIR] Create memref dialect and move dialect-specific ops from std..

Adressed comments.

Mar 11 2021, 4:07 AM · Restricted Project
dfki-jugr committed rG2aef20298121: [mlir] Fix invalid hoisting of dependent allocs in buffer hoisting pass. (authored by dfki-jugr).
[mlir] Fix invalid hoisting of dependent allocs in buffer hoisting pass.
Mar 11 2021, 2:49 AM
dfki-jugr closed D98248: [mlir] Fix invalid hoisting of dependent allocs in buffer hoisting pass..
Mar 11 2021, 2:48 AM · Restricted Project

Mar 9 2021

dfki-jugr added a reviewer for D98248: [mlir] Fix invalid hoisting of dependent allocs in buffer hoisting pass.: herhut.
Mar 9 2021, 4:00 AM · Restricted Project
dfki-jugr requested review of D98248: [mlir] Fix invalid hoisting of dependent allocs in buffer hoisting pass..
Mar 9 2021, 4:00 AM · Restricted Project

Mar 5 2021

dfki-jugr requested review of D98041: [MLIR] Create memref dialect and move dialect-specific ops from std..
Mar 5 2021, 6:17 AM · Restricted Project

Feb 18 2021

dfki-jugr committed rG8aa6c3765b92: [MLIR] Create memref dialect and move several dialect-specific ops from std. (authored by dfki-jugr).
[MLIR] Create memref dialect and move several dialect-specific ops from std.
Feb 18 2021, 2:32 AM
dfki-jugr closed D96425: [MLIR] Create memref dialect and move several dialect-specific ops from std..
Feb 18 2021, 2:32 AM · Restricted Project

Feb 12 2021

dfki-jugr updated the diff for D96425: [MLIR] Create memref dialect and move several dialect-specific ops from std..

Removed corresponding ops in std dialect and adapted test cases.
Addressed comments.

Feb 12 2021, 12:32 AM · Restricted Project

Feb 11 2021

dfki-jugr added inline comments to D96425: [MLIR] Create memref dialect and move several dialect-specific ops from std..
Feb 11 2021, 1:06 AM · Restricted Project

Feb 10 2021

dfki-jugr added reviewers for D96425: [MLIR] Create memref dialect and move several dialect-specific ops from std.: herhut, silvas.
Feb 10 2021, 8:31 AM · Restricted Project
dfki-jugr requested review of D96425: [MLIR] Create memref dialect and move several dialect-specific ops from std..
Feb 10 2021, 8:28 AM · Restricted Project

Feb 8 2021

dfki-jugr accepted D96217: [MLIR][NFC] Fix std.copysign op documentation.
Feb 8 2021, 1:42 AM · Restricted Project

Jan 27 2021

dfki-jugr added reviewers for D95522: Added documentation for SSA like property in Bufferization.: herhut, silvas, dfki-mako.
Jan 27 2021, 6:30 AM · Restricted Project
dfki-jugr requested review of D95522: Added documentation for SSA like property in Bufferization..
Jan 27 2021, 6:29 AM · Restricted Project

Jan 20 2021

dfki-jugr committed rG43f34f58349a: Added check if there are regions that do not implement the… (authored by dfki-jugr).
Added check if there are regions that do not implement the…
Jan 20 2021, 3:23 AM
dfki-jugr closed D94586: Added check if there are regions that do not implement the RegionBranchOpInterface..
Jan 20 2021, 3:23 AM · Restricted Project

Jan 19 2021

dfki-jugr updated the diff for D94586: Added check if there are regions that do not implement the RegionBranchOpInterface..

Addressed comments.

Jan 19 2021, 4:05 AM · Restricted Project

Jan 18 2021

dfki-jugr added inline comments to D94586: Added check if there are regions that do not implement the RegionBranchOpInterface..
Jan 18 2021, 2:19 AM · Restricted Project

Jan 13 2021

dfki-jugr added reviewers for D94586: Added check if there are regions that do not implement the RegionBranchOpInterface.: herhut, bondhugula.
Jan 13 2021, 2:56 AM · Restricted Project
dfki-jugr requested review of D94586: Added check if there are regions that do not implement the RegionBranchOpInterface..
Jan 13 2021, 2:54 AM · Restricted Project

Jan 11 2021

dfki-jugr accepted D94351: [mlir][docs] Bring bufferization docs up to date..
Jan 11 2021, 1:08 AM · Restricted Project

Dec 3 2020

dfki-jugr committed rG8aeca73702d8: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack… (authored by dfki-jugr).
[MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack…
Dec 3 2020, 2:49 AM
dfki-jugr closed D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..
Dec 3 2020, 2:48 AM · Restricted Project

Dec 1 2020

dfki-jugr updated the diff for D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..

Addressed comments.

Dec 1 2020, 4:31 AM · Restricted Project

Nov 25 2020

dfki-jugr added inline comments to D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..
Nov 25 2020, 7:18 AM · Restricted Project
dfki-jugr updated the diff for D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..

Addressed comments.
Changed default max rank to 1 instead of 2 and changed condition to less or equal.
This way is more intuitive.

Nov 25 2020, 7:17 AM · Restricted Project

Nov 24 2020

dfki-jugr updated the diff for D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..

Addressed comments.
Introduce transformation if the alloc operands are RankOps.

Nov 24 2020, 7:39 AM · Restricted Project

Nov 23 2020

dfki-jugr added reviewers for D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass.: herhut, pifon2a.
Nov 23 2020, 7:43 AM · Restricted Project
dfki-jugr requested review of D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..
Nov 23 2020, 7:42 AM · Restricted Project

Nov 18 2020

dfki-jugr accepted D91563: [mlir] Split BufferUtils.h out of Bufferize.h.
Nov 18 2020, 12:02 AM · Restricted Project

Nov 17 2020

dfki-jugr added inline comments to D91563: [mlir] Split BufferUtils.h out of Bufferize.h.
Nov 17 2020, 1:32 AM · Restricted Project

Nov 13 2020

dfki-jugr abandoned D73713: Fixed non-deterministic GPU intrinsic lowering..
Nov 13 2020, 1:31 AM · Restricted Project, Restricted Project
dfki-jugr added a comment to D90675: [MLIR] Added documentation and manual to use bufferization features..

Hello! It looks like this documentation is a bit outdated. For example, setResultConversionKind method was removed and replaced with separate pass (see https://github.com/llvm/llvm-project/commit/f7bc56826616814a656866fd50e90a35a8e461eb). Is there any plans to update this documentation?

Nov 13 2020, 12:50 AM · Restricted Project
dfki-jugr accepted D91360: [mlir][bufferize] Fix buffer promotion to stack for index types.
Nov 13 2020, 12:29 AM · Restricted Project

Nov 12 2020

dfki-jugr committed rG0313e3bfe6e2: [MLIR] Added documentation and manual to use bufferization features. (authored by dfki-jugr).
[MLIR] Added documentation and manual to use bufferization features.
Nov 12 2020, 1:43 AM
dfki-jugr closed D90675: [MLIR] Added documentation and manual to use bufferization features..
Nov 12 2020, 1:43 AM · Restricted Project

Nov 5 2020

dfki-jugr updated the diff for D90675: [MLIR] Added documentation and manual to use bufferization features..

Addressed comments

Nov 5 2020, 1:20 AM · Restricted Project
dfki-jugr added inline comments to D90675: [MLIR] Added documentation and manual to use bufferization features..
Nov 5 2020, 1:17 AM · Restricted Project

Nov 3 2020

dfki-jugr added reviewers for D90675: [MLIR] Added documentation and manual to use bufferization features.: herhut, pifon2a, dfki-heme, dfki-albo, dfki-mako.
Nov 3 2020, 3:42 AM · Restricted Project
dfki-jugr requested review of D90675: [MLIR] Added documentation and manual to use bufferization features..
Nov 3 2020, 3:41 AM · Restricted Project

Oct 23 2020

dfki-jugr committed rG0d1d363c51c9: [MLIR] Added PromoteBuffersToStackPass to convert heap- to stack-based… (authored by dfki-jugr).
[MLIR] Added PromoteBuffersToStackPass to convert heap- to stack-based…
Oct 23 2020, 3:12 AM
dfki-jugr closed D89688: [MLIR] Added PromoteBuffersToStackPass to convert heap-based allocations to stack-based allocations..
Oct 23 2020, 3:11 AM · Restricted Project

Oct 22 2020

dfki-jugr updated the diff for D89688: [MLIR] Added PromoteBuffersToStackPass to convert heap-based allocations to stack-based allocations..

Addressed comments.

Oct 22 2020, 7:23 AM · Restricted Project

Oct 21 2020

dfki-jugr updated the diff for D89688: [MLIR] Added PromoteBuffersToStackPass to convert heap-based allocations to stack-based allocations..

Addressed comments.

Oct 21 2020, 2:46 AM · Restricted Project

Oct 19 2020

dfki-jugr added inline comments to D89688: [MLIR] Added PromoteBuffersToStackPass to convert heap-based allocations to stack-based allocations..
Oct 19 2020, 8:00 AM · Restricted Project