Page MenuHomePhabricator

derek (Derek Argueta)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 27 2019, 1:22 PM (22 w, 2 d)

Recent Activity

Dec 27 2019

derek added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Hi folks, please correct me if I'm wrong but it appears that an effect of this change is that this script will no longer exit non-zero if clang-tidy discovers any errors, which was the previous functionality with sys.exit(subprocess.call(' '.join(command), shell=True)). As a result, when we upgraded a project to LLVM 9 our CI began having false-positives, as we relied on the exit code of this script to indicate success/failure. Would it be possible to restore that functionality? I'd be happy to provide a patch.

Dec 27 2019, 1:33 PM · Restricted Project, Restricted Project