Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People denizevrenci

denizevrenci (Deniz Evrenci)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2023, 9:55 AM (31 w, 10 h)

Recent Activity
View All

Jun 11 2023

denizevrenci committed rGdaac014fec42: [clang-tidy] Check functions called from catch blocks (authored by denizevrenci).
[clang-tidy] Check functions called from catch blocks
Jun 11 2023, 8:41 AM · Restricted Project, Restricted Project
denizevrenci closed D152330: [clang-tidy] Check functions called from catch blocks.
Jun 11 2023, 8:41 AM · Restricted Project, Restricted Project
denizevrenci updated the diff for D152330: [clang-tidy] Check functions called from catch blocks.

Rebase on main

Jun 11 2023, 7:00 AM · Restricted Project, Restricted Project

Jun 6 2023

denizevrenci updated the diff for D152330: [clang-tidy] Check functions called from catch blocks.

Sort tests out a bit more

Jun 6 2023, 8:00 PM · Restricted Project, Restricted Project
denizevrenci updated the diff for D152330: [clang-tidy] Check functions called from catch blocks.

Sort out tests

Jun 6 2023, 7:56 PM · Restricted Project, Restricted Project
denizevrenci updated the diff for D152330: [clang-tidy] Check functions called from catch blocks.

Rebase on main

Jun 6 2023, 7:42 PM · Restricted Project, Restricted Project
denizevrenci added inline comments to D152330: [clang-tidy] Check functions called from catch blocks.
Jun 6 2023, 7:09 PM · Restricted Project, Restricted Project
denizevrenci requested review of D152330: [clang-tidy] Check functions called from catch blocks.
Jun 6 2023, 6:28 PM · Restricted Project, Restricted Project

May 29 2023

denizevrenci added a comment to D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.

Hi @PiotrZSL if you are happy with the changes, could you commit the diff for me as I don't have commit access to LLVM repo?

May 29 2023, 2:33 PM · Restricted Project, Restricted Project, Restricted Project
denizevrenci updated the diff for D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.
  • Rebase on trunk
  • Remove unused helpers
May 29 2023, 6:42 AM · Restricted Project, Restricted Project, Restricted Project
denizevrenci added a comment to D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.

Addressed 1 and 3. As for the new methods in StmtCXX.h, I think they may be used elsewhere too where we need to make a distinction between the visible body of the coroutine and the desugared version.

May 29 2023, 5:30 AM · Restricted Project, Restricted Project, Restricted Project
denizevrenci updated the diff for D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.
  • Update release notes
  • Remove checks for no messages
May 29 2023, 5:28 AM · Restricted Project, Restricted Project, Restricted Project

May 28 2023

denizevrenci added a comment to D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.

@PiotrZSL & @ChuanqiXu may I request a re-review? I addressed all comments.

May 28 2023, 8:05 PM · Restricted Project, Restricted Project, Restricted Project
denizevrenci updated the diff for D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.

Add tests for co_yield and co_await

May 28 2023, 8:00 PM · Restricted Project, Restricted Project, Restricted Project

May 16 2023

denizevrenci updated the diff for D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.

Fix commit message

May 16 2023, 4:43 PM · Restricted Project, Restricted Project, Restricted Project

May 15 2023

denizevrenci updated the diff for D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.

a_shouldNotDiag -> b_shouldNotDiag

May 15 2023, 4:55 PM · Restricted Project, Restricted Project, Restricted Project
denizevrenci updated the diff for D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.

Address comments. Implement a special case for coroutines in ExceptionAnalyzer

May 15 2023, 4:43 PM · Restricted Project, Restricted Project, Restricted Project

Apr 4 2023

denizevrenci added inline comments to D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.
Apr 4 2023, 1:23 PM · Restricted Project, Restricted Project, Restricted Project

Apr 3 2023

denizevrenci added inline comments to D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.
Apr 3 2023, 6:01 PM · Restricted Project, Restricted Project, Restricted Project

Apr 2 2023

denizevrenci added a comment to D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.

I don't have commit access so after the review is complete, please commit this diff in my place.

Apr 2 2023, 8:10 PM · Restricted Project, Restricted Project, Restricted Project
denizevrenci updated the diff for D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.

Fix the line number for the warning

Apr 2 2023, 8:09 PM · Restricted Project, Restricted Project, Restricted Project
denizevrenci updated the diff for D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.

Remove line breaks in CHECK-MESSAGES lines

Apr 2 2023, 7:19 PM · Restricted Project, Restricted Project, Restricted Project
denizevrenci requested review of D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.
Apr 2 2023, 2:01 PM · Restricted Project, Restricted Project, Restricted Project

Feb 27 2023

denizevrenci added a comment to D144352: Do not emit exception diagnostics from coroutines and coroutine lambdas.

Author info for the commit: Deniz Evrenci (denizevrenci@gmail.com)

Feb 27 2023, 8:18 AM · Restricted Project, Restricted Project

Feb 22 2023

denizevrenci added a comment to D144352: Do not emit exception diagnostics from coroutines and coroutine lambdas.

@NoQ I don't have commit access. Should I leave landing the diff to you?

Feb 22 2023, 6:16 PM · Restricted Project, Restricted Project

Feb 19 2023

denizevrenci updated the diff for D144352: Do not emit exception diagnostics from coroutines and coroutine lambdas.

Added some throws that should be ignored.

Feb 19 2023, 1:51 PM · Restricted Project, Restricted Project
denizevrenci requested review of D144352: Do not emit exception diagnostics from coroutines and coroutine lambdas.
Feb 19 2023, 10:19 AM · Restricted Project, Restricted Project