User Details
- User Since
- Nov 26 2014, 9:56 PM (427 w, 4 d)
Jan 22 2016
I'll think how to rework this.
Jan 19 2016
Concerning formatting - let's wait for another reviewer's opinion then.
Jan 18 2016
Jan 13 2016
Ping
Rebased on top of actual sources.
Dec 17 2015
Updated:
- Remove IndicesVector typedef
- Replace std::copy with insert into vector
- Add more comments to functions
Dec 16 2015
Updated:
- Use std::vector instead of SmallVector
- Add comments to methods
- Rename fillPhdrs -> fillUnusedPhdrs
Dec 14 2015
Ping
Dec 8 2015
Updated:
- move out some functionality to couple of methods
- improve NONE header handling (it now can be specified with other headers and just ignored)
Dec 7 2015
Updated:
- Add method comment
- Simplify custom header layout loop
- Check if no sections assigned to custom headers
- Improve NONE header handling
- Style fixes in the header layout loop
Dec 4 2015
Updated:
- style fixes in linker script's PHDRS parsing
- move custom header processing out to a separate method
Dec 3 2015
Nov 12 2015
Nov 11 2015
Updated:
- Rename parseSectionDescriptions -> buildSectionMap
Nov 9 2015
Updated:
- Remove OutputSectionDescription structure
- Simplify checks in scan relocs loop
Nov 3 2015
Updated:
- Style fixes in linker script
- Remove InputSectionDescription
- Remove hasCustomSections check
- Rename discardInputSection -> isDiscarded
- Make compareSections static
Nov 2 2015
Updated:
- Replace mapBraces method with procedural checks in the linker script parser
- Change peek() -> skip() in the parser
- Remove custom bounding symbols processing for linker script
- Remove checks for regular section ordering for linker script
- Change section comparison lambda with method
- Remove not used fields of input section description struct
Oct 30 2015
I don't think we need that protection. If users try to reorder such
sections, we should do that as instructed, no?
First of all, I reproduced the case when defining 'specific' section in the SECTIONS command affects its ordering in the resulting file without the check, so this check works as I expected.
Oct 29 2015
Update:
- Style fixes
- Use reference in range-for-loop (auto &)
Updated:
- Remove dynamic casting of output section classes
- Remove separate class for linker script support
- Move linker script-related code to Writer and use conditional checks where needed
Oct 28 2015
Oct 7 2015
Will fix style and sort members before commit.
Oct 6 2015
Updated:
- Rename createELFFile -> createELFInputFile
- Rework error handling in createELFInputFile - use early return, split error messages
Oct 5 2015
Updated:
- Remove FirstObjName in favor of always reporting incompatibility with the first object file if available.
Updated:
- Remove isCompatibleWith method
- Rename OPT_emulation -> OPT_m
- Rename applyEmulation -> setELFType
Oct 2 2015
Updated:
- simplify initialization of static synthetic symbol
- add test to check that undefined symbol is not in dynamic table
Oct 1 2015
Updated:
- Remove FirstOjbName Config variable, use Symtab.getFirstELF()->getName() instead
- clang-format sources
Sorry for the previous not full comment, just hit Submit button accidentally.
Sep 30 2015
Updated:
- Rename is64Bits() -> is64()
- Add FirstObjFile config parameter
- Introduce ELFNoneKind
- Replace applyEmulation loop with if-else
- Remove configureTarget function
- Drop getElfMachineType function
Sep 29 2015
Sep 28 2015
Updated:
- Make ElfKind optional
- Move Emulations to the place of use
- Rename createTargetELFFile -> createELFFile
- Code style fixes
- Minimize the number of changes by excluding parts that may be removed
Sep 25 2015
Sep 24 2015
Maybe, but that is independent and pretty big, so it should be in another patch.
@rafael, thanks for the patch, but I'd prefer to leave the getElfMachineType method since it allows to simplify the interface of ELFData class and ObjectFile/SharedFile. It removes bunch of methods from the .cpp file as well.
Sep 23 2015
- Fix style
- Fix clang build error
- Provide source of target incompatibility
Updated once again:
- Rename OPT_m -> OPT_emulation
- Fix word spelling in error message
Updated:
- Determine target from the first input file if no emulation given
- Sort emulations alphabetically in the array
- Revert adding -m option to all test cases, add only where needed
Sep 22 2015
I did this so if the host is not x86-64 machine all the tests still pass.
Sep 18 2015
Rafael, thanks for the effort, but I have to abandon this one since the implemented logic is partially wrong. I might re-implement it, but it's more likely to appear in the new linker some time later.
Sep 17 2015
Sep 15 2015
Sep 2 2015
Updated:
- Remove check for duplicate names of output sections.
Rafael, you're right. There may be more than one output section description with the same name. But headers in PHDRS command should have unique names, so I'll leave only check for duplicate header names.
Aug 14 2015
Aug 12 2015
Jul 29 2015
Jul 23 2015
Jul 16 2015
Ping.
Jul 7 2015
Jul 6 2015
LGTM.
Jul 3 2015
Jun 15 2015
Jun 12 2015
Updated:
- return error immediately when encountered
- use SmallVector instead of std::vector for holding matched headers for sections