Page MenuHomePhabricator

deepak2427 (Deepak Panickal)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2013, 10:15 AM (272 w, 3 d)

Recent Activity

Jul 10 2018

deepak2427 added a comment to D48721: Patch to fix pragma metadata for do-while loops.

@Bjorn, Thanks for reviewing and accepting the patch.

Jul 10 2018, 9:46 AM · Restricted Project

Jul 5 2018

deepak2427 updated the diff for D48721: Patch to fix pragma metadata for do-while loops.

Updated with test from Bjorn Pettersson which is much more accurate and clearer. Thanks!

Jul 5 2018, 8:24 AM · Restricted Project
deepak2427 added a comment to D48721: Patch to fix pragma metadata for do-while loops.

Yeah, you're right. Only one loop has to be checked in this case. I'll update the test as per your suggestion. Thank you!

Jul 5 2018, 8:16 AM · Restricted Project
deepak2427 added a comment to D48721: Patch to fix pragma metadata for do-while loops.

I have updated the test to not run the optimizer. The test I had added previously for checking if the unroller is respecting the pragma is useful I think. Not sure where that can be added though.
I guess it's independent of this patch anyway. If the patch and test is okay, will update bugzilla as well.

Jul 5 2018, 7:44 AM · Restricted Project
deepak2427 updated the diff for D48721: Patch to fix pragma metadata for do-while loops.

Update the tests.

Jul 5 2018, 7:41 AM · Restricted Project

Jul 4 2018

deepak2427 added a comment to D48721: Patch to fix pragma metadata for do-while loops.

I encountered the issue while working with the unroller and found that it was not following the pragma info, and traced it back to the issue with metadata.
As far as I understood, for for-loops and while-loops, we add the metadata only to the loop back-edge. So it would make sense to keep them consistent.
I'm not an expert in clang, and do not know how we can detect such problems.

Jul 4 2018, 3:22 AM · Restricted Project

Jul 1 2018

deepak2427 added a comment to D48721: Patch to fix pragma metadata for do-while loops.

Added to Bugzilla,
https://bugs.llvm.org/show_bug.cgi?id=38011

Jul 1 2018, 2:24 PM · Restricted Project

Jun 29 2018

deepak2427 added a comment to D48721: Patch to fix pragma metadata for do-while loops.

Do I need to add specific reviewers?

Jun 29 2018, 8:43 AM · Restricted Project

Jun 28 2018

deepak2427 updated subscribers of D48721: Patch to fix pragma metadata for do-while loops.

I had based it on the other tests in clang/test/CodeGen.
Do we not need the -o to output to standard output?
Or did you mean something else?

Jun 28 2018, 4:32 PM · Restricted Project
deepak2427 added a reviewer for D48721: Patch to fix pragma metadata for do-while loops: Restricted Project.
Jun 28 2018, 2:21 PM · Restricted Project
deepak2427 updated the diff for D48721: Patch to fix pragma metadata for do-while loops.

Add tests and the patch.

Jun 28 2018, 2:20 PM · Restricted Project
deepak2427 updated the diff for D48721: Patch to fix pragma metadata for do-while loops.

Add tests.

Jun 28 2018, 2:18 PM · Restricted Project
deepak2427 added a comment to D48721: Patch to fix pragma metadata for do-while loops.

Phab is the correct way to submit patches.
But having a bugreport in bugzilla is good too.
But the test will be needed regardless of the patch submission method.
And yes, please do always upload all patches with full context (-U99999).

Jun 28 2018, 7:17 AM · Restricted Project
deepak2427 updated the diff for D48721: Patch to fix pragma metadata for do-while loops.

Add full context

Jun 28 2018, 7:08 AM · Restricted Project
deepak2427 added a comment to D48721: Patch to fix pragma metadata for do-while loops.

It's a patch for a bug in clang.
I have requested for a Bugzilla account, however thought of putting up the
patch in the meantime.
Do I need to mark it '[Private]'?

Jun 28 2018, 6:56 AM · Restricted Project
deepak2427 created D48721: Patch to fix pragma metadata for do-while loops.
Jun 28 2018, 6:36 AM · Restricted Project

Jun 29 2015

deepak2427 added a reviewer for D9404: Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation: clayborg.

Adding Greg for review.

Jun 29 2015, 3:36 AM

Apr 22 2015

deepak2427 added a comment to D9054: MI fix allowing multiple logging instances of lldb-mi to run simultaneously..

The temp directory was chosen since it's portable. There's no syslog.h in Windows and also no directory like /var/log I think.

Apr 22 2015, 6:46 AM
deepak2427 added a comment to D9054: MI fix allowing multiple logging instances of lldb-mi to run simultaneously..

I think the default being the current directory "." would not be a good idea, if lldb-mi does not have the permission to write there. Unlike lldb, this is more important for lldb-mi, especially while debugging from a GUI, since the user wouldn't know what's happening and why lldb-mi failed.

Apr 22 2015, 6:15 AM

Jul 30 2014

deepak2427 added a comment to D4675: [2/2] Fix Path support on Windows.

Thanks for fixing this. I haven't had a chance to test this patch with our cross-platform issues yet, have to look at some other issues first.
Just a couple of doubts I had.

Jul 30 2014, 4:26 PM

Jul 25 2014

deepak2427 added a comment to D4669: Changes the hardcoded loading of ARM registers to moved from gdb-remote and fixes an issue with the $g packet where the data is thrown away with size mismatch .

You're right. That should be replaced to looping through registers one by one and marking them valid.
I'll modify it.

Jul 25 2014, 10:25 AM
deepak2427 retitled D4672: For expression evaluation, a new ThreadPlanCallFunctionGDB for executing a function call on target via register manipulation. from to For expression evaluation, a new ThreadPlanCallFunctionGDB for executing a function call on target via register manipulation..
Jul 25 2014, 10:04 AM
deepak2427 added a comment to D4666: Handle path slashes properly, when the binary is compiled in Windows and used in Linux and vice-versa.

Yeah, updating the PathMappingList does seem more appropriate. We specifically had issues with interoperability handling paths between different operating systems. If your patch is ready, please put it up and we can test it out.

Jul 25 2014, 9:21 AM
deepak2427 retitled D4669: Changes the hardcoded loading of ARM registers to moved from gdb-remote and fixes an issue with the $g packet where the data is thrown away with size mismatch from to Changes the hardcoded loading of ARM registers to moved from gdb-remote and fixes an issue with the $g packet where the data is thrown away with size mismatch .
Jul 25 2014, 8:55 AM
deepak2427 retitled D4666: Handle path slashes properly, when the binary is compiled in Windows and used in Linux and vice-versa from to Handle path slashes properly, when the binary is compiled in Windows and used in Linux and vice-versa.
Jul 25 2014, 8:09 AM

Jul 23 2014

deepak2427 retitled D4640: Add a new command "frame dump" to dump the current stack frame displaying sp and fp registers. from to Add a new command "frame dump" to dump the current stack frame displaying sp and fp registers..
Jul 23 2014, 9:44 AM

Jul 21 2014

deepak2427 retitled D4604: Changes to lldb/Target/ABI.h for paving the way for expression evaluation on Hexagon. from to Changes to lldb/Target/ABI.h for paving the way for expression evaluation on Hexagon..
Jul 21 2014, 10:51 AM