Page MenuHomePhabricator

deansturtevant (Dean Sturtevant)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2018, 6:40 AM (113 w, 1 d)

Recent Activity

Aug 27 2019

deansturtevant added a comment to D66763: Ignore object files that lack coverage information. Before this change, if multiple binary files were presented, all of them must have been instrumented or the load would fail with coverage_map_error::no_data_found..

Thanks for the review including some great suggestions.
I do not have a commit account. Could you commit this for me? Thanks again.

Aug 27 2019, 1:12 PM · Restricted Project
deansturtevant added a comment to D66763: Ignore object files that lack coverage information. Before this change, if multiple binary files were presented, all of them must have been instrumented or the load would fail with coverage_map_error::no_data_found..

Sorry. User error. Should be up now.

Aug 27 2019, 9:13 AM · Restricted Project
deansturtevant updated the diff for D66763: Ignore object files that lack coverage information. Before this change, if multiple binary files were presented, all of them must have been instrumented or the load would fail with coverage_map_error::no_data_found..

Responded to review comments. Simplified the code and the tests.

Aug 27 2019, 9:12 AM · Restricted Project
deansturtevant added a comment to D66763: Ignore object files that lack coverage information. Before this change, if multiple binary files were presented, all of them must have been instrumented or the load would fail with coverage_map_error::no_data_found..

Thanks. Please take another look.

Aug 27 2019, 7:40 AM · Restricted Project

Aug 26 2019

deansturtevant added a comment to D66763: Ignore object files that lack coverage information. Before this change, if multiple binary files were presented, all of them must have been instrumented or the load would fail with coverage_map_error::no_data_found..

We can simplify by not propagating data_not_found, but rather manufacturing one if desired.
However, that would result in any information in the original payload being lost.
Let me know if that is ok.

Aug 26 2019, 2:11 PM · Restricted Project
deansturtevant added a reviewer for D66763: Ignore object files that lack coverage information. Before this change, if multiple binary files were presented, all of them must have been instrumented or the load would fail with coverage_map_error::no_data_found.: vsk.
Aug 26 2019, 12:01 PM · Restricted Project
deansturtevant created D66763: Ignore object files that lack coverage information. Before this change, if multiple binary files were presented, all of them must have been instrumented or the load would fail with coverage_map_error::no_data_found..
Aug 26 2019, 11:21 AM · Restricted Project

Feb 5 2018

deansturtevant created D42907: BitTracker.h needs a full definition of MachineInstr, so include the defining file..
Feb 5 2018, 7:03 AM