Page MenuHomePhabricator

dcastagna (Daniele Castagna)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2021, 8:09 AM (40 w, 5 d)

Recent Activity

Yesterday

dcastagna updated the diff for D117137: [Driver] Add CUDA support for --offload param.

Rebase on ToT

Fri, Jan 21, 10:10 AM · Restricted Project

Thu, Jan 20

dcastagna updated the diff for D117137: [Driver] Add CUDA support for --offload param.

Fix invalid-offload-options.cpp test

Thu, Jan 20, 4:21 PM · Restricted Project
dcastagna added a comment to D117137: [Driver] Add CUDA support for --offload param.

The title says --offline option, which should be --offload.

Thu, Jan 20, 1:15 PM · Restricted Project
dcastagna updated the diff for D117137: [Driver] Add CUDA support for --offload param.

Address yaxunl@ comment in Options.td

Thu, Jan 20, 1:13 PM · Restricted Project
dcastagna updated the diff for D117137: [Driver] Add CUDA support for --offload param.

Address tra@ and yaxunl@ comments.
Error out if offload is used without --emit-llvm

Thu, Jan 20, 1:10 PM · Restricted Project

Wed, Jan 19

dcastagna added a comment to D117137: [Driver] Add CUDA support for --offload param.

I think instead of setting the triple directly from the command line, we should start with adding another --cuda-gpu-arch (AKA --offload-arch) variant and derive the triple and other parameters from it.

Wed, Jan 19, 5:43 PM · Restricted Project
dcastagna updated the diff for D117137: [Driver] Add CUDA support for --offload param.

Using already existing --offload parameters instead of adding a new one

Wed, Jan 19, 5:41 PM · Restricted Project

Wed, Jan 12

dcastagna added reviewers for D117137: [Driver] Add CUDA support for --offload param: jlebar, mkuper.
Wed, Jan 12, 11:57 AM · Restricted Project
dcastagna requested review of D117137: [Driver] Add CUDA support for --offload param.
Wed, Jan 12, 11:55 AM · Restricted Project

Nov 22 2021

dcastagna added a reviewer for D114407: [CUDA][SPIRV] Use OpenCLKernel CC for CUDA -> SPIRV: jlebar.
Nov 22 2021, 6:08 PM · Restricted Project
dcastagna requested review of D114407: [CUDA][SPIRV] Use OpenCLKernel CC for CUDA -> SPIRV.
Nov 22 2021, 6:01 PM · Restricted Project

Apr 12 2021

dcastagna added a comment to D100310: Add field designated initializers logic in Tooling/Rename.

Thank you Justin.
I'm happy with this now that I finally managed to get rid of the lint errors.
Let's wait for Micheal's opinion or until tomorrow and then we can push it?

Apr 12 2021, 11:57 AM · Restricted Project
dcastagna updated the diff for D100310: Add field designated initializers logic in Tooling/Rename.

clang-format again

Apr 12 2021, 11:33 AM · Restricted Project
dcastagna updated the diff for D100310: Add field designated initializers logic in Tooling/Rename.

Actually run git clang-format

Apr 12 2021, 10:48 AM · Restricted Project
dcastagna updated the diff for D100310: Add field designated initializers logic in Tooling/Rename.

Fixed clang-format pre-merge lints

Apr 12 2021, 9:58 AM · Restricted Project
dcastagna added reviewers for D100310: Add field designated initializers logic in Tooling/Rename: jlebar, mkuper.
Apr 12 2021, 8:38 AM · Restricted Project
dcastagna requested review of D100310: Add field designated initializers logic in Tooling/Rename.
Apr 12 2021, 8:36 AM · Restricted Project