Page MenuHomePhabricator

davidtgoldblatt (David Goldblatt)
User

Projects

User does not belong to any projects.

User Details

User Since
May 19 2021, 10:18 AM (17 w, 3 d)

Recent Activity

May 25 2021

davidtgoldblatt added a comment to D102864: [InstSimplify] Transform X * Y % Y --> 0..

Ah, gotcha, thanks. Still learning the LLVM diff workflows.

May 25 2021, 8:38 AM · Restricted Project

May 24 2021

davidtgoldblatt updated the diff for D102864: [InstSimplify] Transform X * Y % Y --> 0..

Add (a / y) * y % y tests, make Opcode first arg, add Alive2 links to the commit message.

May 24 2021, 10:12 AM · Restricted Project

May 22 2021

davidtgoldblatt added a comment to D102864: [InstSimplify] Transform X * Y % Y --> 0..

BTW, re-reading I realized I phrased that diff update poorly. I meant to say something more like "now that I understand better, it's obvious to me that you're right", not like "that thing you pointed out was obvious"; hopefully it parsed that way, and sorry if it didn't.

May 22 2021, 4:58 PM · Restricted Project

May 21 2021

davidtgoldblatt updated the diff for D102864: [InstSimplify] Transform X * Y % Y --> 0..

Merge cases into simplifyDivRem

May 21 2021, 6:02 PM · Restricted Project
davidtgoldblatt added a comment to D102864: [InstSimplify] Transform X * Y % Y --> 0..

No problem. I can commit on your behalf. To confirm - use your gmail address for author info?

May 21 2021, 11:19 AM · Restricted Project

May 20 2021

davidtgoldblatt added a comment to D102864: [InstSimplify] Transform X * Y % Y --> 0..

I don't have commit access. Happy to split this in two and do two diffs if you'd prefer, though.

May 20 2021, 3:02 PM · Restricted Project
davidtgoldblatt updated the diff for D102864: [InstSimplify] Transform X * Y % Y --> 0..

Add commuted and vector test cases.

May 20 2021, 3:01 PM · Restricted Project
davidtgoldblatt requested review of D102864: [InstSimplify] Transform X * Y % Y --> 0..
May 20 2021, 12:11 PM · Restricted Project