Page MenuHomePhabricator
People davidben

davidben (David Benjamin)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2022, 12:58 PM (46 w, 2 d)

Recent Activity
View All

Apr 25 2023

davidben added a comment to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.

Friendly ping

Apr 25 2023, 9:32 PM · Restricted Project, Restricted Project

Apr 21 2023

davidben added a comment to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
In D146190#4287960, @Mordante wrote:
In D146190#4278503, @davidben wrote:
In D146190#4278224, @Mordante wrote:

LGTM modulo the documentation issue. Please make sure the CI is green before landing. Note the sanitizers CI is currently broken and the AIX may also be offline. So feel free to ignore errors from these runners.

Ack. Though I don't think I have bits to land things, so I'll need to wait for one of you all to do it anyway. :-)

Can you provide "your name <your@email.address>" then somebody can commit it on your behalf.

Apr 21 2023, 8:42 PM · Restricted Project, Restricted Project

Apr 18 2023

davidben added a comment to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
In D146190#4278224, @Mordante wrote:

LGTM modulo the documentation issue. Please make sure the CI is green before landing. Note the sanitizers CI is currently broken and the AIX may also be offline. So feel free to ignore errors from these runners.

Apr 18 2023, 1:39 PM · Restricted Project, Restricted Project
davidben added inline comments to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
Apr 18 2023, 1:38 PM · Restricted Project, Restricted Project
davidben updated the diff for D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.

Fix link

Apr 18 2023, 1:37 PM · Restricted Project, Restricted Project

Apr 17 2023

davidben added inline comments to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
Apr 17 2023, 5:18 PM · Restricted Project, Restricted Project
davidben updated the diff for D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.

Documentation tweaks

Apr 17 2023, 5:16 PM · Restricted Project, Restricted Project

Apr 13 2023

davidben added inline comments to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
Apr 13 2023, 3:59 PM · Restricted Project, Restricted Project
davidben updated the diff for D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.

Update bug URL

Apr 13 2023, 3:57 PM · Restricted Project, Restricted Project

Apr 12 2023

davidben added a comment to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
In D146190#4261827, @philnik wrote:

I'm OK with landing this now if you commit to addressing any feedback Mark might have, since this is actually a blocker for you.

Apr 12 2023, 12:35 PM · Restricted Project, Restricted Project

Apr 10 2023

davidben added a comment to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.

Re a few days, I added more notes to the documentation March 21st, which was about three weeks ago. :-) Also the original patch is over a year old now.

Apr 10 2023, 5:27 PM · Restricted Project, Restricted Project
davidben added inline comments to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
Apr 10 2023, 2:32 PM · Restricted Project, Restricted Project
davidben updated the diff for D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.

CI failure seems unrelated. Rebasing (changed test to use std:size_t since it seems you all have started qualifying it) and reuploading in hopes that clears.

Apr 10 2023, 2:30 PM · Restricted Project, Restricted Project
davidben added a comment to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.

Are folks satisfied with the state of this? What's needed to move forward with this change?

Apr 10 2023, 12:22 PM · Restricted Project, Restricted Project

Mar 21 2023

davidben added inline comments to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
Mar 21 2023, 4:17 PM · Restricted Project, Restricted Project
davidben updated the diff for D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.

Address review comments

Mar 21 2023, 4:16 PM · Restricted Project, Restricted Project
davidben updated the summary of D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
Mar 21 2023, 4:15 PM · Restricted Project, Restricted Project

Mar 19 2023

davidben added inline comments to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
Mar 19 2023, 7:08 PM · Restricted Project, Restricted Project

Mar 16 2023

davidben added a comment to D145981: [libc++] Assert that lengths fit in difference_type.
In D145981#4199900, @Mordante wrote:

LGTM, but can you reupload this revision to see that it passes the Windows CI, these errors look odd so I like to have a rerun. It seems the exception issue is unrelated.

Mar 16 2023, 2:26 PM · Restricted Project, Restricted Project
davidben updated the diff for D145981: [libc++] Assert that lengths fit in difference_type.

Reuploading

Mar 16 2023, 2:26 PM · Restricted Project, Restricted Project
davidben updated the summary of D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
Mar 16 2023, 2:24 PM · Restricted Project, Restricted Project
davidben added a comment to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.

Happy to do this however you all think is appropriate. I was just basing this on the discussion in https://reviews.llvm.org/D120064, which suggested folks preferred treating the MSVC ABI as unstable. (I'll update the description to link to the discussion.)

Mar 16 2023, 2:23 PM · Restricted Project, Restricted Project

Mar 15 2023

davidben added a comment to D120064: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.

Picking this up again, I uploaded https://reviews.llvm.org/D146190 which takes @jdoerrie's patch and adds the test and documentation change. (Should I have made a new revision or updated this one? I assumed new one since uploading over someone else's CL seemed rude. I'm surprised there even is an "Update Diff" button for me in the corner here! 😄)

Mar 15 2023, 8:56 PM · Restricted Project, Restricted Project
davidben requested review of D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.
Mar 15 2023, 8:54 PM · Restricted Project, Restricted Project
davidben updated the diff for D145981: [libc++] Assert that lengths fit in difference_type.

Hopefully fix C++11 test failures.

Mar 15 2023, 8:16 PM · Restricted Project, Restricted Project
davidben added inline comments to D145981: [libc++] Assert that lengths fit in difference_type.
Mar 15 2023, 8:07 PM · Restricted Project, Restricted Project
davidben added inline comments to D145981: [libc++] Assert that lengths fit in difference_type.
Mar 15 2023, 3:22 PM · Restricted Project, Restricted Project
davidben updated the diff for D145981: [libc++] Assert that lengths fit in difference_type.

Updates the test per review.

Mar 15 2023, 3:22 PM · Restricted Project, Restricted Project

Mar 13 2023

davidben updated the summary of D145981: [libc++] Assert that lengths fit in difference_type.
Mar 13 2023, 12:47 PM · Restricted Project, Restricted Project
davidben added a comment to D145981: [libc++] Assert that lengths fit in difference_type.

(This is my first time contributing here or using this tool, so let me know if I got something wrong!)

Mar 13 2023, 12:46 PM · Restricted Project, Restricted Project
davidben requested review of D145981: [libc++] Assert that lengths fit in difference_type.
Mar 13 2023, 12:45 PM · Restricted Project, Restricted Project