Thanks for the detailed explanation, mostly tally's up with what I've just read. One thing

In D66426#1639065, @davidb wrote:

In D66426#1637540, @MaskRay wrote:

Another problem is that .note.gnu.build-id is SHF_ALLOC and included in a PT_LOAD segment. When computing watermark, you probably don't want to include its contents. So you should compute build-id and watermark first before you write.

What target are you looking at? I thought generally note sections aren't allocated and are usually safe to remove. If they were included in a segment, then that would be a PT_NOTE segment that isn't nested in a PT_LOAD segment.

In D66426#1637540, @MaskRay wrote:

Another problem is that .note.gnu.build-id is SHF_ALLOC and included in a PT_LOAD segment. When computing watermark, you probably don't want to include its contents. So you should compute build-id and watermark first before you write.

Updating D34685: Mark a number of x86 only tests to require x86

I can't seem to do it through the Phabricator UI, or archanist which has just created a new differential... https://reviews.llvm.org/D35565

Updating D35565: Update REQUIRES to use x86

Sorry, Jon and I have been out of office the past week.

In D34685#796778, @ruiu wrote:

I don't know if I understand what you said correctly. I do not want to force anyone to enable the x86 target. If you disable x86, tests that use x86 as a "generic" target won't run, but it shouldn't be more than that. I'm still waiting for you to update this patch to address Rafael's comment.

A few more tests have been introduced like this. It may make more sense to restructure the tests so that they are separated by target.

remarks need to be suppressed by default.

The current implementation will result in a remark always being emitted for llc, so we need to make a change to prevent that.

ping

Hi Sam,

Closed by revision r293638.

In D27985#660029, @mehdi_amini wrote:

LGTM.

Can you apply the patch in LLVM (libDemangle) as well please?

ping

ping

LGTM, thanks for the quick response on this!

As regarding the note section format, AFAIK, there is no formal
specification in ELF. The organization mentioned in the document is
for illustration purpose only.

thanks,

David

The section type has been changed to SHT_NOTE, however the section contents has not been changed to match the NOTE section format. This has caused issues with some of our tools and may affect others that use note sections. There is a description of the note section format here: