People davidb

davidb (Dave Bozier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 26 2016, 7:28 AM (77 w, 6 d)

Recent Activity

Tue, Jul 18

davidb abandoned D35565: Mark a number of x86 only tests to require x86.
Tue, Jul 18, 9:11 AM
davidb updated the diff for D34685: Mark a number of x86 only tests to require x86.

Updating D34685: Mark a number of x86 only tests to require x86

Tue, Jul 18, 9:11 AM
davidb retitled D35565: Mark a number of x86 only tests to require x86 from Update REQUIRES to use x86 to Mark a number of x86 only tests to require x86.
Tue, Jul 18, 8:24 AM
davidb updated subscribers of D35565: Mark a number of x86 only tests to require x86.
Tue, Jul 18, 8:23 AM
davidb updated subscribers of D35565: Mark a number of x86 only tests to require x86.
Tue, Jul 18, 8:23 AM
davidb added a comment to D34685: Mark a number of x86 only tests to require x86.

I can't seem to do it through the Phabricator UI, or archanist which has just created a new differential... https://reviews.llvm.org/D35565

Tue, Jul 18, 8:22 AM
davidb updated the diff for D35565: Mark a number of x86 only tests to require x86.

Updating D35565: Update REQUIRES to use x86

Tue, Jul 18, 8:16 AM
davidb created D35565: Mark a number of x86 only tests to require x86.
Tue, Jul 18, 8:11 AM

Mon, Jul 17

davidb added a comment to D34685: Mark a number of x86 only tests to require x86.

Sorry, Jon and I have been out of office the past week.

Mon, Jul 17, 6:08 AM

Fri, Jun 30

davidb added a comment to D34685: Mark a number of x86 only tests to require x86.
In D34685#796778, @ruiu wrote:

I don't know if I understand what you said correctly. I do not want to force anyone to enable the x86 target. If you disable x86, tests that use x86 as a "generic" target won't run, but it shouldn't be more than that. I'm still waiting for you to update this patch to address Rafael's comment.

Fri, Jun 30, 8:54 AM

Thu, Jun 29

davidb added a comment to D34685: Mark a number of x86 only tests to require x86.

A few more tests have been introduced like this. It may make more sense to restructure the tests so that they are separated by target.

Thu, Jun 29, 10:21 AM

Mar 2 2017

davidb committed rL296763: Allow use of spaces in Bugpoint ‘--compile-command’ argument.
Allow use of spaces in Bugpoint ‘--compile-command’ argument
Mar 2 2017, 9:02 AM
davidb closed D29940: Allow use of spaces in Bugpoint ‘--compile-command’ argument by committing rL296763: Allow use of spaces in Bugpoint ‘--compile-command’ argument.
Mar 2 2017, 9:02 AM

Feb 28 2017

davidb committed rL296492: Fix issue with test case. Make test x86_64 specific.
Fix issue with test case. Make test x86_64 specific
Feb 28 2017, 9:37 AM
davidb committed rL296483: [Stack Protection] Add diagnostic information for why stack protection was….
[Stack Protection] Add diagnostic information for why stack protection was…
Feb 28 2017, 8:14 AM
davidb closed D29023: [Stack Protection] Add diagnostic information for why stack protection was applied to a function by committing rL296483: [Stack Protection] Add diagnostic information for why stack protection was….
Feb 28 2017, 8:14 AM

Feb 15 2017

davidb committed rL295188: Fix unittest for buildbot with mips host (32bit big endian) from r295174.
Fix unittest for buildbot with mips host (32bit big endian) from r295174
Feb 15 2017, 8:14 AM
davidb committed rL295174: Attempt to fix buildbots after commit of r295173. .
Attempt to fix buildbots after commit of r295173.
Feb 15 2017, 5:51 AM
davidb committed rL295173: Fix incorrect formatting of DataRefImpl members in operator<< function.
Fix incorrect formatting of DataRefImpl members in operator<< function
Feb 15 2017, 5:10 AM
davidb closed D28957: Fix incorrect formatting of DataRefImpl members in operator<< function by committing rL295173: Fix incorrect formatting of DataRefImpl members in operator<< function.
Feb 15 2017, 5:10 AM

Feb 9 2017

davidb added inline comments to D28957: Fix incorrect formatting of DataRefImpl members in operator<< function.
Feb 9 2017, 10:07 AM
davidb requested changes to D29023: [Stack Protection] Add diagnostic information for why stack protection was applied to a function.

remarks need to be suppressed by default.

Feb 9 2017, 8:49 AM
davidb reopened D29023: [Stack Protection] Add diagnostic information for why stack protection was applied to a function.

The current implementation will result in a remark always being emitted for llc, so we need to make a change to prevent that.

Feb 9 2017, 8:48 AM
davidb committed rL294593: Revert: "[Stack Protection] Add diagnostic information for why stack protection….
Revert: "[Stack Protection] Add diagnostic information for why stack protection…
Feb 9 2017, 7:51 AM
davidb committed rL294590: [Stack Protection] Add diagnostic information for why stack protection was….
[Stack Protection] Add diagnostic information for why stack protection was…
Feb 9 2017, 7:20 AM
davidb closed D29023: [Stack Protection] Add diagnostic information for why stack protection was applied to a function by committing rL294590: [Stack Protection] Add diagnostic information for why stack protection was….
Feb 9 2017, 7:20 AM
davidb added reviewers for D28957: Fix incorrect formatting of DataRefImpl members in operator<< function: pcc, samparker.
Feb 9 2017, 7:09 AM
davidb added a comment to D28957: Fix incorrect formatting of DataRefImpl members in operator<< function.

ping

Feb 9 2017, 6:26 AM
davidb committed rL294586: [docs] cleanup documentation on lit substitutions.
[docs] cleanup documentation on lit substitutions
Feb 9 2017, 6:24 AM
davidb closed D29281: [docs] cleanup documentation on lit substitutions by committing rL294586: [docs] cleanup documentation on lit substitutions.
Feb 9 2017, 6:24 AM

Feb 7 2017

davidb added a comment to D29632: Use ELF dynamic symbols for disassembly.

Hi Sam,

Feb 7 2017, 6:29 AM

Jan 31 2017

davidb closed D27985: Add demangling support for C++11 thread_local variables.

Closed by revision r293638.

Jan 31 2017, 9:56 AM
davidb committed rL293643: Add support for demangling C++11 thread_local variables. .
Add support for demangling C++11 thread_local variables.
Jan 31 2017, 8:07 AM
davidb committed rL293638: Add support for demangling C++11 thread_local variables. In clang, the grammar….
Add support for demangling C++11 thread_local variables. In clang, the grammar…
Jan 31 2017, 7:30 AM

Jan 30 2017

davidb added a comment to D27985: Add demangling support for C++11 thread_local variables.
In D27985#660029, @mehdi_amini wrote:

LGTM.

Can you apply the patch in LLVM (libDemangle) as well please?

Jan 30 2017, 6:37 AM

Jan 27 2017

davidb added inline comments to D29095: Open ELF core dumps with more than 64K sections.
Jan 27 2017, 7:54 AM

Jan 26 2017

davidb added a comment to D27985: Add demangling support for C++11 thread_local variables.

ping

Jan 26 2017, 6:56 AM

Jan 20 2017

davidb updated subscribers of D28957: Fix incorrect formatting of DataRefImpl members in operator<< function.
Jan 20 2017, 9:32 AM
davidb created D28957: Fix incorrect formatting of DataRefImpl members in operator<< function.
Jan 20 2017, 9:31 AM

Jan 18 2017

davidb added a comment to D27985: Add demangling support for C++11 thread_local variables.

ping

Jan 18 2017, 6:34 AM

Dec 20 2016

davidb retitled D27985: Add demangling support for C++11 thread_local variables from to Add demangling support for C++11 thread_local variables.
Dec 20 2016, 5:37 AM

Feb 17 2016

davidb added a comment to D17309: [coverage] covmap section can now be emitted as 'progbits' without alloc flag set.

LGTM, thanks for the quick response on this!

Feb 17 2016, 3:11 AM

Feb 16 2016

davidb added a comment to D16092: [Coverage] Do not allocate memory for coverage map data (Linux).

As regarding the note section format, AFAIK, there is no formal
specification in ELF. The organization mentioned in the document is
for illustration purpose only.

thanks,

David

Feb 16 2016, 11:20 AM
davidb added a comment to D16092: [Coverage] Do not allocate memory for coverage map data (Linux).

The section type has been changed to SHT_NOTE, however the section contents has not been changed to match the NOTE section format. This has caused issues with some of our tools and may affect others that use note sections. There is a description of the note section format here:

Feb 16 2016, 9:10 AM