Page MenuHomePhabricator

davidb (Dave Bozier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 26 2016, 7:28 AM (217 w, 4 d)

Recent Activity

Thu, Mar 26

davidb requested changes to D75631: [llvm-objdump] Fix reliability of call target disassembling.

Test change looks good (address lookup rather than by name), but it makes the objdump change completely irrelevant to this now, so I'd revert the objdump change.

Thu, Mar 26, 9:11 AM · Restricted Project
davidb added inline comments to D75631: [llvm-objdump] Fix reliability of call target disassembling.
Thu, Mar 26, 7:33 AM · Restricted Project

Wed, Mar 25

davidb added inline comments to D75631: [llvm-objdump] Fix reliability of call target disassembling.
Wed, Mar 25, 9:09 AM · Restricted Project
davidb added inline comments to D75631: [llvm-objdump] Fix reliability of call target disassembling.
Wed, Mar 25, 8:37 AM · Restricted Project
davidb added inline comments to D75631: [llvm-objdump] Fix reliability of call target disassembling.
Wed, Mar 25, 8:37 AM · Restricted Project
davidb added a comment to D75631: [llvm-objdump] Fix reliability of call target disassembling.

This still needed after D76739?

Wed, Mar 25, 7:32 AM · Restricted Project
davidb added inline comments to D76739: [llvm-objdump] Replace array_pod_sort with llvm::stable_sort.
Wed, Mar 25, 7:32 AM · Restricted Project
davidb accepted D76739: [llvm-objdump] Replace array_pod_sort with llvm::stable_sort.

Thanks for this!

Wed, Mar 25, 7:32 AM · Restricted Project

Mon, Mar 9

davidb updated the diff for D75536: [LLD] Add support for --unique option.
  • formatting
Mon, Mar 9, 9:08 AM · Restricted Project
davidb updated the summary of D75536: [LLD] Add support for --unique option.
Mon, Mar 9, 8:02 AM · Restricted Project
davidb updated the diff for D75536: [LLD] Add support for --unique option.
  • rebase
Mon, Mar 9, 7:30 AM · Restricted Project
davidb updated the diff for D75536: [LLD] Add support for --unique option.
  • review comments
Mon, Mar 9, 7:30 AM · Restricted Project

Thu, Mar 5

davidb added inline comments to D75536: [LLD] Add support for --unique option.
Thu, Mar 5, 10:22 AM · Restricted Project
davidb added inline comments to D75536: [LLD] Add support for --unique option.
Thu, Mar 5, 10:22 AM · Restricted Project
davidb updated the diff for D75536: [LLD] Add support for --unique option.
  • review comments
Thu, Mar 5, 9:51 AM · Restricted Project
davidb updated the diff for D75536: [LLD] Add support for --unique option.
  • rebase
Thu, Mar 5, 8:45 AM · Restricted Project
davidb updated the diff for D75536: [LLD] Add support for --unique option.
  • replace objdump with readelf
Thu, Mar 5, 6:01 AM · Restricted Project
davidb updated the diff for D75536: [LLD] Add support for --unique option.
  • review comments
Thu, Mar 5, 5:29 AM · Restricted Project
davidb updated the diff for D75536: [LLD] Add support for --unique option.
  • fix formatting from clang-format
Thu, Mar 5, 4:56 AM · Restricted Project
davidb updated the diff for D75536: [LLD] Add support for --unique option.
  • review comments
Thu, Mar 5, 4:56 AM · Restricted Project
davidb added inline comments to D75536: [LLD] Add support for --unique option.
Thu, Mar 5, 4:56 AM · Restricted Project

Tue, Mar 3

davidb added a comment to D75536: [LLD] Add support for --unique option.

Do you have a plan to implement --unique=pattern (overrides output section descriptions)? It is different from --unique (only applies to orphan sections).

I don't have a plan to implement --unique=pattern, as the default is good enough for my needs. However I would consider getting back and doing it when I next have some free cycles.

The merging of these sections in the case of a partial link (-r) inhibits deadstripping.

Dead stripping is a Mach-O term. Non --unique does not inhibit --gc-sections (without -r).
Without --unique, some orphan sections may be unnecessarily kept (as a whole their "liveness" can be larger than the composing parts).

Note that -r --gc-sections is not implemented in lld.

Sorry, force of habit. PlayStation toolchains also use the term dead-stripping for ELF binaries. I did indeed mean gc-sections.

The current workflow involves multiple link stages, involving a partial link and then an executable link. It is the second link that performs -gc-sections. We would like to keep all functions in their own individual sections after the partial link.

I could update the test to demonstrate this if it is at all useful.

A test is not needed. Just make the test minimal (for example, as I suggested).

Please update SUMMARY by mentioning the --gc-sections scenario and delete the mention of deadstripping.

Tue, Mar 3, 3:00 PM · Restricted Project
davidb updated the summary of D75536: [LLD] Add support for --unique option.
Tue, Mar 3, 3:00 PM · Restricted Project
davidb updated the diff for D75536: [LLD] Add support for --unique option.
  • review comments
Tue, Mar 3, 3:00 PM · Restricted Project
davidb added a comment to D75536: [LLD] Add support for --unique option.

Do you have a plan to implement --unique=pattern (overrides output section descriptions)? It is different from --unique (only applies to orphan sections).

Tue, Mar 3, 1:14 PM · Restricted Project
davidb updated the diff for D75536: [LLD] Add support for --unique option.

rebase

Tue, Mar 3, 9:39 AM · Restricted Project
davidb updated the diff for D75536: [LLD] Add support for --unique option.

Fix lint checks

Tue, Mar 3, 9:39 AM · Restricted Project
davidb retitled D75536: [LLD] Add support for --unique option from Add support for --unique option to [LLD] Add support for --unique option.
Tue, Mar 3, 9:05 AM · Restricted Project
davidb created D75536: [LLD] Add support for --unique option.
Tue, Mar 3, 8:55 AM · Restricted Project

Fri, Feb 28

davidb added inline comments to D75131: [llvm-objdump][XCOFF][AIX] Implement -r option.
Fri, Feb 28, 3:48 PM · Restricted Project
davidb added inline comments to D75131: [llvm-objdump][XCOFF][AIX] Implement -r option.
Fri, Feb 28, 3:48 PM · Restricted Project
davidb added a comment to D75131: [llvm-objdump][XCOFF][AIX] Implement -r option.

This looks great, thanks Jason!

Fri, Feb 28, 11:41 AM · Restricted Project

Feb 25 2020

davidb added a comment to D74824: [objdump] Fix disassembly for call/branch instructions for ELF binaries built with -ffunction-sections.

Looks like you've got changes related to D74823 mixed in here?

Yes I put a note in the original description mentioning that this has been split to a separate change.

It would be clearer if you made them as two separate diffs, with the one that needs to be second based on the first one, so that Phabricator only shows the differences related to this patch (in other words, each Phabricator review represents one git commit). You can also indicate the dependency by saying "Depends on DXXXXXX" in the patch description, and Phabricator will then link the two patches together.

Feb 25 2020, 7:38 AM · Restricted Project
davidb updated the diff for D74824: [objdump] Fix disassembly for call/branch instructions for ELF binaries built with -ffunction-sections.

rebase

Feb 25 2020, 7:38 AM · Restricted Project
davidb added a comment to D74824: [objdump] Fix disassembly for call/branch instructions for ELF binaries built with -ffunction-sections.

Looks like you've got changes related to D74823 mixed in here?

Feb 25 2020, 5:00 AM · Restricted Project

Feb 24 2020

davidb added a comment to D74823: [XCOFF/objdump] Fix crash in objdump when trying to use -r with XCOFF binaries.

It's good that we don't crash, but I'm wondering why not just implement relocation printing for XCOFF? Also, is the intention to not print relocations mixed with disassembly only (i.e. -r + -d/D etc), or also relocation printing without disassembly (i.e. -r on its own)? If the latter, there needs to be a test for that too.

Feb 24 2020, 4:00 PM · Restricted Project

Feb 20 2020

davidb added inline comments to D74824: [objdump] Fix disassembly for call/branch instructions for ELF binaries built with -ffunction-sections.
Feb 20 2020, 4:15 AM · Restricted Project
davidb added inline comments to D74824: [objdump] Fix disassembly for call/branch instructions for ELF binaries built with -ffunction-sections.
Feb 20 2020, 4:10 AM · Restricted Project

Feb 19 2020

davidb added a comment to D74823: [XCOFF/objdump] Fix crash in objdump when trying to use -r with XCOFF binaries.

I think XCOFF is a WIP, so many things can break. It may be fine not adding a warning.

Feb 19 2020, 12:14 PM · Restricted Project
davidb updated the summary of D74824: [objdump] Fix disassembly for call/branch instructions for ELF binaries built with -ffunction-sections.
Feb 19 2020, 3:10 AM · Restricted Project
davidb created D74824: [objdump] Fix disassembly for call/branch instructions for ELF binaries built with -ffunction-sections.
Feb 19 2020, 2:59 AM · Restricted Project
davidb retitled D74824: [objdump] Fix disassembly for call/branch instructions for ELF binaries built with -ffunction-sections from [objump] Fix disassembly for call/branch instructions for ELF binaries built with -ffunction-sections to [objdump] Fix disassembly for call/branch instructions for ELF binaries built with -ffunction-sections.
Feb 19 2020, 2:59 AM · Restricted Project
davidb updated the diff for D74823: [XCOFF/objdump] Fix crash in objdump when trying to use -r with XCOFF binaries.
  • fix space issues
Feb 19 2020, 2:50 AM · Restricted Project
davidb added reviewers for D74823: [XCOFF/objdump] Fix crash in objdump when trying to use -r with XCOFF binaries: MaskRay, grimar, rnk.
Feb 19 2020, 2:50 AM · Restricted Project
davidb created D74823: [XCOFF/objdump] Fix crash in objdump when trying to use -r with XCOFF binaries.
Feb 19 2020, 2:44 AM · Restricted Project

Feb 17 2020

davidb updated subscribers of D74725: Demonstrate behaviour of add mul instruction sequence.
Feb 17 2020, 9:17 AM · Restricted Project
davidb updated the summary of D74725: Demonstrate behaviour of add mul instruction sequence.
Feb 17 2020, 9:17 AM · Restricted Project
davidb updated the summary of D74725: Demonstrate behaviour of add mul instruction sequence.
Feb 17 2020, 9:17 AM · Restricted Project
davidb created D74725: Demonstrate behaviour of add mul instruction sequence.
Feb 17 2020, 9:06 AM · Restricted Project

Feb 3 2020

davidb added a comment to D73793: Improve error message of FileCheck when stdin is empty.

I have a vague and probably unreasonable concern that changing from the beahviour for a filename "<stdin>" could cause somebody some confusion somewhere, since it's non-standard. I do agree with changing the error message though (we do similar things already in other tools, IIRC). What are others' thoughts?

Feb 3 2020, 7:24 AM · Restricted Project
davidb updated the diff for D73793: Improve error message of FileCheck when stdin is empty.
  • review comments
Feb 3 2020, 7:24 AM · Restricted Project

Jan 31 2020

davidb added inline comments to D73793: Improve error message of FileCheck when stdin is empty.
Jan 31 2020, 9:58 AM · Restricted Project
davidb added reviewers for D73793: Improve error message of FileCheck when stdin is empty: jhenderson, probinson, jdenny, grimar, arichardson.
Jan 31 2020, 9:58 AM · Restricted Project
davidb created D73793: Improve error message of FileCheck when stdin is empty.
Jan 31 2020, 9:58 AM · Restricted Project

Nov 19 2019

davidb closed D70438: Fixup AVR tests to reflect changes in addend format in llvm-objdump.
Nov 19 2019, 7:36 AM · Restricted Project
davidb added a comment to D69997: [llvm-objdump] Print relocation addends in hexadecimal.

I don't know if there's a list anywhere. ls llvm/lib/Target shows you all in tree targets, LLVM_ALL_TARGETS in cmake (see llvm-cs.pcc.me.uk) shows the on by default targets, so adding the difference to LLVM_EXPERIMENTAL_TARGETS_TO_BUILD will likely give you all targets.

Nov 19 2019, 6:54 AM · Restricted Project
davidb updated the summary of D70438: Fixup AVR tests to reflect changes in addend format in llvm-objdump.
Nov 19 2019, 6:02 AM · Restricted Project
davidb created D70438: Fixup AVR tests to reflect changes in addend format in llvm-objdump.
Nov 19 2019, 6:02 AM · Restricted Project
davidb added reviewers for D70438: Fixup AVR tests to reflect changes in addend format in llvm-objdump: thakis, jhenderson, grimar.
Nov 19 2019, 6:02 AM · Restricted Project
davidb added a comment to D69997: [llvm-objdump] Print relocation addends in hexadecimal.

This breaks oodles of AVR tests: http://45.33.8.238/linux/4114/step_10.txt

Nov 19 2019, 5:50 AM · Restricted Project
davidb added a comment to D69997: [llvm-objdump] Print relocation addends in hexadecimal.

This breaks oodles of AVR tests: http://45.33.8.238/linux/4114/step_10.txt

Nov 19 2019, 5:26 AM · Restricted Project

Nov 15 2019

davidb updated the diff for D69997: [llvm-objdump] Print relocation addends in hexadecimal.
  • Merge branch 'master' into disassembly_hex
Nov 15 2019, 5:26 AM · Restricted Project

Nov 14 2019

davidb updated the diff for D69997: [llvm-objdump] Print relocation addends in hexadecimal.
  • Merge branch 'master' into disassembly_hex
  • Fix test after branch update
Nov 14 2019, 6:54 AM · Restricted Project
davidb updated the diff for D69997: [llvm-objdump] Print relocation addends in hexadecimal.
  • remove whitesspace
Nov 14 2019, 2:22 AM · Restricted Project

Nov 13 2019

davidb updated the diff for D69997: [llvm-objdump] Print relocation addends in hexadecimal.
  • Split disassemble test case. Fix formatting
  • formatting
Nov 13 2019, 9:46 AM · Restricted Project
davidb added a comment to D69997: [llvm-objdump] Print relocation addends in hexadecimal.

What is the major request?

Nov 13 2019, 6:53 AM · Restricted Project
davidb added inline comments to D69997: [llvm-objdump] Print relocation addends in hexadecimal.
Nov 13 2019, 3:10 AM · Restricted Project
davidb updated the diff for D69997: [llvm-objdump] Print relocation addends in hexadecimal.
  • review comments
Nov 13 2019, 3:10 AM · Restricted Project

Nov 12 2019

davidb updated the diff for D69997: [llvm-objdump] Print relocation addends in hexadecimal.
  • formatting
Nov 12 2019, 7:13 AM · Restricted Project
davidb added inline comments to D69997: [llvm-objdump] Print relocation addends in hexadecimal.
Nov 12 2019, 7:13 AM · Restricted Project
davidb added a comment to D69997: [llvm-objdump] Print relocation addends in hexadecimal.

I haven't conditionally zero extended it in the case of -r. I'm not sure consistency with gnu objdump is worth it in that case and as there is a difference with -r -d it makes the code look. bit ugly. But I'm open to change that if you really insist...

Nov 12 2019, 7:13 AM · Restricted Project
davidb updated the diff for D69997: [llvm-objdump] Print relocation addends in hexadecimal.
  • Add tets for 64-bit limits checking
Nov 12 2019, 7:04 AM · Restricted Project
davidb added inline comments to D69997: [llvm-objdump] Print relocation addends in hexadecimal.
Nov 12 2019, 5:55 AM · Restricted Project

Nov 8 2019

davidb added inline comments to D69997: [llvm-objdump] Print relocation addends in hexadecimal.
Nov 8 2019, 5:56 AM · Restricted Project
davidb added a comment to D69997: [llvm-objdump] Print relocation addends in hexadecimal.

Thanks for the patch. I'm surprised this hasn't broken any LLD tests. Did you run those too?

Nov 8 2019, 3:13 AM · Restricted Project
davidb added inline comments to D69997: [llvm-objdump] Print relocation addends in hexadecimal.
Nov 8 2019, 3:13 AM · Restricted Project
davidb retitled D69997: [llvm-objdump] Print relocation addends in hexadecimal from Print relocation addends in hexadecimal to [llvm-objdump] Print relocation addends in hexadecimal.
Nov 8 2019, 2:28 AM · Restricted Project
davidb added a comment to D69997: [llvm-objdump] Print relocation addends in hexadecimal.

Thank you for the quick response.

Nov 8 2019, 2:28 AM · Restricted Project
davidb added a reviewer for D69997: [llvm-objdump] Print relocation addends in hexadecimal: bd1976llvm.
Nov 8 2019, 2:16 AM · Restricted Project
davidb added reviewers for D69997: [llvm-objdump] Print relocation addends in hexadecimal: MaskRay, grimar.
Nov 8 2019, 2:13 AM · Restricted Project
davidb created D69997: [llvm-objdump] Print relocation addends in hexadecimal.
Nov 8 2019, 2:13 AM · Restricted Project

Aug 21 2019

davidb added a comment to D66426: [lld] Enable a watermark of loadable sections to be generated and placed in a note section.

Thanks for the detailed explanation, mostly tally's up with what I've just read. One thing

Aug 21 2019, 6:46 AM · Restricted Project
davidb added a comment to D66426: [lld] Enable a watermark of loadable sections to be generated and placed in a note section.

Another problem is that .note.gnu.build-id is SHF_ALLOC and included in a PT_LOAD segment. When computing watermark, you probably don't want to include its contents. So you should compute build-id and watermark first before you write.

What target are you looking at? I thought generally note sections aren't allocated and are usually safe to remove. If they were included in a segment, then that would be a PT_NOTE segment that isn't nested in a PT_LOAD segment.

Aug 21 2019, 4:14 AM · Restricted Project
davidb added a comment to D66426: [lld] Enable a watermark of loadable sections to be generated and placed in a note section.

Another problem is that .note.gnu.build-id is SHF_ALLOC and included in a PT_LOAD segment. When computing watermark, you probably don't want to include its contents. So you should compute build-id and watermark first before you write.

Aug 21 2019, 4:04 AM · Restricted Project

Feb 16 2019

davidb abandoned D58322: remove microsoft intrinsics test that passes on osx but fails on linux.
Feb 16 2019, 5:44 AM · Restricted Project
davidb created D58322: remove microsoft intrinsics test that passes on osx but fails on linux.
Feb 16 2019, 5:44 AM · Restricted Project

Jul 28 2017

davidb added inline comments to D35944: [ELF] Disable relocation validation when targeting weak undefined symbols.
Jul 28 2017, 7:40 AM
davidb added inline comments to D35944: [ELF] Disable relocation validation when targeting weak undefined symbols.
Jul 28 2017, 7:38 AM

Jul 18 2017

davidb abandoned D35565: Mark a number of x86 only tests to require x86.
Jul 18 2017, 9:11 AM
davidb updated the diff for D34685: Mark a number of x86 only tests to require x86.

Updating D34685: Mark a number of x86 only tests to require x86

Jul 18 2017, 9:11 AM
davidb retitled D35565: Mark a number of x86 only tests to require x86 from Update REQUIRES to use x86 to Mark a number of x86 only tests to require x86.
Jul 18 2017, 8:24 AM
davidb updated subscribers of D35565: Mark a number of x86 only tests to require x86.
Jul 18 2017, 8:23 AM
davidb updated subscribers of D35565: Mark a number of x86 only tests to require x86.
Jul 18 2017, 8:23 AM
davidb added a comment to D34685: Mark a number of x86 only tests to require x86.

I can't seem to do it through the Phabricator UI, or archanist which has just created a new differential... https://reviews.llvm.org/D35565

Jul 18 2017, 8:22 AM
davidb updated the diff for D35565: Mark a number of x86 only tests to require x86.

Updating D35565: Update REQUIRES to use x86

Jul 18 2017, 8:16 AM
davidb created D35565: Mark a number of x86 only tests to require x86.
Jul 18 2017, 8:11 AM

Jul 17 2017

davidb added a comment to D34685: Mark a number of x86 only tests to require x86.

Sorry, Jon and I have been out of office the past week.

Jul 17 2017, 6:08 AM

Jun 30 2017

davidb added a comment to D34685: Mark a number of x86 only tests to require x86.
In D34685#796778, @ruiu wrote:

I don't know if I understand what you said correctly. I do not want to force anyone to enable the x86 target. If you disable x86, tests that use x86 as a "generic" target won't run, but it shouldn't be more than that. I'm still waiting for you to update this patch to address Rafael's comment.

Jun 30 2017, 8:54 AM

Jun 29 2017

davidb added a comment to D34685: Mark a number of x86 only tests to require x86.

A few more tests have been introduced like this. It may make more sense to restructure the tests so that they are separated by target.

Jun 29 2017, 10:21 AM

Mar 2 2017

davidb committed rL296763: Allow use of spaces in Bugpoint ‘--compile-command’ argument.
Allow use of spaces in Bugpoint ‘--compile-command’ argument
Mar 2 2017, 9:02 AM