Page MenuHomePhabricator

darcangelo.matthew (Matt D'Arcangelo)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 25 2020, 2:36 PM (8 w, 5 d)

Recent Activity

Aug 30 2020

darcangelo.matthew updated the diff for D86578: [TargetLowering] Combine known bits for icmp in SimplifySetCC (PR41182).

rebase

Aug 30 2020, 8:26 PM · Restricted Project
darcangelo.matthew added inline comments to D86578: [TargetLowering] Combine known bits for icmp in SimplifySetCC (PR41182).
Aug 30 2020, 8:20 PM · Restricted Project

Aug 29 2020

darcangelo.matthew added a comment to D86578: [TargetLowering] Combine known bits for icmp in SimplifySetCC (PR41182).

@RKSimon Meant to say this before - Thank you for putting up additional reviewers Simon, I appreciate your help with this

Aug 29 2020, 8:37 AM · Restricted Project

Aug 26 2020

darcangelo.matthew added a comment to D86578: [TargetLowering] Combine known bits for icmp in SimplifySetCC (PR41182).

What is the motivation for this patch? The added tests should already get folded before reaching the backend (by InstCombine). We should only add folds to DAGCombine if the folded pattern is created by legalization. What is the original context for this change?

Aug 26 2020, 4:33 PM · Restricted Project
darcangelo.matthew updated the diff for D86578: [TargetLowering] Combine known bits for icmp in SimplifySetCC (PR41182).

Removed mistaken Signed argument

Aug 26 2020, 9:10 AM · Restricted Project

Aug 25 2020

darcangelo.matthew updated the diff for D86578: [TargetLowering] Combine known bits for icmp in SimplifySetCC (PR41182).

Removed the Signed argument from getMinValue

Aug 25 2020, 4:03 PM · Restricted Project
darcangelo.matthew requested review of D86578: [TargetLowering] Combine known bits for icmp in SimplifySetCC (PR41182).
Aug 25 2020, 3:51 PM · Restricted Project