Page MenuHomePhabricator

danielmartin (Daniel Martín)
User

Projects

User does not belong to any projects.

User Details

User Since
May 21 2017, 3:42 PM (207 w, 2 d)

Recent Activity

Oct 25 2020

danielmartin added a comment to D90116: [llvm] CMake: Force MSVC to read code as UTF-8.

Using explicit UTF-8 string literals is a possible solution, but it makes the code a bit less readable. Another possible solution is to save the source file using UTF-8 with BOM, but this is confusing outside the Microsoft world (and it's very easy to remove the BOM by mistake).

Oct 25 2020, 1:51 PM · Restricted Project, Restricted Project

Oct 7 2020

danielmartin added inline comments to D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename..
Oct 7 2020, 2:59 PM · Restricted Project

May 27 2020

danielmartin updated the diff for D80472: [clangd] Add access specifier information to hover contents.

Rebase and squash

May 27 2020, 8:05 AM · Restricted Project

May 26 2020

danielmartin added a comment to D80472: [clangd] Add access specifier information to hover contents.

Thanks for the review! I don't have commit access so I'd need someone to land this patch for me.

May 26 2020, 2:44 PM · Restricted Project
danielmartin updated the diff for D80472: [clangd] Add access specifier information to hover contents.

Address feedback

May 26 2020, 1:38 PM · Restricted Project

May 24 2020

danielmartin updated the diff for D80472: [clangd] Add access specifier information to hover contents.

Move clang::getAccess to Specifiers.h and refactor logic in clang-doc
to use that function instead of its own.

May 24 2020, 2:24 PM · Restricted Project
danielmartin added inline comments to D80472: [clangd] Add access specifier information to hover contents.
May 24 2020, 2:24 PM · Restricted Project

May 23 2020

danielmartin updated the summary of D80472: [clangd] Add access specifier information to hover contents.
May 23 2020, 8:27 AM · Restricted Project
danielmartin created D80472: [clangd] Add access specifier information to hover contents.
May 23 2020, 8:27 AM · Restricted Project

May 9 2018

danielmartin accepted D46499: [Support] Add docs for 'openFileFor{Write,Read}'.

LGTM.

May 9 2018, 8:51 AM

Aug 28 2017

danielmartin updated the diff for D37192: [clang-format] Add support for generic Obj-C categories.

Make comment fit in one line

Aug 28 2017, 12:13 AM

Aug 27 2017

danielmartin created D37192: [clang-format] Add support for generic Obj-C categories.
Aug 27 2017, 5:18 AM