Thank you! Since the documentation shouldn't be available until LLVM 17, I'm slowly working on it. Let me update the PR in this weekend :)

Addressed the remaining comments. Thanks everyone for helping review and improve this patch!

• Address remaining comments

• Fix reversed logic of including inactive region token

Sorry for the inactivity. I have replace the parameter with const ref. By the way, I also removed the existing IncludeInactiveRegionTokens flag and uses this filter instead. Please help review the change. Thanks!

• Address review comment and remove a unnecessary flag

Addressed review comments except for those we don't have an agreement yet.

• Move computeBlockEndHintRange
• Correct label length limit logic
• Correct line number computation for '{'
• Address other review comments

Yeah, makes sense. Thank you for your insight! I missed the fact that this time include AST build time.

I'm not sure but 18ms is definitely wrong here, especially for a debug build. In your log, even semantic highlighting builds in 60ms, which looks incorrect. I tried again with TOT clangd and noticed the following pattern.

• If I scroll with vscode, inlay hints typically computes in 10~20ms
• If I edit the source code, inlay hints computes in around 600ms

In D148489#4362990, @nridge wrote:

(Do you plan to address the last comment before I merge?)

Yes please.

Addressed most review comments.

Address review comments

For a quick peek to the hint:

@zyounan np! Feel free to leave your review comments!

• addressed many review comment

Requesting for some advice

minor naming fix2 (last fix breaks builds)

minor naming fix

Fix format issue

Redo arc as some changes are missing from previous update.

Pass filter by value.

Sorry, I'm a little occupied lately and don't have time to fix the test failure. I'll try to fix that in this week.

In D148489#4276634, @kadircet wrote:

before you dive any deeper into the patch, could you give some reasoning about why this is needed/useful?

Fix an issue where the previous change is lost.

Add a test in SemanticHighlightingTests.cpp

Fix unittest

Please hold off from reviewing this. I have been figuring out how arc tools work and the unittest of the current version is broken.

In D127082#4089377, @nridge wrote:

@daiyousei-qz what is the current status of this patch? Is it ready to be merged again? (If so, I can do that for you.)

In D127082#3776173, @vitalybuka wrote:

Looks like it breaks
https://lab.llvm.org/buildbot/#/builders/236/builds/206
https://lab.llvm.org/buildbot/#/builders/237/builds/85
https://lab.llvm.org/buildbot/#/builders/238/builds/103

In D127082#3770763, @sammccall wrote:

Sorry for the delay :-( This looks great!

It looks like this is your first patch, so you don't have commit access. I can land the patch for you.
Can you provide an email address for attribution?

@sammccall Hello, is there any update required by me?

remove dedicated MacroExpansion variable (reuse Definition)
added empty MACRO test

I have also moved the expansion out of the location checking branch. I think it's to find out if a macro actually has a definition which isn't always the case especially for special macros like __FILE__.

resolve review comment

fix patch context

fix line end to LF

It looks like my inline comment wasn't submitted (didn't click the submit button on the bottom). Here's my old comment.

use a rebased patch

Sorry I'm a little occupied lately.

• add context to patch
• use a fixed size buffer for expansion text

To elaborate on known situation where expansion isn't available:

1. expansion doesn't work on site of #define
2. expansion doesn't work for _Pragma(...) and alike
3. expansion doesn't work with builtin macro
4. expansion doesn't work for macros as arguments of function-like macro

I have a similar change recently presented in https://github.com/clangd/clangd/issues/1181 that makes all conditional preprocessor lines active. Please refer to the change if that's helpful :)

Yes, please do so. I'm using the web interface since the arc tool isn't very friendly to Windows user :(

squashed commits.
updated comments.

added unit test
moved redundant visit