Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

daiyousei-qz (Qingyuan Zheng)
User

Projects

User does not belong to any projects.

User Details

User Since
May 31 2022, 1:44 AM (69 w, 1 d)

Recent Activity

May 26 2023

daiyousei-qz added a comment to D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

Thank you! Since the documentation shouldn't be available until LLVM 17, I'm slowly working on it. Let me update the PR in this weekend :)

May 26 2023, 12:58 AM · Restricted Project, Restricted Project

May 25 2023

daiyousei-qz updated the summary of D150635: [clangd] Implement end-definition-comment inlay hints.
May 25 2023, 11:20 PM · Restricted Project, Restricted Project
daiyousei-qz added inline comments to D151190: [clangd] Do not end inactiveRegions range at position 0 of line.
May 25 2023, 8:16 PM · Restricted Project, Restricted Project
daiyousei-qz added a comment to D150635: [clangd] Implement end-definition-comment inlay hints.

Addressed the remaining comments. Thanks everyone for helping review and improve this patch!

May 25 2023, 8:00 PM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D150635: [clangd] Implement end-definition-comment inlay hints.
  • Address remaining comments
May 25 2023, 7:58 PM · Restricted Project, Restricted Project
daiyousei-qz updated the summary of D150635: [clangd] Implement end-definition-comment inlay hints.
May 25 2023, 7:29 PM · Restricted Project, Restricted Project

May 24 2023

daiyousei-qz updated the diff for D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.
  • Fix reversed logic of including inactive region token
May 24 2023, 11:00 PM · Restricted Project, Restricted Project
daiyousei-qz added inline comments to D150635: [clangd] Implement end-definition-comment inlay hints.
May 24 2023, 10:55 PM · Restricted Project, Restricted Project
daiyousei-qz added a comment to D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

Sorry for the inactivity. I have replace the parameter with const ref. By the way, I also removed the existing IncludeInactiveRegionTokens flag and uses this filter instead. Please help review the change. Thanks!

May 24 2023, 8:32 PM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.
  • Address review comment and remove a unnecessary flag
May 24 2023, 8:30 PM · Restricted Project, Restricted Project
daiyousei-qz added a comment to D150635: [clangd] Implement end-definition-comment inlay hints.

Addressed review comments except for those we don't have an agreement yet.

May 24 2023, 8:17 PM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D150635: [clangd] Implement end-definition-comment inlay hints.
  • Move computeBlockEndHintRange
  • Correct label length limit logic
  • Correct line number computation for '{'
  • Address other review comments
May 24 2023, 8:10 PM · Restricted Project, Restricted Project

May 23 2023

daiyousei-qz added a comment to D150635: [clangd] Implement end-definition-comment inlay hints.

Yeah, makes sense. Thank you for your insight! I missed the fact that this time include AST build time.

May 23 2023, 11:47 PM · Restricted Project, Restricted Project
daiyousei-qz added a comment to D150635: [clangd] Implement end-definition-comment inlay hints.

I'm not sure but 18ms is definitely wrong here, especially for a debug build. In your log, even semantic highlighting builds in 60ms, which looks incorrect. I tried again with TOT clangd and noticed the following pattern.

  • If I scroll with vscode, inlay hints typically computes in 10~20ms
  • If I edit the source code, inlay hints computes in around 600ms
May 23 2023, 8:06 PM · Restricted Project, Restricted Project
daiyousei-qz added inline comments to D150635: [clangd] Implement end-definition-comment inlay hints.
May 23 2023, 1:14 AM · Restricted Project, Restricted Project

May 22 2023

daiyousei-qz added a comment to D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

(Do you plan to address the last comment before I merge?)

May 22 2023, 6:12 PM · Restricted Project, Restricted Project
daiyousei-qz added a reviewer for D150635: [clangd] Implement end-definition-comment inlay hints: zyounan.
May 22 2023, 1:12 AM · Restricted Project, Restricted Project
daiyousei-qz added a comment to D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

Yes please.

May 22 2023, 1:03 AM · Restricted Project, Restricted Project
daiyousei-qz added a comment to D150635: [clangd] Implement end-definition-comment inlay hints.

Addressed most review comments.

May 22 2023, 12:59 AM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D150635: [clangd] Implement end-definition-comment inlay hints.

Address review comments

May 22 2023, 12:56 AM · Restricted Project, Restricted Project

May 16 2023

daiyousei-qz added a comment to D150635: [clangd] Implement end-definition-comment inlay hints.

For a quick peek to the hint:

May 16 2023, 10:54 PM · Restricted Project, Restricted Project
daiyousei-qz added a comment to D150635: [clangd] Implement end-definition-comment inlay hints.

@zyounan np! Feel free to leave your review comments!

May 16 2023, 10:45 PM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D150635: [clangd] Implement end-definition-comment inlay hints.
  • addressed many review comment
May 16 2023, 10:39 PM · Restricted Project, Restricted Project

May 15 2023

daiyousei-qz updated the summary of D150635: [clangd] Implement end-definition-comment inlay hints.
May 15 2023, 10:21 PM · Restricted Project, Restricted Project
daiyousei-qz added a comment to D150635: [clangd] Implement end-definition-comment inlay hints.

Requesting for some advice

May 15 2023, 10:20 PM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D150635: [clangd] Implement end-definition-comment inlay hints.

minor naming fix2 (last fix breaks builds)

May 15 2023, 10:16 PM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D150635: [clangd] Implement end-definition-comment inlay hints.

minor naming fix

May 15 2023, 10:14 PM · Restricted Project, Restricted Project
daiyousei-qz updated the summary of D150635: [clangd] Implement end-definition-comment inlay hints.
May 15 2023, 10:07 PM · Restricted Project, Restricted Project
daiyousei-qz requested review of D150635: [clangd] Implement end-definition-comment inlay hints.
May 15 2023, 10:01 PM · Restricted Project, Restricted Project

May 14 2023

daiyousei-qz updated the diff for D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

Fix format issue

May 14 2023, 12:29 AM · Restricted Project, Restricted Project

May 13 2023

daiyousei-qz updated the diff for D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

Redo arc as some changes are missing from previous update.

May 13 2023, 10:12 PM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

Pass filter by value.

May 13 2023, 10:07 PM · Restricted Project, Restricted Project

May 8 2023

daiyousei-qz added a comment to D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

Sorry, I'm a little occupied lately and don't have time to fix the test failure. I'll try to fix that in this week.

May 8 2023, 10:59 PM · Restricted Project, Restricted Project

Apr 17 2023

daiyousei-qz added a comment to D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

before you dive any deeper into the patch, could you give some reasoning about why this is needed/useful?

Apr 17 2023, 11:56 PM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.
Add some comments to the config headers. Resubmit to retrigger build test since I cannot reproduce the failure.
Apr 17 2023, 11:40 PM · Restricted Project, Restricted Project

Apr 16 2023

daiyousei-qz added inline comments to D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.
Apr 16 2023, 9:04 PM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

Fix an issue where the previous change is lost.

Apr 16 2023, 9:03 PM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

Add a test in SemanticHighlightingTests.cpp

Apr 16 2023, 9:02 PM · Restricted Project, Restricted Project
daiyousei-qz updated the diff for D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

Fix unittest

Apr 16 2023, 8:39 PM · Restricted Project, Restricted Project
daiyousei-qz added a comment to D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.

Please hold off from reviewing this. I have been figuring out how arc tools work and the unittest of the current version is broken.

Apr 16 2023, 8:35 PM · Restricted Project, Restricted Project
daiyousei-qz retitled D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens from Implement configs to stop clangd produce a certain semantic tokens to [clangd] Implement configs to stop clangd produce a certain semantic tokens.
Apr 16 2023, 8:21 PM · Restricted Project, Restricted Project
daiyousei-qz requested review of D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens.
Apr 16 2023, 8:18 PM · Restricted Project, Restricted Project

Feb 2 2023

daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.

@daiyousei-qz what is the current status of this patch? Is it ready to be merged again? (If so, I can do that for you.)

Feb 2 2023, 5:02 PM · Restricted Project, Restricted Project, Restricted Project

Oct 15 2022

daiyousei-qz retitled D136033: [clangd] Add an option to specify a workspece-level config file from Add an option to specify a workspece-level config file to [clangd] Add an option to specify a workspece-level config file.
Oct 15 2022, 10:06 PM · Restricted Project, Restricted Project
daiyousei-qz requested review of D136033: [clangd] Add an option to specify a workspece-level config file.
Oct 15 2022, 10:06 PM · Restricted Project, Restricted Project

Sep 7 2022

daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.
Sep 7 2022, 8:04 PM · Restricted Project, Restricted Project, Restricted Project

Sep 5 2022

daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.

Sorry for the delay :-( This looks great!

It looks like this is your first patch, so you don't have commit access. I can land the patch for you.
Can you provide an email address for attribution?

Sep 5 2022, 6:00 PM · Restricted Project, Restricted Project, Restricted Project

Aug 25 2022

daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.

@sammccall Hello, is there any update required by me?

Aug 25 2022, 12:15 AM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2022

daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.

remove dedicated MacroExpansion variable (reuse Definition)
added empty MACRO test

Jul 27 2022, 2:18 AM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2022

daiyousei-qz added inline comments to D127082: [clangd] Add Macro Expansion to Hover.
Jul 19 2022, 11:58 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.

I have also moved the expansion out of the location checking branch. I think it's to find out if a macro actually has a definition which isn't always the case especially for special macros like __FILE__.

Jul 19 2022, 10:18 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.

resolve review comment

Jul 19 2022, 10:08 PM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2022

daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
Jul 12 2022, 10:49 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.

fix patch context

Jul 12 2022, 10:42 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.

fix line end to LF

Jul 12 2022, 10:35 PM · Restricted Project, Restricted Project, Restricted Project

Jul 5 2022

daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.

It looks like my inline comment wasn't submitted (didn't click the submit button on the bottom). Here's my old comment.

Jul 5 2022, 5:32 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
Jul 5 2022, 5:28 PM · Restricted Project, Restricted Project, Restricted Project

Jul 2 2022

daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
Jul 2 2022, 7:58 PM · Restricted Project, Restricted Project, Restricted Project

Jun 23 2022

daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
Jun 23 2022, 6:50 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
Jun 23 2022, 6:43 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.

use a rebased patch

Jun 23 2022, 6:34 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.

Sorry I'm a little occupied lately.

Jun 23 2022, 6:31 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
  • add context to patch
  • use a fixed size buffer for expansion text
Jun 23 2022, 6:24 PM · Restricted Project, Restricted Project, Restricted Project

Jun 6 2022

daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.

To elaborate on known situation where expansion isn't available:

  1. expansion doesn't work on site of #define
  2. expansion doesn't work for _Pragma(...) and alike
  3. expansion doesn't work with builtin macro
  4. expansion doesn't work for macros as arguments of function-like macro
Jun 6 2022, 9:08 AM · Restricted Project, Restricted Project, Restricted Project

Jun 5 2022

daiyousei-qz added a comment to D125863: [clangd] Dont mark terminating PP-directives as skipped.

I have a similar change recently presented in https://github.com/clangd/clangd/issues/1181 that makes all conditional preprocessor lines active. Please refer to the change if that's helpful :)

Jun 5 2022, 11:53 PM · Restricted Project, Restricted Project
daiyousei-qz added a comment to D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.

Yes, please do so. I'm using the web interface since the arc tool isn't very friendly to Windows user :(

Jun 5 2022, 11:31 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz retitled D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl from Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl to [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.
Jun 5 2022, 10:03 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz retitled D127082: [clangd] Add Macro Expansion to Hover from Add Macro Expansion to Hover to [clangd] Add Macro Expansion to Hover.
Jun 5 2022, 10:03 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the summary of D127082: [clangd] Add Macro Expansion to Hover.
Jun 5 2022, 9:14 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz requested review of D127082: [clangd] Add Macro Expansion to Hover.
Jun 5 2022, 9:12 PM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2022

daiyousei-qz updated the diff for D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.

squashed commits.
updated comments.

Jun 3 2022, 4:17 PM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2022

daiyousei-qz updated the diff for D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.

added unit test
moved redundant visit

Jun 1 2022, 4:47 PM · Restricted Project, Restricted Project, Restricted Project

May 31 2022

daiyousei-qz requested review of D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.
May 31 2022, 11:35 PM · Restricted Project, Restricted Project, Restricted Project