User Details
- User Since
- May 31 2022, 1:44 AM (69 w, 1 d)
May 26 2023
Thank you! Since the documentation shouldn't be available until LLVM 17, I'm slowly working on it. Let me update the PR in this weekend :)
May 25 2023
Addressed the remaining comments. Thanks everyone for helping review and improve this patch!
- Address remaining comments
May 24 2023
- Fix reversed logic of including inactive region token
Sorry for the inactivity. I have replace the parameter with const ref. By the way, I also removed the existing IncludeInactiveRegionTokens flag and uses this filter instead. Please help review the change. Thanks!
- Address review comment and remove a unnecessary flag
Addressed review comments except for those we don't have an agreement yet.
- Move computeBlockEndHintRange
- Correct label length limit logic
- Correct line number computation for '{'
- Address other review comments
May 23 2023
Yeah, makes sense. Thank you for your insight! I missed the fact that this time include AST build time.
I'm not sure but 18ms is definitely wrong here, especially for a debug build. In your log, even semantic highlighting builds in 60ms, which looks incorrect. I tried again with TOT clangd and noticed the following pattern.
- If I scroll with vscode, inlay hints typically computes in 10~20ms
- If I edit the source code, inlay hints computes in around 600ms
May 22 2023
Yes please.
Addressed most review comments.
Address review comments
May 16 2023
For a quick peek to the hint:
@zyounan np! Feel free to leave your review comments!
- addressed many review comment
May 15 2023
Requesting for some advice
minor naming fix2 (last fix breaks builds)
minor naming fix
May 14 2023
Fix format issue
May 13 2023
Redo arc as some changes are missing from previous update.
Pass filter by value.
May 8 2023
Sorry, I'm a little occupied lately and don't have time to fix the test failure. I'll try to fix that in this week.
Apr 17 2023
Add some comments to the config headers. Resubmit to retrigger build test since I cannot reproduce the failure.
Apr 16 2023
Fix an issue where the previous change is lost.
Add a test in SemanticHighlightingTests.cpp
Fix unittest
Please hold off from reviewing this. I have been figuring out how arc tools work and the unittest of the current version is broken.
Feb 2 2023
Oct 15 2022
Sep 7 2022
Sep 5 2022
Aug 25 2022
@sammccall Hello, is there any update required by me?
Jul 27 2022
remove dedicated MacroExpansion variable (reuse Definition)
added empty MACRO test
Jul 19 2022
I have also moved the expansion out of the location checking branch. I think it's to find out if a macro actually has a definition which isn't always the case especially for special macros like __FILE__.
resolve review comment
Jul 12 2022
fix patch context
fix line end to LF
Jul 5 2022
It looks like my inline comment wasn't submitted (didn't click the submit button on the bottom). Here's my old comment.
Jul 2 2022
Jun 23 2022
use a rebased patch
Sorry I'm a little occupied lately.
- add context to patch
- use a fixed size buffer for expansion text
Jun 6 2022
To elaborate on known situation where expansion isn't available:
- expansion doesn't work on site of #define
- expansion doesn't work for _Pragma(...) and alike
- expansion doesn't work with builtin macro
- expansion doesn't work for macros as arguments of function-like macro
Jun 5 2022
I have a similar change recently presented in https://github.com/clangd/clangd/issues/1181 that makes all conditional preprocessor lines active. Please refer to the change if that's helpful :)
Yes, please do so. I'm using the web interface since the arc tool isn't very friendly to Windows user :(
Jun 3 2022
squashed commits.
updated comments.
Jun 1 2022
added unit test
moved redundant visit