Page MenuHomePhabricator

daiyousei-qz (Qingyuan Zheng)
User

Projects

User does not belong to any projects.

User Details

User Since
May 31 2022, 1:44 AM (10 w, 2 d)

Recent Activity

Wed, Jul 27

daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.

remove dedicated MacroExpansion variable (reuse Definition)
added empty MACRO test

Wed, Jul 27, 2:18 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 19

daiyousei-qz added inline comments to D127082: [clangd] Add Macro Expansion to Hover.
Tue, Jul 19, 11:58 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.

I have also moved the expansion out of the location checking branch. I think it's to find out if a macro actually has a definition which isn't always the case especially for special macros like __FILE__.

Tue, Jul 19, 10:18 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.

resolve review comment

Tue, Jul 19, 10:08 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 12

daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
Tue, Jul 12, 10:49 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.

fix patch context

Tue, Jul 12, 10:42 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.

fix line end to LF

Tue, Jul 12, 10:35 PM · Restricted Project, Restricted Project, Restricted Project

Jul 5 2022

daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.

It looks like my inline comment wasn't submitted (didn't click the submit button on the bottom). Here's my old comment.

Jul 5 2022, 5:32 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
Jul 5 2022, 5:28 PM · Restricted Project, Restricted Project, Restricted Project

Jul 2 2022

daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
Jul 2 2022, 7:58 PM · Restricted Project, Restricted Project, Restricted Project

Jun 23 2022

daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
Jun 23 2022, 6:50 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
Jun 23 2022, 6:43 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.

use a rebased patch

Jun 23 2022, 6:34 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.

Sorry I'm a little occupied lately.

Jun 23 2022, 6:31 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the diff for D127082: [clangd] Add Macro Expansion to Hover.
  • add context to patch
  • use a fixed size buffer for expansion text
Jun 23 2022, 6:24 PM · Restricted Project, Restricted Project, Restricted Project

Jun 6 2022

daiyousei-qz added a comment to D127082: [clangd] Add Macro Expansion to Hover.

To elaborate on known situation where expansion isn't available:

  1. expansion doesn't work on site of #define
  2. expansion doesn't work for _Pragma(...) and alike
  3. expansion doesn't work with builtin macro
  4. expansion doesn't work for macros as arguments of function-like macro
Jun 6 2022, 9:08 AM · Restricted Project, Restricted Project, Restricted Project

Jun 5 2022

daiyousei-qz added a comment to D125863: [clangd] Dont mark terminating PP-directives as skipped.

I have a similar change recently presented in https://github.com/clangd/clangd/issues/1181 that makes all conditional preprocessor lines active. Please refer to the change if that's helpful :)

Jun 5 2022, 11:53 PM · Restricted Project, Restricted Project
daiyousei-qz added a comment to D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.

Yes, please do so. I'm using the web interface since the arc tool isn't very friendly to Windows user :(

Jun 5 2022, 11:31 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz retitled D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl from Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl to [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.
Jun 5 2022, 10:03 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz retitled D127082: [clangd] Add Macro Expansion to Hover from Add Macro Expansion to Hover to [clangd] Add Macro Expansion to Hover.
Jun 5 2022, 10:03 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz updated the summary of D127082: [clangd] Add Macro Expansion to Hover.
Jun 5 2022, 9:14 PM · Restricted Project, Restricted Project, Restricted Project
daiyousei-qz requested review of D127082: [clangd] Add Macro Expansion to Hover.
Jun 5 2022, 9:12 PM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2022

daiyousei-qz updated the diff for D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.

squashed commits.
updated comments.

Jun 3 2022, 4:17 PM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2022

daiyousei-qz updated the diff for D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.

added unit test
moved redundant visit

Jun 1 2022, 4:47 PM · Restricted Project, Restricted Project, Restricted Project

May 31 2022

daiyousei-qz requested review of D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.
May 31 2022, 11:35 PM · Restricted Project, Restricted Project, Restricted Project