Page MenuHomePhabricator

d-e-s-o (Daniel Müller)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 1 2022, 4:22 PM (9 w, 5 d)

Recent Activity

Jun 2 2022

d-e-s-o added inline comments to D126838: [BPF] Introduce support for type match relocations.
Jun 2 2022, 3:21 PM · Restricted Project, Restricted Project
d-e-s-o updated the diff for D126838: [BPF] Introduce support for type match relocations.

Addressed Yonghong's comment and regenerated IR. Thanks for the review!

Jun 2 2022, 3:20 PM · Restricted Project, Restricted Project
d-e-s-o added a comment to D126839: [clang][BPF] Update comment to include TYPE_MATCH.

Also let us merge it unti kernel side change is in reasonable shape.

From what I understand it may take several days or some other not-precisely specified time until "nightly" builds, which we use in the BPF CI, pick up the change. Hence, I was under the impression that we should attempt to merge it sooner rather than later once it's ready to be merged. The kernel changes are in good enough shape to show feasibility, so I don't really see why not, but it's your call.

We can merge after the new mechanism is acked (not patch getting merged) in kernel review.

Jun 2 2022, 2:30 PM · Restricted Project, Restricted Project
d-e-s-o added a comment to D126839: [clang][BPF] Update comment to include TYPE_MATCH.

Also let us merge it unti kernel side change is in reasonable shape.

From what I understand it may take several days or some other not-precisely specified time until "nightly" builds, which we use in the BPF CI, pick up the change. Hence, I was under the impression that we should attempt to merge it sooner rather than later once it's ready to be merged. The kernel changes are in good enough shape to show feasibility, so I don't really see why not, but it's your call.

Jun 2 2022, 2:30 PM · Restricted Project, Restricted Project
d-e-s-o added a comment to D126839: [clang][BPF] Update comment to include TYPE_MATCH.

Also let us merge it unti kernel side change is in reasonable shape.

Jun 2 2022, 1:34 PM · Restricted Project, Restricted Project
d-e-s-o added a comment to D126839: [clang][BPF] Update comment to include TYPE_MATCH.

LGTM. But add the reference (https://reviews.llvm.org/D126838) to the commit message to indicate which 'earlier change'. Also let us merge it unti kernel side change is in reasonable shape.

Jun 2 2022, 1:27 PM · Restricted Project, Restricted Project
d-e-s-o updated the summary of D126839: [clang][BPF] Update comment to include TYPE_MATCH.
Jun 2 2022, 1:26 PM · Restricted Project, Restricted Project
d-e-s-o changed the edit policy for D126839: [clang][BPF] Update comment to include TYPE_MATCH.
Jun 2 2022, 1:24 PM · Restricted Project, Restricted Project
d-e-s-o changed the edit policy for D126838: [BPF] Introduce support for type match relocations.
Jun 2 2022, 1:23 PM · Restricted Project, Restricted Project
d-e-s-o updated subscribers of D126838: [BPF] Introduce support for type match relocations.
Jun 2 2022, 7:50 AM · Restricted Project, Restricted Project
d-e-s-o changed the visibility for D126839: [clang][BPF] Update comment to include TYPE_MATCH.
Jun 2 2022, 7:41 AM · Restricted Project, Restricted Project
d-e-s-o changed the visibility for D126838: [BPF] Introduce support for type match relocations.
Jun 2 2022, 7:41 AM · Restricted Project, Restricted Project

Jun 1 2022

d-e-s-o added inline comments to D126838: [BPF] Introduce support for type match relocations.
Jun 1 2022, 4:57 PM · Restricted Project, Restricted Project
d-e-s-o changed the visibility for D126838: [BPF] Introduce support for type match relocations.
Jun 1 2022, 4:56 PM · Restricted Project, Restricted Project
d-e-s-o changed the visibility for D126839: [clang][BPF] Update comment to include TYPE_MATCH.
Jun 1 2022, 4:55 PM · Restricted Project, Restricted Project
d-e-s-o requested review of D126839: [clang][BPF] Update comment to include TYPE_MATCH.
Jun 1 2022, 4:46 PM · Restricted Project, Restricted Project
d-e-s-o requested review of D126838: [BPF] Introduce support for type match relocations.
Jun 1 2022, 4:40 PM · Restricted Project, Restricted Project