In D109557#3247167, @HazardyKnusperkeks wrote:

Could you please rebase the patch? I promise I will commit it very shortly afterwards.

Is there anything outstanding you'd like me to address, or can we move ahead with committing this?

I don't have commit access, so please submit this change on my behalf.

Any further feedback on the latest iteration?

Absent feedback, I have gone ahead and added a BlockIndent option to AlignAfterOpenBracket.

In D109557#3063679, @MyDeveloperDay wrote:

Do you think this is going to need some other capability to put the break after the opening paren? e.g. BreakAfterOpeningParen

if (
    ^

In D109557#3063563, @MyDeveloperDay wrote:

The you quoted would, in my mind, be formatted like this:

void foo() {
    if (
        quitelongarg != (alsolongarg - 1)
    ) { // ABC is a very longgggggggggggg comment
        return;
    }
}

This is because I don't allow breaking the closing paren without breaking after the opening paren, but this might be only my own style.

Yes, this is not what you are going to get with this revision, we need to decide if that is what is expected

In D109557#3019847, @MyDeveloperDay wrote:

We would need your name and email address to commit this for you in the form git commit --amend --author="John Doe <jdoe@llvm.org>"

See https://llvm.org/docs/DeveloperPolicy.html

In D109557#3011516, @MyDeveloperDay wrote:

This seems ok, might be worth adding a release note

In D109557#3000152, @HazardyKnusperkeks wrote:

I haven't looked too much into it, my main point is that there should be tests for both variants of that option for braces, parenthesis, and angular braces, if they are handled by that option. Otherwise the documentation (and naming?) should be adapted. If the defaults differ, the option has to be reworked, for a finer control.

In D109557#2998213, @HazardyKnusperkeks wrote:

With context he meant the diff context. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Adds more context to the diff.

I've added more information to my original message. Please let me know if further context is desired.