Page MenuHomePhabricator

csmulhern (Cameron Mulhern)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 9 2021, 5:32 PM (5 w, 5 d)

Recent Activity

Sun, Oct 17

maksim awarded D109557: Adds a BreakBeforeClosingParen option a Love token.
Sun, Oct 17, 5:45 AM · Restricted Project, Restricted Project

Fri, Oct 15

csmulhern added a comment to D109557: Adds a BreakBeforeClosingParen option.

Do you think this is going to need some other capability to put the break after the opening paren? e.g. BreakAfterOpeningParen

if (
    ^
Fri, Oct 15, 7:45 AM · Restricted Project, Restricted Project

Thu, Oct 14

xgupta awarded D109557: Adds a BreakBeforeClosingParen option a Pterodactyl token.
Thu, Oct 14, 10:22 PM · Restricted Project, Restricted Project
jeevcat awarded D109557: Adds a BreakBeforeClosingParen option a Like token.
Thu, Oct 14, 9:26 PM · Restricted Project, Restricted Project
fdwr awarded D109557: Adds a BreakBeforeClosingParen option a Love token.
Thu, Oct 14, 10:49 AM · Restricted Project, Restricted Project
reupen awarded D109557: Adds a BreakBeforeClosingParen option a Like token.
Thu, Oct 14, 4:52 AM · Restricted Project, Restricted Project
csmulhern added a comment to D109557: Adds a BreakBeforeClosingParen option.

The you quoted would, in my mind, be formatted like this:

void foo() {
    if (
        quitelongarg != (alsolongarg - 1)
    ) { // ABC is a very longgggggggggggg comment
        return;
    }
}

This is because I don't allow breaking the closing paren without breaking after the opening paren, but this might be only my own style.

Yes, this is not what you are going to get with this revision, we need to decide if that is what is expected

Thu, Oct 14, 4:24 AM · Restricted Project, Restricted Project
kring awarded D109557: Adds a BreakBeforeClosingParen option a Love token.
Thu, Oct 14, 3:25 AM · Restricted Project, Restricted Project

Fri, Sep 24

csmulhern added a comment to D109557: Adds a BreakBeforeClosingParen option.

We would need your name and email address to commit this for you in the form git commit --amend --author="John Doe <jdoe@llvm.org>"

See https://llvm.org/docs/DeveloperPolicy.html

Fri, Sep 24, 3:49 AM · Restricted Project, Restricted Project

Tue, Sep 21

csmulhern added a comment to D109557: Adds a BreakBeforeClosingParen option.

This seems ok, might be worth adding a release note

Tue, Sep 21, 5:40 AM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BreakBeforeClosingParen option.
Tue, Sep 21, 5:39 AM · Restricted Project, Restricted Project

Mon, Sep 20

csmulhern added inline comments to D109557: Adds a BreakBeforeClosingParen option.
Mon, Sep 20, 2:26 PM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BreakBeforeClosingParen option.
Mon, Sep 20, 2:26 PM · Restricted Project, Restricted Project

Sep 18 2021

csmulhern added inline comments to D109557: Adds a BreakBeforeClosingParen option.
Sep 18 2021, 7:17 AM · Restricted Project, Restricted Project

Sep 16 2021

csmulhern added inline comments to D109557: Adds a BreakBeforeClosingParen option.
Sep 16 2021, 9:43 AM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BreakBeforeClosingParen option.
Sep 16 2021, 9:43 AM · Restricted Project, Restricted Project

Sep 15 2021

csmulhern added inline comments to D109557: Adds a BreakBeforeClosingParen option.
Sep 15 2021, 4:07 PM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BreakBeforeClosingParen option.
Sep 15 2021, 4:07 PM · Restricted Project, Restricted Project
csmulhern added a comment to D109557: Adds a BreakBeforeClosingParen option.

I haven't looked too much into it, my main point is that there should be tests for both variants of that option for braces, parenthesis, and angular braces, if they are handled by that option. Otherwise the documentation (and naming?) should be adapted. If the defaults differ, the option has to be reworked, for a finer control.

Sep 15 2021, 10:43 AM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BreakBeforeClosingParen option.
Sep 15 2021, 10:40 AM · Restricted Project, Restricted Project

Sep 13 2021

csmulhern added a comment to D109557: Adds a BreakBeforeClosingParen option.
Sep 13 2021, 4:38 PM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BreakBeforeClosingParen option.

Adds more context to the diff.

Sep 13 2021, 4:27 PM · Restricted Project, Restricted Project
csmulhern added a comment to D109557: Adds a BreakBeforeClosingParen option.

I've added more information to my original message. Please let me know if further context is desired.

Sep 13 2021, 10:08 AM · Restricted Project, Restricted Project
csmulhern updated the summary of D109557: Adds a BreakBeforeClosingParen option.
Sep 13 2021, 10:07 AM · Restricted Project, Restricted Project

Sep 9 2021

csmulhern requested review of D109557: Adds a BreakBeforeClosingParen option.
Sep 9 2021, 5:37 PM · Restricted Project, Restricted Project