Page MenuHomePhabricator

cs15btech11041 (ADIL ARUN DANGUI)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2017, 9:19 AM (291 w, 2 d)

Recent Activity

Jan 2 2018

cs15btech11041 updated the diff for D41659: Implementing missing trigonometric optimizations.

Added the right file for sin_div_tan.ll test case (incorrect was added in previous commit).

Jan 2 2018, 10:46 PM
cs15btech11041 added a comment to D41659: Implementing missing trigonometric optimizations.

Meta point: It's unclear to me whether this is something profitable to implement.
Sure, you can probably take a textbook and implement all the possible identities written there, but, what's the point?

I looked and it seems other compilers (most notably, GCC) don't implement at least the first transformation you implemented (I didn't bother to check the others).
https://godbolt.org/g/kKP5PW

tl;dr: what's your motivation?

Jan 2 2018, 9:33 PM
cs15btech11041 added a comment to D41659: Implementing missing trigonometric optimizations.

This may need special guard with fast-math flags (precision, etc), no?

Jan 2 2018, 9:22 PM
cs15btech11041 added a comment to D41659: Implementing missing trigonometric optimizations.

Thanks for your patch!

Usually it is easier to review smaller patches. Splitting it up into 4 patches for the 4 different cases you implemented would make it slightly easier to reason about the 4 unrelated transformation in isolation.

Jan 2 2018, 9:16 PM
cs15btech11041 added a comment to D41659: Implementing missing trigonometric optimizations.
In D41659#965688, @asb wrote:

As mentioned in llvm-dev, it looks like David Majnemer and Craig Topper might be appropriate reviewers for this patch (or can perhaps help to suggest other reviewers).

Hi, thanks for the comment. Thanks for adding appropriate reviewers for the patch.

Jan 2 2018, 9:14 PM
cs15btech11041 updated the diff for D41659: Implementing missing trigonometric optimizations.

Updates made:

Jan 2 2018, 9:11 PM
cs15btech11041 created D41659: Implementing missing trigonometric optimizations.
Jan 2 2018, 12:53 AM