Page MenuHomePhabricator

cpillmayer (Christoph Pillmayer)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2022, 11:50 AM (10 w, 5 d)

Recent Activity

Apr 23 2022

cpillmayer added a comment to D124048: [MLIR] Add option to print users of an operation as comment in the printer.

I don't have commit access, so it would be great if you could land the patch for me. Please use "Christoph Pillmayer cpillmayer@gmail.com" for the commit.

Sorry, I applied the patch with arc and forgot to check that the name was right, it appears as Author: cpillmayer <cpillmayer@gmail.com>, hopefully this is good enough?

Apr 23 2022, 12:40 AM · Restricted Project, Restricted Project

Apr 22 2022

cpillmayer added a comment to D124048: [MLIR] Add option to print users of an operation as comment in the printer.

LGTM!
Do you have commit access?

Apr 22 2022, 11:10 AM · Restricted Project, Restricted Project
cpillmayer updated the diff for D124048: [MLIR] Add option to print users of an operation as comment in the printer.

Address comments

Apr 22 2022, 8:53 AM · Restricted Project, Restricted Project
cpillmayer added inline comments to D124048: [MLIR] Add option to print users of an operation as comment in the printer.
Apr 22 2022, 8:52 AM · Restricted Project, Restricted Project

Apr 21 2022

cpillmayer added a comment to D124048: [MLIR] Add option to print users of an operation as comment in the printer.

I patched MLIR for this:
...

Apr 21 2022, 11:23 AM · Restricted Project, Restricted Project
cpillmayer updated the diff for D124048: [MLIR] Add option to print users of an operation as comment in the printer.

Address comments

  • Add tests
  • Add grouping of users based on results
  • Improve printing of BlockArgument users
Apr 21 2022, 11:15 AM · Restricted Project, Restricted Project

Apr 20 2022

cpillmayer added inline comments to D124048: [MLIR] Add option to print users of an operation as comment in the printer.
Apr 20 2022, 1:10 PM · Restricted Project, Restricted Project
cpillmayer requested review of D124048: [MLIR] Add option to print users of an operation as comment in the printer.

Slightly more elaborated:

$ ./bin/mlir-opt /tmp/test.mlir -mlir-print-operation-users
module {
  func @pretty_names(%arg0: i32, %arg1: i32) {
    // %arg0 // users: %q_2, %q
    // %arg1 // users: %q_6, %q_2
    %c0_i32 = arith.constant 0 : i32 // users: %q
    %q, %q_0, %q_1, %r = "test.custom_result_name"(%c0_i32, %c0_i32, %c0_i32, %arg0) {names = ["q", "q", "q", "r"]} : (i32, i32, i32, i32) -> (i32, i32, i32, i32) // users: %q_6, %q_2
    %q_2, %q_3, %q_4, %r_5 = "test.custom_result_name"(%q_0, %q, %arg1, %arg0) {names = ["q", "q", "q", "r"]} : (i32, i32, i32, i32) -> (i32, i32, i32, i32) // users: %q_6
    %q_6, %q_7, %q_8, %r_9 = "test.custom_result_name"(%q, %r_5, %q_2, %arg1) {names = ["q", "q", "q", "r"]} : (i32, i32, i32, i32) -> (i32, i32, i32, i32)
    return
  }
}
Apr 20 2022, 12:08 PM · Restricted Project, Restricted Project
cpillmayer added inline comments to D124048: [MLIR] Add option to print users of an operation as comment in the printer.
Apr 20 2022, 11:41 AM · Restricted Project, Restricted Project
cpillmayer planned changes to D124048: [MLIR] Add option to print users of an operation as comment in the printer.
Apr 20 2022, 11:32 AM · Restricted Project, Restricted Project
cpillmayer updated the diff for D124048: [MLIR] Add option to print users of an operation as comment in the printer.

Address part of comments

Apr 20 2022, 11:32 AM · Restricted Project, Restricted Project

Apr 19 2022

cpillmayer added reviewers for D124048: [MLIR] Add option to print users of an operation as comment in the printer: jpienaar, Mogball, mehdi_amini.
Apr 19 2022, 3:32 PM · Restricted Project, Restricted Project
cpillmayer requested review of D124048: [MLIR] Add option to print users of an operation as comment in the printer.
Apr 19 2022, 3:28 PM · Restricted Project, Restricted Project

Apr 18 2022

cpillmayer requested review of D123960: [AsmWriter] Add option to print users of an operation as a comment.
Apr 18 2022, 2:22 PM · Restricted Project, Restricted Project
cpillmayer abandoned D123959: [mlir][core] Add option to print users of an operation as a comment.
Apr 18 2022, 2:17 PM · Restricted Project, Restricted Project
cpillmayer added a comment to D123959: [mlir][core] Add option to print users of an operation as a comment.

There may be some confusion happening here. It looks like you intended to add support for MLIR (given the commit title and bug reference), but the files in this commit are adding support to LLVM instead. MLIR and LLVM have different underlying infrastructure. (though this may still be a welcome addition for LLVM users)

Apr 18 2022, 1:52 PM · Restricted Project, Restricted Project
cpillmayer requested review of D123959: [mlir][core] Add option to print users of an operation as a comment.
Apr 18 2022, 1:28 PM · Restricted Project, Restricted Project