Page MenuHomePhabricator

coti (Camille Coti)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 12:16 PM (13 w, 2 d)

Recent Activity

Aug 24 2020

coti updated the diff for D84334: [flang] Version information in flang/f18.

Fixed the include paths. Thank you @richard.barton.arm!

Aug 24 2020, 9:20 AM · Restricted Project, Restricted Project
coti updated the diff for D84334: [flang] Version information in flang/f18.

On a clean tree, with the attached patch, I get:

[ 90%] Built target f18
[ 90%] Generating /__fortran_builtins.mod
Enter Fortran source
Use EOF character (^D) to end file
Aug 24 2020, 3:51 AM · Restricted Project, Restricted Project

Aug 14 2020

coti added a comment to D84334: [flang] Version information in flang/f18.

On a clean build, with:

Aug 14 2020, 12:15 PM · Restricted Project, Restricted Project

Aug 13 2020

coti added a comment to D84334: [flang] Version information in flang/f18.

Actually, I cannot find a way to make it work with target_include_directories on a clean build tree.

Aug 13 2020, 6:57 PM · Restricted Project, Restricted Project
coti updated the diff for D84334: [flang] Version information in flang/f18.

Followed @DavidTruby's recommendation on how include directories are set by CMake.

Aug 13 2020, 12:19 PM · Restricted Project, Restricted Project
coti updated the diff for D84334: [flang] Version information in flang/f18.
Aug 13 2020, 12:17 PM · Restricted Project, Restricted Project

Aug 12 2020

coti added a comment to D84334: [flang] Version information in flang/f18.

@DavidTruby so, how about replacing:

Aug 12 2020, 5:11 PM · Restricted Project, Restricted Project
coti updated the diff for D84334: [flang] Version information in flang/f18.

Typo in a comment.

Aug 12 2020, 11:20 AM · Restricted Project, Restricted Project
coti updated the diff for D84334: [flang] Version information in flang/f18.

Added include ${CMAKE_CURRENT_BINARY_DIR}, as suggested by @isuruf. I tested it on a clean tree, it seems to work.

Aug 12 2020, 11:19 AM · Restricted Project, Restricted Project

Aug 10 2020

coti added a comment to D84334: [flang] Version information in flang/f18.

yes ;)

Aug 10 2020, 6:24 AM · Restricted Project, Restricted Project
coti updated the diff for D84334: [flang] Version information in flang/f18.

Outch, sorry :(
I create my patches with git diff....

Aug 10 2020, 6:00 AM · Restricted Project, Restricted Project

Aug 7 2020

coti updated the diff for D84334: [flang] Version information in flang/f18.

I generated the diff again on a clean clone. I don't know why but my CMakeList.txt was wrong even after a git stash. Sorry about that, I hope it should be fine now.

Aug 7 2020, 12:55 PM · Restricted Project, Restricted Project
coti updated the diff for D84334: [flang] Version information in flang/f18.

Updated my local clone, fixed the conflicts and re-generated the diff.

Aug 7 2020, 10:08 AM · Restricted Project, Restricted Project
coti added a comment to D84334: [flang] Version information in flang/f18.

No, I don't ;)

Aug 7 2020, 9:23 AM · Restricted Project, Restricted Project

Aug 5 2020

coti updated the diff for D84334: [flang] Version information in flang/f18.

Thank you @tskeith for the tip on the tests!

Aug 5 2020, 4:22 PM · Restricted Project, Restricted Project
coti updated the diff for D84334: [flang] Version information in flang/f18.

All the comments should be addressed:

  • renamed the test for pre-processor macros compiler_defined_macros.F90
  • removed __flang_version__ (in f18.cpp and in the tests)
  • use %f18 -E in the pre-processor test in order to avoid a full compilation
Aug 5 2020, 3:06 PM · Restricted Project, Restricted Project

Aug 4 2020

coti updated the diff for D84334: [flang] Version information in flang/f18.

Some tests for the -v flag and associated macros.

Aug 4 2020, 6:13 PM · Restricted Project, Restricted Project
coti added a comment to D84334: [flang] Version information in flang/f18.

I am writing the tests.

Aug 4 2020, 3:06 PM · Restricted Project, Restricted Project

Jul 30 2020

coti updated the diff for D84334: [flang] Version information in flang/f18.

Use CMAKE_CURRENT_BINARY_DIR as the target directory of the geneated .h file, as suggested by @isuruf

Jul 30 2020, 11:38 AM · Restricted Project, Restricted Project
coti updated the diff for D84334: [flang] Version information in flang/f18.

Here is a new version with, as suggested by @richard.barton.arm:

  • removed __F18*
  • added __flang*
Jul 30 2020, 8:34 AM · Restricted Project, Restricted Project

Jul 29 2020

coti added a comment to D84334: [flang] Version information in flang/f18.

I have made the modifications suggested by @richard.barton.arm, but then, CMake does not compile anymore because it relies on __FLANG, __FLANG_MAJOR__, __FLANG_MINOR__ and __FLANG_PATCHLEVEL__.

Jul 29 2020, 4:01 PM · Restricted Project, Restricted Project

Jul 27 2020

coti updated the diff for D84340: Order of libraries and source files in the f18 frontend.

clang-formated the source code, since I have been told about issues with whitespaces.

Jul 27 2020, 3:48 PM · Restricted Project, Restricted Project
coti updated the diff for D84340: Order of libraries and source files in the f18 frontend.

@AlexisPerry is right, I removed the vector relocatable.

Jul 27 2020, 2:38 PM · Restricted Project, Restricted Project

Jul 24 2020

coti added a comment to D84340: Order of libraries and source files in the f18 frontend.

Replied comment from @DavidTruby.

Jul 24 2020, 10:10 AM · Restricted Project, Restricted Project

Jul 23 2020

coti updated the diff for D84334: [flang] Version information in flang/f18.

Let cmake grab the version numbers.

Jul 23 2020, 5:25 PM · Restricted Project, Restricted Project

Jul 22 2020

coti added a comment to D84334: [flang] Version information in flang/f18.

Fixed an error in my reply

Jul 22 2020, 3:29 PM · Restricted Project, Restricted Project
coti added a comment to D84334: [flang] Version information in flang/f18.

Replied inline comment from @klausler

Jul 22 2020, 3:25 PM · Restricted Project, Restricted Project
coti added a comment to D84334: [flang] Version information in flang/f18.

Answered some inline comments.

Jul 22 2020, 2:39 PM · Restricted Project, Restricted Project
coti updated the diff for D84334: [flang] Version information in flang/f18.

Applied suggestions from Alexis.

Jul 22 2020, 10:44 AM · Restricted Project, Restricted Project
Herald added a reviewer for D84340: Order of libraries and source files in the f18 frontend: DavidTruby.
Jul 22 2020, 9:41 AM · Restricted Project, Restricted Project
coti updated the diff for D84334: [flang] Version information in flang/f18.
Jul 22 2020, 9:33 AM · Restricted Project, Restricted Project
Herald added a reviewer for D84334: [flang] Version information in flang/f18: DavidTruby.
Jul 22 2020, 9:20 AM · Restricted Project, Restricted Project