User Details
- User Since
- Jul 20 2020, 12:16 PM (38 w, 4 d)
Nov 4 2020
yes, I clang-format-ed the code, and I think this is what explains the modification line 620 for example.
Oct 30 2020
Aug 24 2020
Fixed the include paths. Thank you @richard.barton.arm!
On a clean tree, with the attached patch, I get:
[ 90%] Built target f18 [ 90%] Generating /__fortran_builtins.mod Enter Fortran source Use EOF character (^D) to end file
Aug 14 2020
On a clean build, with:
Aug 13 2020
Actually, I cannot find a way to make it work with target_include_directories on a clean build tree.
Followed @DavidTruby's recommendation on how include directories are set by CMake.
Aug 12 2020
@DavidTruby so, how about replacing:
Typo in a comment.
Added include ${CMAKE_CURRENT_BINARY_DIR}, as suggested by @isuruf. I tested it on a clean tree, it seems to work.
Aug 10 2020
yes ;)
Outch, sorry :(
I create my patches with git diff....
Aug 7 2020
I generated the diff again on a clean clone. I don't know why but my CMakeList.txt was wrong even after a git stash. Sorry about that, I hope it should be fine now.
Updated my local clone, fixed the conflicts and re-generated the diff.
No, I don't ;)
Aug 5 2020
Thank you @tskeith for the tip on the tests!
All the comments should be addressed:
- renamed the test for pre-processor macros compiler_defined_macros.F90
- removed __flang_version__ (in f18.cpp and in the tests)
- use %f18 -E in the pre-processor test in order to avoid a full compilation
Aug 4 2020
Some tests for the -v flag and associated macros.
I am writing the tests.
Jul 30 2020
Use CMAKE_CURRENT_BINARY_DIR as the target directory of the geneated .h file, as suggested by @isuruf
Here is a new version with, as suggested by @richard.barton.arm:
- removed __F18*
- added __flang*
Jul 29 2020
I have made the modifications suggested by @richard.barton.arm, but then, CMake does not compile anymore because it relies on __FLANG, __FLANG_MAJOR__, __FLANG_MINOR__ and __FLANG_PATCHLEVEL__.
Jul 27 2020
clang-formated the source code, since I have been told about issues with whitespaces.
@AlexisPerry is right, I removed the vector relocatable.
Jul 24 2020
Replied comment from @DavidTruby.
Jul 23 2020
Let cmake grab the version numbers.
Jul 22 2020
Fixed an error in my reply
Replied inline comment from @klausler
Answered some inline comments.
Applied suggestions from Alexis.