Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People collinbaker

collinbaker (Collin Baker)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 13 2021, 11:46 AM (101 w, 6 d)

Recent Activity
View All

Mar 10 2023

collinbaker added a comment to D130303: Fix include order in CXType.cpp.

Collin Baker
collinbaker@chromium.org

Mar 10 2023, 3:55 PM · Restricted Project, Restricted Project

Mar 9 2023

collinbaker added a comment to D130303: Fix include order in CXType.cpp.

All done. Again, I don't have commit access so someone else will need to land this.

Mar 9 2023, 3:35 PM · Restricted Project, Restricted Project
collinbaker updated the diff for D130303: Fix include order in CXType.cpp.

Rebase w/ conflict in libclang.map

Mar 9 2023, 3:33 PM · Restricted Project, Restricted Project
collinbaker added a comment to D130303: Fix include order in CXType.cpp.

I am very bad at using differential

Mar 9 2023, 3:28 PM · Restricted Project, Restricted Project
collinbaker updated the diff for D130303: Fix include order in CXType.cpp.

Re-add "Fixes" commit message footer

Mar 9 2023, 3:27 PM · Restricted Project, Restricted Project
collinbaker updated the diff for D130303: Fix include order in CXType.cpp.

Missed commit

Mar 9 2023, 3:25 PM · Restricted Project, Restricted Project
collinbaker updated the diff for D130303: Fix include order in CXType.cpp.

Cleanups and split header order change to separate commit

Mar 9 2023, 3:23 PM · Restricted Project, Restricted Project

Mar 8 2023

collinbaker added a comment to D130303: Fix include order in CXType.cpp.

Changed as requested. Again leaving it up to a committer to commit this

Mar 8 2023, 4:50 PM · Restricted Project, Restricted Project
collinbaker updated the diff for D130303: Fix include order in CXType.cpp.

Requested changes

Mar 8 2023, 4:48 PM · Restricted Project, Restricted Project

Mar 7 2023

collinbaker added a comment to D130303: Fix include order in CXType.cpp.

@dexonsmith can you weigh in?

Mar 7 2023, 9:27 AM · Restricted Project, Restricted Project

Mar 6 2023

collinbaker added a comment to D130303: Fix include order in CXType.cpp.

Thanks for the review. Someone else will need to commit since I don't have permission.

Mar 6 2023, 12:59 PM · Restricted Project, Restricted Project
collinbaker updated the summary of D130303: Fix include order in CXType.cpp.
Mar 6 2023, 12:59 PM · Restricted Project, Restricted Project
collinbaker updated the diff for D130303: Fix include order in CXType.cpp.

Add symbol to version map

Mar 6 2023, 12:58 PM · Restricted Project, Restricted Project
collinbaker added inline comments to D130303: Fix include order in CXType.cpp.
Mar 6 2023, 12:56 PM · Restricted Project, Restricted Project
collinbaker updated the diff for D130303: Fix include order in CXType.cpp.

Add release notes and remove unneeded include

Mar 6 2023, 12:56 PM · Restricted Project, Restricted Project
collinbaker updated the diff for D130303: Fix include order in CXType.cpp.

Sync with upstream changes

Mar 6 2023, 12:27 PM · Restricted Project, Restricted Project

Aug 10 2022

collinbaker added a comment to D130303: Fix include order in CXType.cpp.

Pinging this

Aug 10 2022, 10:01 AM · Restricted Project, Restricted Project

Jul 21 2022

collinbaker requested review of D130303: Fix include order in CXType.cpp.
Jul 21 2022, 2:13 PM · Restricted Project, Restricted Project

Jan 4 2022

collinbaker updated the diff for D115049: Fall back on Android triple w/o API level for runtimes search.

Rebase

Jan 4 2022, 1:51 PM · Restricted Project

Dec 13 2021

collinbaker added inline comments to D115049: Fall back on Android triple w/o API level for runtimes search.
Dec 13 2021, 11:48 AM · Restricted Project
collinbaker updated the diff for D115049: Fall back on Android triple w/o API level for runtimes search.
  • Address comments
  • Fix VEToolchain build error
  • Rebase
Dec 13 2021, 11:42 AM · Restricted Project

Dec 3 2021

collinbaker added a reviewer for D115049: Fall back on Android triple w/o API level for runtimes search: thakis.
Dec 3 2021, 9:31 AM · Restricted Project
collinbaker updated the diff for D115049: Fall back on Android triple w/o API level for runtimes search.

Fix variable name style

Dec 3 2021, 9:30 AM · Restricted Project
collinbaker requested review of D115049: Fall back on Android triple w/o API level for runtimes search.
Dec 3 2021, 9:23 AM · Restricted Project

Oct 14 2021

collinbaker updated the diff for D111756: [test] Fix asan dynamic unit tests with per-target runtime dirs.

Add comment to unit test CMake target

Oct 14 2021, 11:20 AM · Restricted Project
collinbaker added a comment to D111756: [test] Fix asan dynamic unit tests with per-target runtime dirs.
In D111756#3063432, @phosek wrote:

LGTM

Oct 14 2021, 10:08 AM · Restricted Project
collinbaker updated the summary of D111756: [test] Fix asan dynamic unit tests with per-target runtime dirs.
Oct 14 2021, 9:17 AM · Restricted Project
collinbaker updated the diff for D111756: [test] Fix asan dynamic unit tests with per-target runtime dirs.

Remove debuggig line

Oct 14 2021, 9:16 AM · Restricted Project

Oct 13 2021

collinbaker updated the summary of D111756: [test] Fix asan dynamic unit tests with per-target runtime dirs.
Oct 13 2021, 1:31 PM · Restricted Project
collinbaker requested review of D111756: [test] Fix asan dynamic unit tests with per-target runtime dirs.
Oct 13 2021, 1:28 PM · Restricted Project