- User Since
- Oct 22 2018, 3:00 PM (222 w, 6 d)
Mon, Jan 16
Some version of this fix made it into:
This review can be closed --- thanks.
Nov 9 2022
Works for me -- thanks for the quick fix!
Apr 22 2022
Updated --- thanks for your comments!
Sharpened the test.
Apr 21 2022
Gentle ping... does anyone see any issues with this (hopefully) minor alteration?
Mar 31 2022
Fuzzer fails are timeouts; very unlikely they are related to this diff.
Mar 30 2022
Mar 29 2022
Mar 28 2022
Widen 2nd element of key to uintptr_t, store entire Type*. Add test for different addrspaces, use update_test_checks.
Mar 25 2022
Feb 7 2022
Nov 5 2021
Yes, I confirm that it fixes the problem (by preventing the SCEVUnknowns from being gathered in the first place). Thanks for pointing this out --- since the other patch seems almost ready, I will close this one.
Nov 4 2021
Aug 18 2021
Thank you for the review. Could I please ask someone to commit, with --author="Chang-Sun Lin, Jr. <firstname.lastname@example.org>"?
Aug 12 2021
Failing "task-dependency.c" test looks like unrelated flakiness. Observed it pass/failing randomly in local testing.
Aug 11 2021
Forgot the check lines...
Aug 2 2021
Chang-Sun Lin, Jr <email@example.com>
Thank you for the quick review! Could I request you to "press the commit button", please? I apologize, I don't have write access to the repo.
Jun 16 2021
spec2000/186 passes now -- thanks.
Jun 9 2021
Hi @aeubanks, we turned up a corner case where jump threading is creating a self-referential GEP:
%tmp27 = getelementptr inbounds i8, i8* %tmp27, i64 1
Jun 8 2021
Thank you for the quick response! Much appreciated.
@dmgreen, we found that DSE is removing a non dead store in a loop with multiple backedges. File "dse-double-loop.ll" attached. The 2nd store postdominates the 1st one, but it doesn't run on every iteration, so the 1st one is still needed. We worked around it by checking numBackEdges > 1 in addition to the irreducibility check. Would you mind taking a look? I hope bugpoint did not over-reduce the test case; it's derived from "real" code in spec2000 186.crafty.
Apr 21 2021
Thanks for the review comments! Could I please ask someone for help making the commit? I don't have write access.
Apr 20 2021
Apr 19 2021
fixed case in variable name
Mar 16 2021
Oct 26 2020
Jun 19 2020
Our internal test passes---thank you for the fix.
Ah, I missed your comment. I'll pull your fix and retest.
Return true to trigger the simplifier.
Thanks for the consensus. New patch uploaded.
Jun 18 2020
Good clarification: InstCombine vs. InstSimplify.
Merged and reduced test, full diff included.
If the patch is OK, could I ask you one more favor: to commit it? I do not have commit access to the project.
Updated to run InstCombine before the vector transformations. The insert-binop-with-constant test needed a few changes. InstructionSimplify checks for constant divisors with 0/undef elements and undef's the entire result.
Jun 17 2020
If running IC is cheap, that's a good solution. I will put up another patch. Thanks.
The IR looks strange, but it's unfortunately showing up in a few real test cases in our LLVM branch, after we've made some mods to the unroller and vectorizer.
FWIW, dropping the attribute LGTM. The heap/stack promotion is still a work in progress, is that correct? At least, I don't see it happening in trunk.
Oct 8 2019
Restoring latest patch.
Jan 19 2019
@mkazantsev, would you mind taking one more look at this patch? One significant fix was made since your last review, to handle duplicate edges from SwitchInsts. The patch has now been rebased to latest (which hasn't changed it much). Thanks!
Nov 20 2018
Did not include the reverted part of the code (the important part :) ) in the new patch. Added separate testcase for switch-backedge. Thanks for the fix suggestions.
Nov 16 2018
Keep the InLoopPredecessors vector in the original order.
Missed the sort call -- thanks.
Remove duplicate blocks from the list of exit predecessors. This happens when the predecessor inst is a switch with duplicate targets. Avoids block double-processing and maintains the metadata consistency assertion.
Nov 14 2018
Sorry for the trouble. I'll figure out what happened.
Nov 6 2018
Thank you for the thorough review. I have one more request to the reviewers on this list: could someone give a hand to commit the code? I don't have write access to the repo yet.
Nov 2 2018
Previous patch was null, this is the right one.
Rewrote comments, fixed formatting, simplified test and added checks for specific metadata
Oct 30 2018
Oct 26 2018
One more favor to ask: Could I please have some help committing this fix? I'm new to the project and don't have write access yet...
Thanks! I've made the suggested test change.