Page MenuHomePhabricator

clin1 (Chang Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 22 2018, 3:00 PM (58 w, 6 d)

Recent Activity

Oct 8 2019

clin1 updated the diff for D53876: Preserve loop metadata when splitting exit blocks.

Restoring latest patch.

Oct 8 2019, 12:47 AM · Restricted Project

Jan 19 2019

clin1 updated the diff for D53876: Preserve loop metadata when splitting exit blocks.

@mkazantsev, would you mind taking one more look at this patch? One significant fix was made since your last review, to handle duplicate edges from SwitchInsts. The patch has now been rebased to latest (which hasn't changed it much). Thanks!

Jan 19 2019, 11:46 PM · Restricted Project

Nov 20 2018

clin1 updated the diff for D53876: Preserve loop metadata when splitting exit blocks.

Did not include the reverted part of the code (the important part :) ) in the new patch. Added separate testcase for switch-backedge. Thanks for the fix suggestions.

Nov 20 2018, 10:16 AM · Restricted Project

Nov 16 2018

clin1 updated the diff for D53876: Preserve loop metadata when splitting exit blocks.

Keep the InLoopPredecessors vector in the original order.

Nov 16 2018, 8:28 PM · Restricted Project
clin1 updated the diff for D53876: Preserve loop metadata when splitting exit blocks.

Missed the sort call -- thanks.

Nov 16 2018, 4:59 PM · Restricted Project
clin1 updated the diff for D53876: Preserve loop metadata when splitting exit blocks.

Remove duplicate blocks from the list of exit predecessors. This happens when the predecessor inst is a switch with duplicate targets. Avoids block double-processing and maintains the metadata consistency assertion.

Nov 16 2018, 3:32 PM · Restricted Project

Nov 14 2018

clin1 added a comment to D53876: Preserve loop metadata when splitting exit blocks.

Sorry for the trouble. I'll figure out what happened.

Nov 14 2018, 10:33 AM · Restricted Project

Nov 6 2018

clin1 added a comment to D53876: Preserve loop metadata when splitting exit blocks.

Thank you for the thorough review. I have one more request to the reviewers on this list: could someone give a hand to commit the code? I don't have write access to the repo yet.

Nov 6 2018, 3:59 PM · Restricted Project

Nov 2 2018

clin1 updated the diff for D53876: Preserve loop metadata when splitting exit blocks.

Previous patch was null, this is the right one.

Nov 2 2018, 3:50 PM · Restricted Project
clin1 updated the diff for D53876: Preserve loop metadata when splitting exit blocks.

Rewrote comments, fixed formatting, simplified test and added checks for specific metadata

Nov 2 2018, 3:44 PM · Restricted Project
clin1 added inline comments to D53876: Preserve loop metadata when splitting exit blocks.
Nov 2 2018, 3:38 PM · Restricted Project

Oct 30 2018

clin1 created D53876: Preserve loop metadata when splitting exit blocks.
Oct 30 2018, 10:45 AM · Restricted Project

Oct 26 2018

clin1 added a comment to D53536: Pointer types were treated as zero-size by MergeICmps.

One more favor to ask: Could I please have some help committing this fix? I'm new to the project and don't have write access yet...

Oct 26 2018, 10:54 AM
clin1 updated the diff for D53536: Pointer types were treated as zero-size by MergeICmps.

Thanks! I've made the suggested test change.

Oct 26 2018, 10:52 AM

Oct 22 2018

clin1 created D53536: Pointer types were treated as zero-size by MergeICmps.
Oct 22 2018, 3:59 PM