Page MenuHomePhabricator

christophe-calmejane (Christophe Calmejane)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 4 2018, 12:11 AM (154 w, 1 d)

Recent Activity

Jun 16 2021

christophe-calmejane added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

If you did The only difference (with this current patch) would be the positioning of the first arguments on paramBeforeAndAfterLambda and doubleLambda (I'm not sure the reason for why that is)

Jun 16 2021, 1:43 AM · Restricted Project, Restricted Project
christophe-calmejane added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

@MyDeveloperDay
Of course, sorry for the delay, here it is: https://github.com/christophe-calmejane/Hive/blob/master/.clang-format

You don't have AllowShortLambdasOnASingleLine set to be false or None

Jun 16 2021, 1:23 AM · Restricted Project, Restricted Project
christophe-calmejane added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

@christophe-calmejane are you able to post your .clang-format styles that you are using, I'm struggling to see where its not matching your style (other than brace styles on the function and argument placing)

Jun 16 2021, 12:56 AM · Restricted Project, Restricted Project

Jun 15 2021

christophe-calmejane added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

Hi @christophe-calmejane.
I test your code with a old version (few time after the merge of https://reviews.llvm.org/D44609), and the latest version (commit: e0c382a9d5a0), and in both cases I have the same result, which is near your output:

I though I add multiples cases, but looking at UnitTests with inline lambda "None", I see only few tests, perhaps some are missing.

Jun 15 2021, 7:12 AM · Restricted Project, Restricted Project
christophe-calmejane added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

Due to the pandemic, I wasn't able to look at https://reviews.llvm.org/D44609 which got broken since it was pushed to LLVM. Nevertheless I commented in that post with a rather complete unit tests that should pass if any changes are to be pushed to that part of the code.

Jun 15 2021, 5:20 AM · Restricted Project, Restricted Project

Feb 26 2020

christophe-calmejane added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Correct follow that description on how to request commit access

It's done. I have the commit right, and push that change on github : https://github.com/llvm/llvm-project/commit/fa0118e6e588fe303b08e7e06ba28ac1f8d50c68

Thank you for the review and advices!

Feb 26 2020, 7:04 AM · Restricted Project, Restricted Project

Oct 4 2018

christophe-calmejane added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

I fixed it like this (not sure it's 100% correct though!!)

Oct 4 2018, 9:39 AM · Restricted Project, Restricted Project
christophe-calmejane added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Ok I found the issue with noexcept, it's not related to your patch.
There is a missing

Oct 4 2018, 2:41 AM · Restricted Project, Restricted Project
christophe-calmejane added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Actually, without your change to HasMultipleNestedBlocks, I'm almost getting the expected result: Lambda body is correctly indented (and not by function name's length).
The only thing not working (and it's not either way, with or without your change to HasMultipleNestedBlocks), is nested lambdas. The body is not properly indented (but it's not that bad).

Oct 4 2018, 1:48 AM · Restricted Project, Restricted Project
christophe-calmejane added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

consider the following sample code (formatted without your patch)

Oct 4 2018, 12:20 AM · Restricted Project, Restricted Project