Page MenuHomePhabricator

chrish_ericsson_atx (Chris Hamilton)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 8 2019, 8:09 AM (6 w, 1 d)

Recent Activity

Sun, Aug 25

chrish_ericsson_atx added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

@Szelethus, firstly, thank you for landing this change. I really appreciate it! Secondly, apologies for misspelling your name earlier. And lastly, thank you for your patient explanation of how to get the diffs updated correctly in a Phabricator review. I think my mistake was that I made the change and the updates updates in a private branch, and not directly off master, and then duplicated the changes on master. For one of those sets of changes, I amended the first commit with the second round of changes, and I think I confused myself by doing that. In any case, lesson learned, and thank you again for your coaching!

Sun, Aug 25, 6:01 AM · Restricted Project, Restricted Project

Aug 21 2019

chrish_ericsson_atx added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

Kristoff, if you wouldn't mind, since you offered earlier, please go ahead and commit this change as-is, since it was accepted. I ran into some non-technical issues with my follow-up changes and I'm going to be unavailable for several weeks. To mitigate risk and work for my team, I'd like to submit the newer changes separately (and will reference this review in that changeset when I do, of course), after I return to work.

Aug 21 2019, 5:05 AM · Restricted Project, Restricted Project

Aug 15 2019

chrish_ericsson_atx updated the diff for D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

Follow-up on reviewer feedback. Changed from blacklisting LValueToRValue to whitelisting IntegralCast. This was a good call -- additional testing with different cast kinds showed that the assertion tripped for other casts besides LValueToRValue, e.g., FloatToIntegral. I couldn't see any casts other than Integral where the enum check seemed appropriate. Testing with only IntegralCast enabled gave expected (correct) results.

Aug 15 2019, 10:37 AM · Restricted Project, Restricted Project
chrish_ericsson_atx added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

LGTM, thanks! Do you need someone to commit this on your behalf? Also, could you please make the comments capitalized, terminated, and fitting in 80 columns?

Aug 15 2019, 9:30 AM · Restricted Project, Restricted Project

Aug 13 2019

chrish_ericsson_atx added inline comments to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.
Aug 13 2019, 5:27 AM · Restricted Project, Restricted Project

Aug 12 2019

chrish_ericsson_atx added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

Oh, btw, thank you for working on this!

Aug 12 2019, 2:25 PM · Restricted Project, Restricted Project
chrish_ericsson_atx added inline comments to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.
Aug 12 2019, 9:52 AM · Restricted Project, Restricted Project

Aug 9 2019

chrish_ericsson_atx added reviewers for D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts: Restricted Project, Szelethus.
Aug 9 2019, 8:06 AM · Restricted Project, Restricted Project
chrish_ericsson_atx created D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.
Aug 9 2019, 8:02 AM · Restricted Project, Restricted Project