Page MenuHomePhabricator

choikwa (kchoi)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 29 2017, 10:42 PM (120 w, 2 d)

Recent Activity

Oct 25 2017

choikwa updated the diff for D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..

rebase to trunk

Oct 25 2017, 7:43 AM

Oct 1 2017

choikwa added a comment to D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..

Can you get more information on what GCC actually implemented and why? It's not clear to me that ignoring the namespaces is the most-useful way to do this. I don't want to emulate GCC bugs, but maybe there's a good reason why their implementation works this way.

Oct 1 2017, 1:17 PM
choikwa added a comment to D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..
  • add comment to CPP test to explain usage

Thanks. Please also add some tests showing matching overloaded functions, functions with template parameters, etc.

Do we need to strip whitespace before trying to match the demangled names?

Some cursory testing with g++ shows that only the 'test5' of 'test5(float, int, int*)' is matched. 'test5(' or 'test5 (' is not matched. It seems weird that arguments are not matched.

g++ man page shows

"The function name to be matched is its user-visible name, such as "vector<int> blah(const vector<int> &)", not the internal mangled name"

but it doesn't seem to be including parameters.

Interesting. Can you tell what GCC is doing w.r.t. namespace names, class names, etc. and template parameters?

Also uncovered a bug where sub argument list containing comma needs to be surrounded by single quote, but clang seems to ignores single quote.
I'll try to dig around ArgList implementation to see if it can return argument surrounded by single-quote as a whole.

Oct 1 2017, 12:13 AM

Sep 30 2017

choikwa added a comment to D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..
  • add comment to CPP test to explain usage

Thanks. Please also add some tests showing matching overloaded functions, functions with template parameters, etc.

Do we need to strip whitespace before trying to match the demangled names?

Sep 30 2017, 8:34 PM
choikwa updated the diff for D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..
  • add more CPP tests: func overload, template special
Sep 30 2017, 7:55 PM
choikwa updated the diff for D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..
  • add comment to CPP test to explain usage
Sep 30 2017, 7:07 PM
choikwa updated the diff for D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..
  • - Address formating feedback, remove redundant inline
Sep 30 2017, 6:02 PM
choikwa updated the diff for D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..

Addressing Hal's feedback

Sep 30 2017, 2:34 PM

Sep 8 2017

choikwa added reviewers for D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options.: rnk, majnemer.
Sep 8 2017, 10:25 AM
choikwa updated the diff for D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..

renamed and moved Cache to SourceLocToFileNameMap in CodeGenModule

Sep 8 2017, 10:24 AM
choikwa added a comment to D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..

Forgot to hang Cache to CodeGenModule, will do that shortly

Sep 8 2017, 9:44 AM
choikwa updated the diff for D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..

addressed code review. made doc consistent with functionality.

Sep 8 2017, 9:40 AM
choikwa created D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options..
Sep 8 2017, 7:21 AM
choikwa added a comment to D37622: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options.

ok I already see a few issues -
doc - add '='

Sep 8 2017, 6:00 AM
choikwa created D37622: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options.
Sep 8 2017, 5:48 AM