Page MenuHomePhabricator

chilledheart (Chilledheart)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2014, 2:07 PM (276 w, 19 h)

Recent Activity

Mar 28 2018

chilledheart abandoned D7378: llvm-readobj: implement MachODumper::printNeededLibraries.
Mar 28 2018, 10:12 AM

Mar 7 2016

chilledheart added a comment to D7378: llvm-readobj: implement MachODumper::printNeededLibraries.

Ping?

Mar 7 2016, 10:35 AM

Apr 22 2015

chilledheart added a comment to D9140: Handle big index in getelementptr instruction for AArch64FastISel.

Thank you for doing this fix, chfast.

I think we can probably copy this test into the directory of each target. Since the target R600 is still falling, we can add the part for R600 separately in a different patch.

I'm not convinced about adding the test for every target. I added for arm64 as it was failing and fix is for that target. I don't know any other target beside R600 that fails on that.

Or we can add this test for other targets later.

Apr 22 2015, 6:33 AM
chilledheart added a comment to D9140: Handle big index in getelementptr instruction for AArch64FastISel.

Hi chfast and Northover:

Apr 22 2015, 5:47 AM

Apr 21 2015

chilledheart added a comment to D9140: Handle big index in getelementptr instruction for AArch64FastISel.

Thank you for doing this fix, chfast.

Apr 21 2015, 12:56 PM

Apr 20 2015

chilledheart added a comment to D8219: Handle big index in getelementptr instruction.

The fix was applied to generic CodeGen and is target independent. But it looks like the test case revealed bugs in target-specific code for some other targets. It looks like the crashes discovered are similar to the one I fixed - the assumption that GEP index is never bigger than 64 bit.

I can take a deeper look at that if you want.

Hi chfast,

Apr 20 2015, 11:04 AM
chilledheart added a comment to D8219: Handle big index in getelementptr instruction.

Hi all,
Just be curious, is this fix to be platform-independent?
After I noticed the testcase is X86-only, I tested X86/getelementptr.ll with more platform+optimization level combinations. There are some crashes:

Apr 20 2015, 9:29 AM

Apr 13 2015

chilledheart added a comment to D8773: llvm-readobj: teach it to handle MachO Universal Archive correctly.

Thank you, dblaikie.

Apr 13 2015, 9:09 AM
chilledheart added a comment to D8773: llvm-readobj: teach it to handle MachO Universal Archive correctly.

Hi rafael:

Apr 13 2015, 5:58 AM
chilledheart added a comment to D8897: [docs] Update outdated ExtendingLLVM.rst.

Hi eric:

Apr 13 2015, 5:57 AM

Apr 8 2015

chilledheart retitled D8897: [docs] Update outdated ExtendingLLVM.rst from to [docs] Update outdated ExtendingLLVM.rst.
Apr 8 2015, 9:18 AM

Apr 1 2015

chilledheart retitled D8773: llvm-readobj: teach it to handle MachO Universal Archive correctly from to llvm-readobj: teach it to handle MachO Universal Archive correctly.
Apr 1 2015, 8:28 AM

Mar 25 2015

chilledheart closed D8161: [llvm-readobj] add support for macho universal binary.

"Committed as r233107"

Mar 25 2015, 9:44 AM

Mar 24 2015

chilledheart added a comment to D8161: [llvm-readobj] add support for macho universal binary.

Thank you, rafael!

Mar 24 2015, 5:41 PM

Mar 21 2015

chilledheart abandoned D6271: suppress compiler warning (mostly -Wsign-compare).

I am abandoning this patch and it will be really helpful if someone can follow the latest code of lldb and fix Wsign-compare warnings.

Mar 21 2015, 11:03 AM
chilledheart abandoned D6270: Fix cmake build by linking LLVMSupport.
Mar 21 2015, 10:58 AM
chilledheart abandoned D6273: fix cmake build under mac.
Mar 21 2015, 10:58 AM

Mar 20 2015

chilledheart retitled D8489: clang-format: add an option for fallback style in vimrc from to clang-format: add an option for fallback style in vimrc.
Mar 20 2015, 12:11 PM
chilledheart added a comment to D8161: [llvm-readobj] add support for macho universal binary.

Hi rafael,

Mar 20 2015, 12:10 PM

Mar 14 2015

chilledheart added a comment to D8161: [llvm-readobj] add support for macho universal binary.

You're welcome.

Mar 14 2015, 5:52 AM

Mar 12 2015

chilledheart added a comment to D8161: [llvm-readobj] add support for macho universal binary.

report error if any

Mar 12 2015, 7:13 PM
chilledheart updated the diff for D8161: [llvm-readobj] add support for macho universal binary.

report error if any

Mar 12 2015, 7:10 PM
chilledheart updated the diff for D8161: [llvm-readobj] add support for macho universal binary.

improve code style

Mar 12 2015, 11:44 AM
chilledheart updated the diff for D8161: [llvm-readobj] add support for macho universal binary.

use llvm::iterator_range

Mar 12 2015, 11:38 AM
chilledheart added a comment to D8161: [llvm-readobj] add support for macho universal binary.

I am not sure if explicit initialization of MachOUniversalBinary::Objects is good enough. Maybe we need to change the MachOUniversalBinary::object_iterator to typedef ObjectForArch* object_iterator and related code as well to use MachOUniversalBinary::Objects directly?

Mar 12 2015, 9:13 AM
chilledheart updated the diff for D8161: [llvm-readobj] add support for macho universal binary.

add MachOUniversalBinary::objects() method and remove unnecessary checks for non-object members

Mar 12 2015, 9:08 AM

Mar 9 2015

chilledheart retitled D8161: [llvm-readobj] add support for macho universal binary from to [llvm-readobj] add support for macho universal binary.
Mar 9 2015, 2:48 AM

Mar 3 2015

chilledheart updated the diff for D7378: llvm-readobj: implement MachODumper::printNeededLibraries.

apply some minor improvements

Mar 3 2015, 7:22 PM

Mar 1 2015

chilledheart updated the diff for D7378: llvm-readobj: implement MachODumper::printNeededLibraries.

remove std::stable_sort and LC_ID_DYLIB items

Mar 1 2015, 6:13 PM
chilledheart added a comment to D7378: llvm-readobj: implement MachODumper::printNeededLibraries.

Ping?

Mar 1 2015, 5:34 AM

Feb 4 2015

chilledheart added a reviewer for D6273: fix cmake build under mac: chilledheart.
Feb 4 2015, 10:15 AM
chilledheart added a comment to D6271: suppress compiler warning (mostly -Wsign-compare).

Although there are still some Wsign-compare warnings outside this patch, I think this diff is good enough for its own purpose.

Feb 4 2015, 10:07 AM
chilledheart updated the diff for D6271: suppress compiler warning (mostly -Wsign-compare).

rebase to trunk

Feb 4 2015, 10:02 AM
chilledheart added a comment to D6271: suppress compiler warning (mostly -Wsign-compare).

Hi emaste

Feb 4 2015, 8:42 AM
chilledheart added a comment to D3910: [lldb] Build lldb-mi with cmake on Linux only.

Hi emaste

Feb 4 2015, 8:29 AM
chilledheart added a comment to D6270: Fix cmake build by linking LLVMSupport.

I think commit 226039 has fix this compilation error when BUILD_SHARED_LIBS=on.

Feb 4 2015, 8:22 AM

Feb 3 2015

chilledheart added a comment to D7378: llvm-readobj: implement MachODumper::printNeededLibraries.

Most code of MachODumper::printNeededLibraries keeps the same with ELFDumper::printNeededLibraries.

Feb 3 2015, 9:53 AM
chilledheart updated subscribers of D7378: llvm-readobj: implement MachODumper::printNeededLibraries.
Feb 3 2015, 9:47 AM
chilledheart retitled D7378: llvm-readobj: implement MachODumper::printNeededLibraries from to llvm-readobj: implement MachODumper::printNeededLibraries.
Feb 3 2015, 9:46 AM

Dec 21 2014

chilledheart retitled D6270: Fix cmake build by linking LLVMSupport from fix cmake build by linking LLVMSupport to Fix cmake build by linking LLVMSupport.
Dec 21 2014, 8:24 AM

Nov 14 2014

chilledheart updated the diff for D6270: Fix cmake build by linking LLVMSupport.

update lldb-platform

Nov 14 2014, 6:00 PM
chilledheart added a comment to D6270: Fix cmake build by linking LLVMSupport.

Hi Zachary,

Nov 14 2014, 5:08 PM
chilledheart added a comment to D6271: suppress compiler warning (mostly -Wsign-compare).

It is a choice based on some reasons:

  1. i is going to negative here where the loop stops. So i must be signed

type.

  1. i should be large enough to hold a unsigned size_t. If type int is

sufficient in the previous case, type long is larger.
3.As I know, size_t is unsigned long under OS X.

Nov 14 2014, 4:43 PM
chilledheart added a reviewer for D6270: Fix cmake build by linking LLVMSupport: tfiala.
Nov 14 2014, 10:41 AM
chilledheart added a comment to D6273: fix cmake build under mac.

I need this patch and http://reviews.llvm.org/D6270 when I build lldb under mac with cmake.

Nov 14 2014, 10:40 AM
chilledheart added a reviewer for D6273: fix cmake build under mac: tfiala.
Nov 14 2014, 10:39 AM
chilledheart retitled D6273: fix cmake build under mac from to fix cmake build under mac.
Nov 14 2014, 10:38 AM
chilledheart added a comment to D6163: implement MachODumper::printFileHeaders.

No worry about that. Take your time.

Nov 14 2014, 10:14 AM
chilledheart added a comment to D6270: Fix cmake build by linking LLVMSupport.

I am not sure if other platforms than OS X have the same issue.

Nov 14 2014, 10:04 AM
chilledheart added a comment to D6163: implement MachODumper::printFileHeaders.

Hi Frederic,
If you have some free time this weekend, could you land it for me? Btw I don't have a subversion account yet and am not able to do it myself.

Nov 14 2014, 10:01 AM
chilledheart retitled D6271: suppress compiler warning (mostly -Wsign-compare) from to suppress compiler warning (mostly -Wsign-compare).
Nov 14 2014, 9:54 AM
chilledheart added a reviewer for D6270: Fix cmake build by linking LLVMSupport: emaste.
Nov 14 2014, 9:51 AM
chilledheart retitled D6270: Fix cmake build by linking LLVMSupport from to fix cmake build by linking LLVMSupport.
Nov 14 2014, 9:50 AM

Nov 13 2014

chilledheart updated the diff for D6163: implement MachODumper::printFileHeaders.

dump reserved field for 64bit mach-o object

Nov 13 2014, 7:56 AM
chilledheart added a comment to D6163: implement MachODumper::printFileHeaders.
In D6163#26, @nrieck wrote:

Since llvm-readobj is a low-level inspection tool, the Reserved field should also be printed (even more so than unused fields).

Nov 13 2014, 7:24 AM

Nov 12 2014

chilledheart added a comment to D6163: implement MachODumper::printFileHeaders.

Really appreciate it if you land it for me.

Nov 12 2014, 4:33 PM
chilledheart updated the diff for D6163: implement MachODumper::printFileHeaders.

add test cases

Nov 12 2014, 7:40 AM
chilledheart updated the diff for D6163: implement MachODumper::printFileHeaders.

update format

Nov 12 2014, 7:06 AM
chilledheart updated the diff for D6163: implement MachODumper::printFileHeaders.

test part is comming soon

Nov 12 2014, 7:05 AM

Nov 11 2014

chilledheart updated the diff for D6163: implement MachODumper::printFileHeaders.

correct some typos

Nov 11 2014, 7:48 PM
chilledheart updated the diff for D6163: implement MachODumper::printFileHeaders.

print magic, filetype and cputype more pretty

Nov 11 2014, 7:45 PM
chilledheart updated the diff for D6163: implement MachODumper::printFileHeaders.

use a little template helper

Nov 11 2014, 7:05 PM
chilledheart updated the diff for D6163: implement MachODumper::printFileHeaders.

the name "MachHeader" is better than plain "Header"

Nov 11 2014, 6:09 PM

Nov 6 2014

chilledheart updated the diff for D6163: implement MachODumper::printFileHeaders.

update for code format

Nov 6 2014, 9:13 PM
chilledheart retitled D6163: implement MachODumper::printFileHeaders from to implement MachODumper::printFileHeaders.
Nov 6 2014, 9:03 PM

Oct 21 2014

chilledheart retitled D5879: GCC has supported C++11 ref-qualifiers since 4.8.1 from GCC has support C++11 ref-qualifiers since 4.8.1 to GCC has supported C++11 ref-qualifiers since 4.8.1.
Oct 21 2014, 11:29 AM
chilledheart updated the diff for D5879: GCC has supported C++11 ref-qualifiers since 4.8.1.

Updating D5879: GCC has supported C++11 ref-qualifiers since 4.8.1

Oct 21 2014, 11:29 AM
chilledheart added a reviewer for D5879: GCC has supported C++11 ref-qualifiers since 4.8.1: chandlerc.
Oct 21 2014, 3:13 AM
chilledheart added a comment to D5879: GCC has supported C++11 ref-qualifiers since 4.8.1.

more information about this is from gcc changelog (4.8): https://gcc.gnu.org/gcc-4.8/changes.html#cxx

Oct 21 2014, 1:52 AM
chilledheart retitled D5879: GCC has supported C++11 ref-qualifiers since 4.8.1 from to GCC has support C++11 ref-qualifiers since 4.8.1.
Oct 21 2014, 1:51 AM

Oct 10 2014

chilledheart updated subscribers of D5592: LLDB AddressSanitizer break on error and report data extraction.
Oct 10 2014, 6:12 PM
chilledheart updated subscribers of rL219546: LLDB AddressSanitizer instrumentation runtime plugin, breakpint on error and….
Oct 10 2014, 6:12 PM

May 26 2014

chilledheart added a comment to D3910: [lldb] Build lldb-mi with cmake on Linux only.

lldb is built (with lldb-mi) successfuly.

May 26 2014, 7:43 PM
chilledheart added a comment to D3910: [lldb] Build lldb-mi with cmake on Linux only.

In fact, lldb-mi prevents lldb from being built with cmake(Ninja) under osx 10.9.
Below is part of building log:

May 26 2014, 6:12 AM
chilledheart retitled D3910: [lldb] Build lldb-mi with cmake on Linux only from to [lldb] Build lldb-mi with cmake on Linux only.
May 26 2014, 5:58 AM