Page MenuHomePhabricator

chfast (Paweł Bylica)
User

Projects

User does not belong to any projects.

User Details

User Since
May 16 2014, 8:34 AM (296 w, 3 d)

Recent Activity

Nov 19 2019

chfast abandoned D70012: [DAGCombiner] Propagate carry flag for 3+ additions.

Thanks for comments @deadalnix, but please review D70079. I'm closing this one as being the duplicate of the mentioned PR.

Nov 19 2019, 11:23 PM · Restricted Project
chfast added inline comments to D70079: [SelectionDAG] Combine U{ADD,SUB}O diamonds into {ADD,SUB}CARRY.
Nov 19 2019, 12:45 AM · Restricted Project
chfast committed rGd593292f0465: [X86] Add more addcarry tests (authored by chfast).
[X86] Add more addcarry tests
Nov 19 2019, 12:10 AM
chfast closed D70237: [X86] Add more addcarry tests.
Nov 19 2019, 12:10 AM · Restricted Project

Nov 18 2019

chfast updated the diff for D70237: [X86] Add more addcarry tests.

Fix typo

Nov 18 2019, 11:58 PM · Restricted Project
chfast added a comment to D70237: [X86] Add more addcarry tests.

Thanks for the update. Where is the original source for sub_U256_without_i128_or_recursive? The IR is strange. It seems to use two different strategies for merging carry flags.

Nov 18 2019, 6:13 AM · Restricted Project
chfast updated the diff for D70237: [X86] Add more addcarry tests.

Remove URLs

Nov 18 2019, 6:12 AM · Restricted Project
chfast added a reviewer for D70079: [SelectionDAG] Combine U{ADD,SUB}O diamonds into {ADD,SUB}CARRY: chfast.
Nov 18 2019, 5:54 AM · Restricted Project
chfast added a comment to D70237: [X86] Add more addcarry tests.

I ended up with optimizing my bigint library. The end result is - add_U256_without_i128_or_recursive which works better in current LLVM release and is also nicely reduced by D70079.
The analogous implementations of subtraction is added as sub_U256_without_i128_or_recursive test. This one should be interested to you @davezarzycki, your changes make it better, but it looks it is not perfect yet.

Nov 18 2019, 3:59 AM · Restricted Project
chfast updated the diff for D70237: [X86] Add more addcarry tests.

Update addcarry tests and add a subcarry test

Nov 18 2019, 3:06 AM · Restricted Project

Nov 15 2019

chfast added a comment to D70237: [X86] Add more addcarry tests.

Yes, please update subcarry.ll too.

Nov 15 2019, 2:59 AM · Restricted Project
chfast added a comment to D70237: [X86] Add more addcarry tests.

A few comments / questions:

  1. I'm not a regular contributor to LLVM, so please wait for somebody else (like @craig.topper, @RKSimon, or @spatel) to sign off on this.
  2. Once one has "add carry", one immediately wants "sub carry/borrow". Please consider adding tests to subcarry.ll.
Nov 15 2019, 1:15 AM · Restricted Project
chfast updated the diff for D70237: [X86] Add more addcarry tests.

Add comments more descriptive test names

Nov 15 2019, 1:08 AM · Restricted Project

Nov 14 2019

chfast created D70237: [X86] Add more addcarry tests.
Nov 14 2019, 5:39 AM · Restricted Project
chfast added a comment to D70079: [SelectionDAG] Combine U{ADD,SUB}O diamonds into {ADD,SUB}CARRY.

Oh sh*i, this is the same thing I'm doing in https://reviews.llvm.org/D70012.

Nov 14 2019, 5:20 AM · Restricted Project
chfast committed rG9b89bda517cf: [DAGCombiner] Use TLI field already available. NFC (authored by chfast).
[DAGCombiner] Use TLI field already available. NFC
Nov 14 2019, 5:13 AM
chfast committed rG1c247dd028b3: [DAGCombiner] Drop redundant DAG method param. NFC (authored by chfast).
[DAGCombiner] Drop redundant DAG method param. NFC
Nov 14 2019, 5:04 AM

Nov 8 2019

chfast created D70012: [DAGCombiner] Propagate carry flag for 3+ additions.
Nov 8 2019, 8:35 AM · Restricted Project

Sep 5 2019

chfast committed rL371052: Request commit access for chfast.
Request commit access for chfast
Sep 5 2019, 3:42 AM

Feb 7 2019

chfast updated the diff for D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.

Another round of changes.

Feb 7 2019, 10:43 AM · Restricted Project

Feb 5 2019

chfast updated the diff for D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.

Update unit tests.

Feb 5 2019, 6:28 AM · Restricted Project
chfast updated the diff for D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.

Hi again,

Feb 5 2019, 5:24 AM · Restricted Project

Jan 3 2019

chfast added a comment to D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.

I did a small update.

Jan 3 2019, 1:47 PM · Restricted Project
chfast updated the diff for D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.

Update with some intermidiate changes.

Jan 3 2019, 1:32 PM · Restricted Project
chfast added a parent revision for D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128: D56277: AggressiveInstCombine: Add tests for full multiplication pattern match.
Jan 3 2019, 10:31 AM · Restricted Project
chfast added a child revision for D56277: AggressiveInstCombine: Add tests for full multiplication pattern match: D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.
Jan 3 2019, 10:31 AM
chfast added inline comments to D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.
Jan 3 2019, 10:30 AM · Restricted Project
chfast added inline comments to D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.
Jan 3 2019, 9:50 AM · Restricted Project
chfast updated the summary of D56277: AggressiveInstCombine: Add tests for full multiplication pattern match.
Jan 3 2019, 9:47 AM
chfast created D56277: AggressiveInstCombine: Add tests for full multiplication pattern match.
Jan 3 2019, 9:42 AM
chfast abandoned D56276: AggressiveInstCombine: Add tests for full multiplication pattern match.
Jan 3 2019, 9:02 AM
chfast created D56276: AggressiveInstCombine: Add tests for full multiplication pattern match.
Jan 3 2019, 9:02 AM

Jan 2 2019

chfast added inline comments to D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.
Jan 2 2019, 3:55 PM · Restricted Project
chfast added a comment to D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.

Also, i don't think this should be hardcoded to some particular bitwidth.

Jan 2 2019, 2:28 PM · Restricted Project
chfast added inline comments to D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.
Jan 2 2019, 12:33 PM · Restricted Project
chfast updated the summary of D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.
Jan 2 2019, 12:24 PM · Restricted Project
chfast created D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.
Jan 2 2019, 12:16 PM · Restricted Project
chfast committed rL350256: Git ignore CLion project configuration files. NFC.
Git ignore CLion project configuration files. NFC
Jan 2 2019, 12:01 PM
chfast committed rL350255: Format AggresiveInstCombine.cpp. NFC.
Format AggresiveInstCombine.cpp. NFC
Jan 2 2019, 11:55 AM

Dec 8 2017

chfast added inline comments to D14104: clang-format: Add an additional value to AlignAfterOpenBracket: AlwaysBreak..
Dec 8 2017, 7:13 AM

May 9 2017

chfast accepted D32829: Make RuntimeDyld::MemoryManager responsible for tracking EH frames..
May 9 2017, 10:36 AM
chfast added inline comments to D32829: Make RuntimeDyld::MemoryManager responsible for tracking EH frames..
May 9 2017, 6:18 AM

May 8 2017

chfast added inline comments to D32829: Make RuntimeDyld::MemoryManager responsible for tracking EH frames..
May 8 2017, 1:26 PM

Jan 22 2017

chfast added a comment to D28986: [APInt] Remove calls to clearUnusedBits from XorSlowCase and operator^=.

Looks good, but adding an unit test for this case would be nice...

Jan 22 2017, 11:20 AM
chfast added a comment to D28990: Align i128 to 16 bytes.

Will not that penalize stack usage on 64-bit targets as well?

Jan 22 2017, 10:57 AM
chfast added a comment to D28990: Align i128 to 16 bytes.

Does this affects also bigger types like i256?

Jan 22 2017, 6:54 AM

Nov 28 2016

chfast committed rL288086: Merging r286998:.
Merging r286998:
Nov 28 2016, 2:55 PM
chfast committed rL288085: Merging r281403:.
Merging r281403:
Nov 28 2016, 2:52 PM

Nov 15 2016

chfast accepted rL270720: [SDAG] Add a fallback multiplication expansion.

Fixed in https://reviews.llvm.org/rL286998.

Nov 15 2016, 10:41 AM
chfast committed rL286998: Integer legalization: fix MUL expansion.
Integer legalization: fix MUL expansion
Nov 15 2016, 10:39 AM
chfast closed D26628: Integer legalization: fix MUL expansion by committing rL286998: Integer legalization: fix MUL expansion.
Nov 15 2016, 10:39 AM
chfast added a comment to D26628: Integer legalization: fix MUL expansion.

Ping.

Nov 15 2016, 7:34 AM
chfast raised a concern with rL270720: [SDAG] Add a fallback multiplication expansion.

The algorithm is not correct. I fixed it in https://reviews.llvm.org/D26628.

Nov 15 2016, 5:12 AM

Nov 14 2016

chfast retitled D26628: Integer legalization: fix MUL expansion from to Integer legalization: fix MUL expansion.
Nov 14 2016, 12:20 PM

Sep 26 2016

chfast added a comment to rL270720: [SDAG] Add a fallback multiplication expansion.

This produces incorrect results for my set of tests of mul i256. Can you explain how you tested it? I guess there is no chance for adding runtime tests for that?

Sep 26 2016, 8:29 AM

Sep 13 2016

chfast committed rL281403: [CodeGen] Fix invalid shift in mul expansion.
[CodeGen] Fix invalid shift in mul expansion
Sep 13 2016, 3:04 PM
chfast closed D24478: [CodeGen] Fix invalid shift in mul expansion by committing rL281403: [CodeGen] Fix invalid shift in mul expansion.
Sep 13 2016, 3:04 PM
chfast updated the diff for D24478: [CodeGen] Fix invalid shift in mul expansion.

Add nounwind attribute to make tests smaller

Sep 13 2016, 12:54 PM
chfast updated the diff for D24478: [CodeGen] Fix invalid shift in mul expansion.

Update tests

Sep 13 2016, 5:27 AM
chfast added inline comments to D24478: [CodeGen] Fix invalid shift in mul expansion.
Sep 13 2016, 4:26 AM
chfast abandoned D14959: [Support] Add path::temp_directory() function..
Sep 13 2016, 1:02 AM
chfast added a reviewer for D22619: Simplify error reporting in YAMLParser: anemet.

As you are doing something with YAML, can you take a look here?

Sep 13 2016, 1:01 AM
chfast added a reviewer for D22565: YAMLParser: report errors according to provided position: anemet.

As you are doing something with YAML, can you take a look here?

Sep 13 2016, 1:01 AM

Sep 12 2016

chfast abandoned D9372: [IRBuilder] A method for creating a vector from scalar values.
Sep 12 2016, 3:37 PM
chfast retitled D24478: [CodeGen] Fix invalid shift in mul expansion from to [CodeGen] Fix invalid shift in mul expansion.
Sep 12 2016, 3:36 PM
chfast added a comment to rL270720: [SDAG] Add a fallback multiplication expansion.

I tried something similar in https://reviews.llvm.org/D8770

Sep 12 2016, 9:04 AM

Sep 8 2016

chfast added a comment to D22565: YAMLParser: report errors according to provided position.

Ping².

Sep 8 2016, 12:38 AM
chfast added a comment to D22619: Simplify error reporting in YAMLParser.

Ping².

Sep 8 2016, 12:38 AM

Aug 28 2016

chfast added a comment to D23965: Add StringRef::keep_front() and StringRef::keep_back().

Sounds like a useful API. The term I've heard of in other programing languages is "take", I think take_front and take_back might be a little nicer.

take_front sounds ok, but take_back sounds awkward to me. I almost want to say "take what back?" If the convention was drop and rdrop, then take and rtake would sound good, but I'm not crazy about take_front and take_back. I could probably be convinced though if the majority prefers it.

Aug 28 2016, 2:26 PM

Aug 18 2016

chfast added a comment to D22619: Simplify error reporting in YAMLParser.

Ping.

Aug 18 2016, 1:27 PM

Jul 23 2016

chfast added inline comments to D22619: Simplify error reporting in YAMLParser.
Jul 23 2016, 12:29 PM

Jul 22 2016

chfast added a comment to D22565: YAMLParser: report errors according to provided position.

Please see the alternative https://reviews.llvm.org/D22619.

Jul 22 2016, 3:51 AM

Jul 21 2016

chfast retitled D22619: Simplify error reporting in YAMLParser from to Simplify error reporting in YAMLParser.
Jul 21 2016, 3:02 AM

Jul 20 2016

chfast added a comment to D22565: YAMLParser: report errors according to provided position.

Ok, thanks. Any thoughts about the alternative "solution"?

Jul 20 2016, 1:10 PM
chfast retitled D22565: YAMLParser: report errors according to provided position from to YAMLParser: report errors according to provided position.
Jul 20 2016, 3:58 AM

Jun 27 2016

chfast committed rL273852: CachePruning: correct comment about file order. NFC.
CachePruning: correct comment about file order. NFC
Jun 27 2016, 1:53 AM
chfast closed D21639: CachePruning: correct comment about file order. NFC by committing rL273852: CachePruning: correct comment about file order. NFC.
Jun 27 2016, 1:53 AM
chfast committed rL273851: APInt: remove unsued param in private method. NFC.
APInt: remove unsued param in private method. NFC
Jun 27 2016, 1:39 AM
chfast closed D21638: APInt: remove unsued param in private method. NFC by committing rL273851: APInt: remove unsued param in private method. NFC.
Jun 27 2016, 1:38 AM

Jun 24 2016

chfast added reviewers for D21639: CachePruning: correct comment about file order. NFC: davide, chandlerc.
Jun 24 2016, 1:03 AM

Jun 23 2016

chfast added auditors to rL251784: [Support] Extend sys::path with user_cache_directory function.: silvas.
Jun 23 2016, 2:51 PM
chfast added a reviewer for D21639: CachePruning: correct comment about file order. NFC: joker-eph-DISABLED.
Jun 23 2016, 1:11 PM
chfast retitled D21639: CachePruning: correct comment about file order. NFC from to CachePruning: correct comment about file order. NFC.
Jun 23 2016, 2:54 AM
chfast retitled D21638: APInt: remove unsued param in private method. NFC from to APInt: remove unsued param in private method. NFC.
Jun 23 2016, 2:51 AM

Jun 22 2016

chfast committed rL273493: Do not require __STDC_LIMIT_MACROS and others.
Do not require __STDC_LIMIT_MACROS and others
Jun 22 2016, 2:43 PM
chfast closed D21553: Do not require __STDC_LIMIT_MACROS and others by committing rL273493: Do not require __STDC_LIMIT_MACROS and others.
Jun 22 2016, 2:23 PM
chfast added a comment to D21553: Do not require __STDC_LIMIT_MACROS and others.

Anyway, I think is it good point to at least separate the changes as you suggested.

Jun 22 2016, 10:40 AM
chfast updated the diff for D21553: Do not require __STDC_LIMIT_MACROS and others.

Leave defines config as it was before.

Jun 22 2016, 4:06 AM
chfast added a comment to D21553: Do not require __STDC_LIMIT_MACROS and others.

Not requiring the defines is good; removing the defines in the build files is not. We still want to be able to build out of the box on systems with this known brokenness.

Jun 22 2016, 4:01 AM

Jun 21 2016

chfast added a comment to D21553: Do not require __STDC_LIMIT_MACROS and others.

Is there a way to test this commit on buildbot before merging it?

Jun 21 2016, 5:11 AM
chfast added reviewers for D21553: Do not require __STDC_LIMIT_MACROS and others: jyknight, joerg.
Jun 21 2016, 5:10 AM
chfast retitled D21553: Do not require __STDC_LIMIT_MACROS and others from to Do not require __STDC_LIMIT_MACROS and others.
Jun 21 2016, 5:08 AM
chfast added a comment to rL251784: [Support] Extend sys::path with user_cache_directory function..

This has been fixed in rL264352.

Jun 21 2016, 4:54 AM

May 25 2016

chfast added a comment to rL270720: [SDAG] Add a fallback multiplication expansion.

Thanks for adding that. Does it handle only 256-bit integers?

May 25 2016, 12:03 PM

Jan 26 2016

chfast updated subscribers of D16471: Remove autoconf support.
Jan 26 2016, 12:11 PM

Jan 19 2016

chfast added reviewers for D14446: Fallback to getpwuid() in path::home_directory() on Unix.: pcc, majnemer, yaron.keren.

Added authors/reviewers of original patch adding home_directory() function in http://reviews.llvm.org/D2199

Jan 19 2016, 2:18 AM

Jan 7 2016

chfast added a comment to D14446: Fallback to getpwuid() in path::home_directory() on Unix..

E.g. in llvm-lit testing environment.

Isn't the intention precisely to avoid tests creating files in the
home directory or being dependent on global config entries?

Cheers,
Rafael

Jan 7 2016, 8:47 AM

Nov 25 2015

chfast added inline comments to D14446: Fallback to getpwuid() in path::home_directory() on Unix..
Nov 25 2015, 5:57 AM
chfast added inline comments to D14959: [Support] Add path::temp_directory() function..
Nov 25 2015, 5:55 AM
chfast added a comment to D14446: Fallback to getpwuid() in path::home_directory() on Unix..

Can you give an overview of when the HOME environment variable is not defined?

Nov 25 2015, 4:59 AM