User Details
- User Since
- May 16 2014, 8:34 AM (488 w, 2 d)
Aug 3 2023
Are you able to add any tests supporting this?
Jul 22 2023
Jul 19 2023
Removed TODO comments from tests.
Update tests with --check-globals
Rebased on new tests cases.
Focus on select+binop, add more test cases.
Jul 18 2023
Jul 17 2023
Jul 14 2023
Jun 14 2023
Thanks for working on this and good luck.
Feb 8 2023
Jan 13 2023
Nov 28 2022
Nov 27 2022
Rebased.
Nov 24 2022
Nov 2 2022
Oct 25 2022
LGTM, but I'd wait for one more review.
Oct 24 2022
Oct 23 2022
Oct 22 2022
Oct 21 2022
In https://reviews.llvm.org/D56214 similar pattern match was applied in AggressiveInstCombine.
Oct 7 2022
Oct 2 2022
Is it fine I commit this?
Oct 1 2022
Rebased.
I added tests for this change.
https://reviews.llvm.org/rGe399c5877801
https://github.com/llvm/llvm-project/commit/e399c58778017388a818cabd1b13fcb88b79a432
Aug 23 2022
Aug 18 2022
Rebased.
Should I try to push this by adding a TTI flag like "CmpULTsetsCarryFlag"?
May 16 2022
Looks very nice, thanks.
Mar 14 2022
On the high level note, using builtin_subc() or builtin_sub_with_overflow() is good enough workaround.
Feb 25 2022
Feb 23 2022
Feb 21 2022
Rebased.
This was intermediate change to solve https://github.com/llvm/llvm-project/issues/53432. There I want to merge sub + cmp into single sbb. Any suggestions how to solve it differently?
Feb 16 2022
Jan 28 2022
Jan 27 2022
Jan 26 2022
What I try to do in the end is to fix https://github.com/llvm/llvm-project/issues/53432. Maybe this particular change is not good direction, but on the other hand it also helps with the test add_U320_without_i128_add already in repo.
Jan 25 2022
Use switch. Rebased.
Address review comments.
What do you think about this idea in general? Can we assume or check if SETULT actually affects CL flag on given target?
Jan 24 2022
Jan 22 2022
I have noticed this post about undef/poison: https://llvm.discourse.group/t/evolution-of-undef-and-poison-over-time/5917/2.
Should I have added tests with poison instead of undef?
Jan 20 2022
Trigger rebuild.