Another round of changes.

Update unit tests.

Hi again,

I did a small update.

Update with some intermidiate changes.

In D56214#1344055, @lebedev.ri wrote:

Also, i don't think this should be hardcoded to some particular bitwidth.

Looks good, but adding an unit test for this case would be nice...

Will not that penalize stack usage on 64-bit targets as well?

Does this affects also bigger types like i256?

Fixed in https://reviews.llvm.org/rL286998.

Ping.

The algorithm is not correct. I fixed it in https://reviews.llvm.org/D26628.

This produces incorrect results for my set of tests of mul i256. Can you explain how you tested it? I guess there is no chance for adding runtime tests for that?

Add nounwind attribute to make tests smaller

Update tests

As you are doing something with YAML, can you take a look here?

As you are doing something with YAML, can you take a look here?

I tried something similar in https://reviews.llvm.org/D8770

Ping².

Ping².

In D23965#527297, @zturner wrote:

In D23965#527296, @majnemer wrote:

Sounds like a useful API. The term I've heard of in other programing languages is "take", I think take_front and take_back might be a little nicer.

take_front sounds ok, but take_back sounds awkward to me. I almost want to say "take what back?" If the convention was drop and rdrop, then take and rtake would sound good, but I'm not crazy about take_front and take_back. I could probably be convinced though if the majority prefers it.

Ping.

Please see the alternative https://reviews.llvm.org/D22619.

Ok, thanks. Any thoughts about the alternative "solution"?

Anyway, I think is it good point to at least separate the changes as you suggested.

Leave defines config as it was before.

In D21553#463304, @jyknight wrote:

Not requiring the defines is good; removing the defines in the build files is not. We still want to be able to build out of the box on systems with this known brokenness.

Is there a way to test this commit on buildbot before merging it?

This has been fixed in rL264352.

Thanks for adding that. Does it handle only 256-bit integers?

Added authors/reviewers of original patch adding home_directory() function in http://reviews.llvm.org/D2199

In D14446#296637, @rafael wrote:

E.g. in llvm-lit testing environment.

Isn't the intention precisely to avoid tests creating files in the
home directory or being dependent on global config entries?

Cheers,
Rafael

In D14446#296010, @rafael wrote:

Can you give an overview of when the HOME environment variable is not defined?

Gentle ping. This patch includes a small unit test helpers refactoring that I would like to use in other patches.

Refactor unit test helpers. Check if pwh.h is available in every place that requires it.

It turned out Windows 7 is affected by 130 bytes env var issue. Windows 8 is fine. Sorry for not checking that correctly in the first place as I was supposed to do.

Unit tests updated. They now run in separated process using GTest Death Tests.

Thanks for quick checking.

About the example. Currently it is:
clang-%%-%%-%%-%%-%%.s => clang-a0-b1-c2-d3-e4.s.
With your changes it should be something like:
clang-%%-%%-%%-%%-%%.s => /tmp/clang-a0-b1-c2-d3-e4.s.

I'm not sure about the change. I think both cases (creating a file in the current and in the system temp directory) should be supported.