Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People chaosdefinition

chaosdefinition (Zhuojia Shen)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2020, 9:28 PM (152 w, 22 h)

Recent Activity
View All

Fri, Sep 22

chaosdefinition added a reverting change for rG0def4e6b0f63: Revert "[AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre": rGbcc5b48b0f24: Reapply "[AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre".
Fri, Sep 22, 9:09 PM · Restricted Project, Restricted Project
chaosdefinition committed rGbcc5b48b0f24: Reapply "[AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre" (authored by chaosdefinition).
Reapply "[AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre"
Fri, Sep 22, 9:09 PM · Restricted Project, Restricted Project
chaosdefinition added a reverting change for D156328: Revert "[AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre": rGbcc5b48b0f24: Reapply "[AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre".
Fri, Sep 22, 9:09 PM · Restricted Project, Restricted Project
chaosdefinition closed D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..
Fri, Sep 22, 9:09 PM · Restricted Project, Restricted Project
chaosdefinition added a comment to D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..
In D152407#4642721, @dmgreen wrote:

The same revision should be OK, if the change is just a fix to the existing patch.

I had a look through the LoadStoreOptimizer. If you don't think there are any other cases this can go wrong them it LGTM.

Fri, Sep 22, 9:07 PM · Restricted Project, Restricted Project

Fri, Sep 8

chaosdefinition added a comment to D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..
In D152407#4625772, @scw wrote:

Test case LGTM, I don't have enough knowledge for the code to know if the proposed fix is the best way though.

Also, should this change reuse the same D number or should we create a new one?

Fri, Sep 8, 9:02 PM · Restricted Project, Restricted Project

Aug 25 2023

chaosdefinition updated the diff for D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..

Hi, I'm reopening this with the following updates:

  • Apply the quick fix described in D152407#4534022 that disallows merging two pre-indexed loads, assuming there's no better approach.
  • Add MIR regression tests modified from @scw's reproduction .
Aug 25 2023, 5:37 PM · Restricted Project, Restricted Project

Jul 26 2023

chaosdefinition reopened D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..
Jul 26 2023, 2:25 PM · Restricted Project, Restricted Project

Jul 25 2023

chaosdefinition added a comment to D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..
In D152407#4531841, @eaeltsin wrote:

Heads-up - this caused multiple segmentation faults in our code base. We are working on a reproducer.

Jul 25 2023, 9:04 PM · Restricted Project, Restricted Project

Jul 18 2023

chaosdefinition committed rGb0093e13fcfd: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre (authored by chaosdefinition).
[AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre
Jul 18 2023, 9:47 AM · Restricted Project, Restricted Project
chaosdefinition committed rG94f76004d53d: [AArch64] Add tests for merging LDRSWpre-LDR pairs (authored by chaosdefinition).
[AArch64] Add tests for merging LDRSWpre-LDR pairs
Jul 18 2023, 9:47 AM · Restricted Project, Restricted Project
chaosdefinition closed D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..
Jul 18 2023, 9:47 AM · Restricted Project, Restricted Project
chaosdefinition closed D152564: [AArch64] Add tests for merging LDRSWpre-LDR pairs.
Jul 18 2023, 9:47 AM · Restricted Project, Restricted Project

Jul 17 2023

chaosdefinition added a comment to D152564: [AArch64] Add tests for merging LDRSWpre-LDR pairs.

Ping...

Jul 17 2023, 9:53 PM · Restricted Project, Restricted Project
chaosdefinition added a comment to D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..

Ping...

Jul 17 2023, 9:52 PM · Restricted Project, Restricted Project

Jun 22 2023

chaosdefinition added a comment to D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..
In D152407#4423993, @dmgreen wrote:

Can you add a test where getMatchingNonSExtOpcode would be true, and we could turn into a ldp+sext? I'm not sure if it will actually happen at the moment with pre nodes. LDRSWpre + LDRWui and maybe LDRWpre + LDRSWui

Jun 22 2023, 9:48 AM · Restricted Project, Restricted Project
chaosdefinition updated the diff for D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..

Update the patch to be based on the updated D152564, no functionality change.

Jun 22 2023, 9:43 AM · Restricted Project, Restricted Project
chaosdefinition updated the diff for D152564: [AArch64] Add tests for merging LDRSWpre-LDR pairs.

Add test cases of LDRSWpre + LDRWui and LDRWpre + LDRSWui, addressing @dmgreen's comment D152407#4423993.

Jun 22 2023, 9:38 AM · Restricted Project, Restricted Project

Jun 9 2023

chaosdefinition updated the diff for D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..

Addressing comments by @fhahn:

Jun 9 2023, 10:41 AM · Restricted Project, Restricted Project
chaosdefinition requested review of D152564: [AArch64] Add tests for merging LDRSWpre-LDR pairs.
Jun 9 2023, 10:30 AM · Restricted Project, Restricted Project

Jun 8 2023

chaosdefinition added inline comments to D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..
Jun 8 2023, 4:36 PM · Restricted Project, Restricted Project

Jun 7 2023

chaosdefinition requested review of D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre..
Jun 7 2023, 4:18 PM · Restricted Project, Restricted Project

Feb 10 2023

chaosdefinition committed rT57500d700a57: [SPEC2017] Run image validator with TEST_SUITE_RUN_UNDER (authored by chaosdefinition).
[SPEC2017] Run image validator with TEST_SUITE_RUN_UNDER
Feb 10 2023, 10:59 AM · Restricted Project
chaosdefinition closed D139660: [SPEC2017] Run image validator with TEST_SUITE_RUN_UNDER.
Feb 10 2023, 10:59 AM · Restricted Project

Dec 19 2022

chaosdefinition added a comment to D139660: [SPEC2017] Run image validator with TEST_SUITE_RUN_UNDER.

Ping before the holiday...

Dec 19 2022, 9:34 AM · Restricted Project

Dec 8 2022

chaosdefinition committed rT361a7aa2097c: [SPEC2017] Add -fcommon to build ldecod in x264 (authored by chaosdefinition).
[SPEC2017] Add -fcommon to build ldecod in x264
Dec 8 2022, 7:31 PM · Restricted Project
chaosdefinition closed D139658: [SPEC2017] Add -fcommon to build ldecod in x264.
Dec 8 2022, 7:31 PM · Restricted Project
chaosdefinition requested review of D139660: [SPEC2017] Run image validator with TEST_SUITE_RUN_UNDER.
Dec 8 2022, 12:05 PM · Restricted Project
chaosdefinition requested review of D139658: [SPEC2017] Add -fcommon to build ldecod in x264.
Dec 8 2022, 11:45 AM · Restricted Project

Jan 26 2021

chaosdefinition committed rG8cef45517e47: [ARM] Fix STRT/STRHT/STRBT input/output operands. (authored by chaosdefinition).
[ARM] Fix STRT/STRHT/STRBT input/output operands.
Jan 26 2021, 2:01 PM
chaosdefinition closed D95074: [ARM] Fix STRT/STRHT/STRBT input/output operands.
Jan 26 2021, 2:01 PM · Restricted Project

Jan 20 2021

chaosdefinition requested review of D95074: [ARM] Fix STRT/STRHT/STRBT input/output operands.
Jan 20 2021, 11:51 AM · Restricted Project

Dec 4 2020

chaosdefinition committed rG24333481cb23: [builtins][ARM] Check __ARM_FP instead of __VFP_FP__. (authored by chaosdefinition).
[builtins][ARM] Check __ARM_FP instead of __VFP_FP__.
Dec 4 2020, 8:55 PM
chaosdefinition closed D92497: [builtins][ARM] Check __ARM_FP instead of __VFP_FP__..
Dec 4 2020, 8:54 PM · Restricted Project

Dec 2 2020

chaosdefinition added a comment to D92497: [builtins][ARM] Check __ARM_FP instead of __VFP_FP__..
In D92497#2429662, @compnerd wrote:

Following the ACLE is definitely preferable. One thing to verify is if gcc does support this correctly as well. IIRC, it does support __ARM_FP properly and this should be safe, but please do verify that.

Dec 2 2020, 9:16 PM · Restricted Project
chaosdefinition requested review of D92497: [builtins][ARM] Check __ARM_FP instead of __VFP_FP__..
Dec 2 2020, 10:29 AM · Restricted Project

Nov 12 2020

chaosdefinition added a comment to D90698: [builtins] Add support for single-precision-only-FPU ARM targets..
In D90698#2390693, @psmith wrote:
In D90698#2389872, @chaosdefinition wrote:

If there are no more comments, can someone please commit this for me? I don't have commit access to LLVM.

That's a little complicated for me as I need to go through various internal company procedures to commit something I didn't write. I can do this but it will take time, if there are any others that can do it faster then please do.

Nov 12 2020, 3:19 PM · Restricted Project

Nov 11 2020

chaosdefinition added a comment to D90698: [builtins] Add support for single-precision-only-FPU ARM targets..

If there are no more comments, can someone please commit this for me? I don't have commit access to LLVM.

Nov 11 2020, 2:27 PM · Restricted Project

Nov 4 2020

chaosdefinition added a comment to D90698: [builtins] Add support for single-precision-only-FPU ARM targets..

@psmith Thank you for reviewing! I'll wait a few days for other comments.

Nov 4 2020, 10:49 AM · Restricted Project

Nov 3 2020

chaosdefinition requested review of D90698: [builtins] Add support for single-precision-only-FPU ARM targets..
Nov 3 2020, 11:12 AM · Restricted Project