Page MenuHomePhabricator

cbiesinger (Christian Biesinger)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2019, 3:25 PM (119 w, 5 d)

Recent Activity

Aug 20 2019

cbiesinger added a comment to D65983: Autogenerate the shebang lines for tools/opt-viewer.

Thank you! I am not a committer, could one of you land this?

Aug 20 2019, 5:00 PM · Restricted Project
cbiesinger added a comment to D65983: Autogenerate the shebang lines for tools/opt-viewer.

Ping? I think this version is a good compromise that will work well both for binary distributions and compiling from source...

Aug 20 2019, 2:18 PM · Restricted Project

Aug 16 2019

cbiesinger added a comment to D65983: Autogenerate the shebang lines for tools/opt-viewer.

I'm not sure that such a python3 vs 3.5 difference matters, but anyway, here's a version that does arguably the right thing.

Aug 16 2019, 3:39 PM · Restricted Project
cbiesinger updated the diff for D65983: Autogenerate the shebang lines for tools/opt-viewer.

Use python's basename

Aug 16 2019, 3:37 PM · Restricted Project
cbiesinger added a comment to D65983: Autogenerate the shebang lines for tools/opt-viewer.

It actually worked with the env for me.

Aug 16 2019, 3:15 PM · Restricted Project
cbiesinger updated the diff for D65983: Autogenerate the shebang lines for tools/opt-viewer.

Use python@PYTHON_VERSION_MAJOR@

Aug 16 2019, 3:14 PM · Restricted Project

Aug 8 2019

cbiesinger created D65983: Autogenerate the shebang lines for tools/opt-viewer.
Aug 8 2019, 4:19 PM · Restricted Project

Aug 5 2019

cbiesinger added a comment to D64894: [CMake] Don't set Python_ADDITIONAL_VERSIONS.

Should this be merged to LLVM 9?

Aug 5 2019, 9:58 AM · Restricted Project, Restricted Project

Jul 18 2019

cbiesinger added a comment to D64894: [CMake] Don't set Python_ADDITIONAL_VERSIONS.

Preferring Python 3, if present, was actually intentional on my behalf on the basis that we should use the newer Python if we can. But I did not realize this would break MacOS :( (and, it sounds like, any system where you have a python 3 binary but not devel package?)

Jul 18 2019, 11:52 AM · Restricted Project, Restricted Project

Jul 17 2019

cbiesinger added a comment to D64443: Add support for building with Python 3.

pree-jackie: My guess is that you have python2.7-dev installed but not python3.6-dev -- does it work if you install that one?

Jul 17 2019, 7:56 AM · Restricted Project

Jul 12 2019

cbiesinger added a comment to D64578: Make Python version setting actually effective.

Thanks! Could you/someone land this? I'm not a committer.

Jul 12 2019, 5:25 PM · Restricted Project
cbiesinger added a comment to D64578: Make Python version setting actually effective.

How about this, then? It does seem to work.

Jul 12 2019, 4:58 PM · Restricted Project
cbiesinger retitled D64578: Make Python version setting actually effective from Set Python versions also in LLDBConfig.cmake to Make Python version setting actually effective.
Jul 12 2019, 4:57 PM · Restricted Project
cbiesinger updated the diff for D64578: Make Python version setting actually effective.

Move the version list outside of the strequal "" check

Jul 12 2019, 4:56 PM · Restricted Project

Jul 11 2019

cbiesinger added a comment to D64578: Make Python version setting actually effective.

Yes, this does not seem to be used when building as part of LLVM, only standalone.

Jul 11 2019, 3:08 PM · Restricted Project
cbiesinger updated the diff for D64578: Make Python version setting actually effective.

Match LLVM and remove the line from LLDBStandalone

Jul 11 2019, 3:05 PM · Restricted Project
cbiesinger created D64578: Make Python version setting actually effective.
Jul 11 2019, 11:51 AM · Restricted Project

Jul 10 2019

cbiesinger added a comment to D64373: Don't use PyInt on Python 3.

Yeah. (I thought I did? I'm not super familiar with this interface)

Jul 10 2019, 11:53 AM · Restricted Project
cbiesinger added a comment to D64444: Add Python 3.6 and 3.7 to the version list.

Thanks Greg! I'm not a committer -- how do I get this committed?

Jul 10 2019, 11:49 AM · Restricted Project, Restricted Project

Jul 9 2019

cbiesinger added inline comments to D64443: Add support for building with Python 3.
Jul 9 2019, 1:48 PM · Restricted Project
cbiesinger updated the diff for D64443: Add support for building with Python 3.

Add 3.7 and 3.5

Jul 9 2019, 1:48 PM · Restricted Project
cbiesinger added inline comments to D64443: Add support for building with Python 3.
Jul 9 2019, 1:34 PM · Restricted Project
cbiesinger created D64444: Add Python 3.6 and 3.7 to the version list.
Jul 9 2019, 1:11 PM · Restricted Project, Restricted Project
cbiesinger added a reviewer for D64443: Add support for building with Python 3: clayborg.
Jul 9 2019, 1:06 PM · Restricted Project
cbiesinger created D64443: Add support for building with Python 3.
Jul 9 2019, 1:06 PM · Restricted Project
cbiesinger added a comment to D64373: Don't use PyInt on Python 3.

Ah, this works because Swig (?) adds compatibility macros to LLDBWrapPython:
#define PyInt_Check(x) PyLong_Check(x)
#define PyInt_AsLong(x) PyLong_AsLong(x)
#define PyInt_FromLong(x) PyLong_FromLong(x)
#define PyInt_FromSize_t(x) PyLong_FromSize_t(x)
(etc)

Jul 9 2019, 12:20 PM · Restricted Project

Jul 8 2019

cbiesinger abandoned D64373: Don't use PyInt on Python 3.

It seems this wasn't necessary, I had just misconfigured my build. (I don't understand how this works though...)

Jul 8 2019, 3:50 PM · Restricted Project
cbiesinger created D64373: Don't use PyInt on Python 3.
Jul 8 2019, 3:33 PM · Restricted Project