- User Since
- Jul 15 2013, 12:44 AM (404 w, 18 h)
Feb 11 2016
Please take this comment as more a nitpick instead of having tested it
In general I see a lot of really dirty code - Why so many casts? What makes "long long" universally correct and portable.. are there standard types we can use to represent pointers?
Oct 14 2015
And does this hardcode the abi and break cxxrt? It's not just me who uses that
Jul 20 2015
Why is libffi a depdendency at all? What if it's not installed? What's
used on OSX and Windows? If it's performance impacting should a more
portable altenternative be explored?
Jun 26 2015
One of the previous comments in this thread was that there is an
assumption that libomp will be installed to /usr/lib or some system
directory. I absolutely don't believe that should be done. The
-fopenmp or equivalent flag should add the correct (private) includes
(C/C++/Fortran module) and -L/-rpath lib location. This is really
compiler internal and private. LLVM was the odd duck by relying on the
gcc OMP lib before. If llvm had Fortran support - that wouldn't likely
have ever happened from the start.
Jun 23 2015
Is this patch updated to reflect my review comments?
Sep 21 2014
From: Alexey Bataev
Sent: Monday, September 22, 2014 10:34
To: email@example.com; firstname.lastname@example.org; email@example.com; firstname.lastname@example.org; email@example.com; firstname.lastname@example.org; email@example.com; firstname.lastname@example.org
Reply To: reviews+D4002email@example.com
Subject: Re: [PATCH] [OPENMP] Codegen for threadprivate variables