Please take this comment as more a nitpick instead of having tested it

In general I see a lot of really dirty code - Why so many casts? What makes "long long" universally correct and portable.. are there standard types we can use to represent pointers?

‎And does this hardcode the abi and break cxxrt? It's not just me who uses that 

Why is libffi a depdendency at all? What if it's not installed? What's
used on OSX and Windows? If it's performance impacting should a more
portable altenternative be explored?

One of the previous comments in this thread was that there is an
assumption that libomp will be installed to /usr/lib or some system
directory. I absolutely don't believe that should be done. The
-fopenmp or equivalent flag should add the correct (private) includes
(C/C++/Fortran module) and -L/-rpath lib location. This is really
compiler internal and private. LLVM was the odd duck by relying on the
gcc OMP lib before. If llvm had Fortran support - that wouldn't likely
have ever happened from the start.

Is this patch updated to reflect my review comments?

  Original Message  
From: Alexey Bataev
Sent: Monday, September 22, 2014 10:34
To: a.bataev@hotmail.com; dgregor@apple.com; hfinkel@anl.gov; cbergstrom@pathscale.com; rjmccall@gmail.com; fraggamuffin@gmail.com; ejstotzer@gmail.com; richard@metafoo.co.uk
Reply To: reviews+D4002+public+e0b72e4194bfb02b@reviews.llvm.org
Cc: cfe-commits@cs.uiuc.edu
Subject: Re: [PATCH] [OPENMP] Codegen for threadprivate variables