Page MenuHomePhabricator

catskul (Andrew Somerville)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 21 2018, 8:18 AM (178 w, 2 d)

Recent Activity

Mon, Jun 28

catskul abandoned D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635).

Abandoning because of: https://reviews.llvm.org/D104096

Mon, Jun 28, 7:31 AM · Restricted Project, Restricted Project

May 6 2021

catskul added a comment to D33029: [clang-format] add option for dangling parenthesis.

@blandcr @jakar It's all good for me. Sorry for slow responses. My time to work on this is few and far between. I'm happy if anyone picks it up or any energy put into this. Would love to see it land.

May 6 2021, 10:02 AM · Restricted Project, Restricted Project

Oct 27 2020

catskul requested review of D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635).
Oct 27 2020, 8:15 AM · Restricted Project, Restricted Project
catskul requested review of D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484).
Oct 27 2020, 7:39 AM · Restricted Project, Restricted Project

Oct 26 2020

catskul abandoned D90209: add test for PAS_Right + RAS_Left + commentedout '* &' example.

Accidental creation of diff

Oct 26 2020, 10:33 PM · Restricted Project
catskul requested review of D90209: add test for PAS_Right + RAS_Left + commentedout '* &' example.
Oct 26 2020, 10:32 PM · Restricted Project
catskul added inline comments to D31635: [clang-format] Added ReferenceAlignmentStyle option.
Oct 26 2020, 9:43 PM · Restricted Project, Restricted Project, Restricted Project
catskul added inline comments to D31635: [clang-format] Added ReferenceAlignmentStyle option.
Oct 26 2020, 9:39 PM · Restricted Project, Restricted Project, Restricted Project
catskul added a comment to D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines.

@FStefanni, after managing to update this patch to work with the latest code, and trying out your example it appears this patch doesn't quite cover your case.

Oct 26 2020, 7:56 PM · Restricted Project, Restricted Project

Oct 25 2020

catskul added inline comments to D33029: [clang-format] add option for dangling parenthesis.
Oct 25 2020, 9:15 PM · Restricted Project, Restricted Project
catskul added a comment to D33029: [clang-format] add option for dangling parenthesis.

@MyDeveloperDay I'm going to upload a re-based version of this. Should I rebase it off the top of master? Tip of 11? and/or create a new diff/review for each?

Oct 25 2020, 12:34 PM · Restricted Project, Restricted Project

Oct 15 2020

catskul added a comment to D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines.

Hi to all,

I am also interested to this option, since match my personal style, but more important, in my experience, this kind of formatting is very used.
I hope it will be implemented in a near future.

Which is the current status? Is someone going to support this?

Regards.

Oct 15 2020, 9:34 PM · Restricted Project, Restricted Project
catskul awarded D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines a Love token.
Oct 15 2020, 9:10 PM · Restricted Project, Restricted Project

Oct 14 2020

catskul added a comment to D31635: [clang-format] Added ReferenceAlignmentStyle option.

In my opinion this patch should not be merged. I honestly don’t believe
this is a legitimate way of formatting code, so why make it possible at all?

Oct 14 2020, 6:59 AM · Restricted Project, Restricted Project, Restricted Project

Oct 13 2020

catskul added a comment to D31635: [clang-format] Added ReferenceAlignmentStyle option.

@MyDeveloperDay is this likely to land if the 3 items you mention are addressed? I'm trying to decide whether to adopt this patch to push it the last few cm over the finish line.

Oct 13 2020, 5:19 PM · Restricted Project, Restricted Project, Restricted Project
catskul awarded D31635: [clang-format] Added ReferenceAlignmentStyle option a Like token.
Oct 13 2020, 5:17 PM · Restricted Project, Restricted Project, Restricted Project

Mar 27 2020

catskul added a comment to D33029: [clang-format] add option for dangling parenthesis.

@bbassi @MyDeveloperDay I'll buy whoever manages to land this feature a case of their favorite beer/beverage (max $50). Or $50 worth of girlscout cookies. : )

Mar 27 2020, 7:37 AM · Restricted Project, Restricted Project

Nov 12 2018

catskul awarded D33029: [clang-format] add option for dangling parenthesis a Like token.
Nov 12 2018, 12:58 PM · Restricted Project, Restricted Project
catskul awarded D33029: [clang-format] add option for dangling parenthesis a Like token.
Nov 12 2018, 12:58 PM · Restricted Project, Restricted Project