Page MenuHomePhabricator

carnaval (Oscar Blumberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 23 2016, 1:15 AM (198 w, 6 d)

Recent Activity

Jun 13 2016

carnaval updated the diff for D21259: don't force SP-relative addressing for statepoints when the offset is not statically known.

address comments
move test to an existing file

Jun 13 2016, 4:39 PM
carnaval updated the diff for D21259: don't force SP-relative addressing for statepoints when the offset is not statically known.

add AllowSPAdjustment

Jun 13 2016, 4:05 PM
carnaval updated the diff for D21259: don't force SP-relative addressing for statepoints when the offset is not statically known.

re: putting the hasReservedCallFrame check
I don't think it's possible since the other use site of this function (in WinException) seem to actually use it in that case. I'm assuming that in this context it's guaranteed that the offset will only be interpreted relative to the stack pointer on function entry.
I've added a comment to reflect that at the getFrameIndexReferenceFromSP declaration.

Jun 13 2016, 12:33 PM
carnaval added a comment to D21286: Fix AAResults::callCapturesBefore for operand bundles.

yep, I don't have commit access. Thanks for the review !

Jun 13 2016, 11:49 AM
carnaval updated the diff for D21287: fix callsite attribute copying in statepoint lowering.

add context, reword test comment

Jun 13 2016, 11:48 AM
carnaval updated the diff for D21286: Fix AAResults::callCapturesBefore for operand bundles.

address comments

Jun 13 2016, 11:05 AM
carnaval updated the diff for D21259: don't force SP-relative addressing for statepoints when the offset is not statically known.
Jun 13 2016, 8:16 AM
carnaval retitled D21287: fix callsite attribute copying in statepoint lowering from to fix callsite attribute copying in statepoint lowering.
Jun 13 2016, 6:55 AM
carnaval retitled D21286: Fix AAResults::callCapturesBefore for operand bundles from Fix AAResults::callCapturesBefore for statepoints to Fix AAResults::callCapturesBefore for operand bundles.
Jun 13 2016, 6:47 AM
carnaval retitled D21286: Fix AAResults::callCapturesBefore for operand bundles from to Fix AAResults::callCapturesBefore for statepoints.
Jun 13 2016, 6:46 AM

Jun 11 2016

carnaval updated the diff for D21259: don't force SP-relative addressing for statepoints when the offset is not statically known.

add context according to local customs

Jun 11 2016, 12:54 PM
carnaval retitled D21259: don't force SP-relative addressing for statepoints when the offset is not statically known from to statepoint fixes.
Jun 11 2016, 12:39 PM