- User Since
- Jun 26 2020, 12:45 AM (35 w, 12 h)
Aug 5 2020
Friendly ping. Is there any feedback on the annotation approach?
Jul 29 2020
I changed the patch to be more annotation-oriented while trying to avoid just tacking _LIBCPP_NO_CFI onto every function. PTAL, thanks!
Jul 16 2020
Jul 15 2020
I don't think any of this is actually UB, for the same reason you stated. What are the annotations that could be used instead of this change?
Replace temporary variable use with in-place cast.
Jul 8 2020
Friendly ping. Is there something else I should do or someone else I should add to get this reviewed?
Jun 26 2020
I attached a small repro case, but I don't know if there's a way to make this into a unit test. LMK if that's something you want and where I would add it. Also, I wasn't able to get any of the clang-format tools to work, and just running clang-format with the included .clang-format of the repo completely changed the whole file. I think I kept the diff in the existing style though. Lastly, I ran make check-cxx and that passed.