Page MenuHomePhabricator

bshastry (Bhargava Shastry)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2015, 6:56 AM (200 w, 48 m)

Recent Activity

Feb 23 2018

bshastry created D43672: [libFuzzer] Adds experimental flag -ngram that changes the fuzzer fitness function.
Feb 23 2018, 2:03 AM · Restricted Project, Restricted Project

May 26 2016

bshastry added a comment to D16403: Add scope information to CFG.

Hello Bhargava. Is there any update on this review?

May 26 2016, 2:47 AM · Restricted Project

Apr 8 2016

bshastry updated the diff for D16403: Add scope information to CFG.

Nit: Renamed addScopeInfo to addScopes in AnalysisDeclContextManager ctor declaration

Apr 8 2016, 9:24 AM · Restricted Project
bshastry added a comment to D16403: Add scope information to CFG.

Hi Devin,

Apr 8 2016, 9:04 AM · Restricted Project
bshastry updated the diff for D16403: Add scope information to CFG.

Renamed and documented the difference between scope creator statement (TriggerScopeStmt) and auto obj dtors statement (TriggerAutoObjDtorsStmt).

Apr 8 2016, 8:51 AM · Restricted Project
bshastry updated the diff for D16403: Add scope information to CFG.

Fixed bug: Previous patch caused build failure due to CFG scope option rename (AddScope instead of AddScopeInfo) not being applied to CFG.cpp and the test case.

Apr 8 2016, 7:56 AM · Restricted Project
bshastry updated the diff for D16403: Add scope information to CFG.

Addressed Devin's comments from first review:

Apr 8 2016, 6:38 AM · Restricted Project

Apr 4 2016

bshastry added a comment to D16403: Add scope information to CFG.

Bhargava,

Thanks for the patch! Here are some quick, superficial comments. Some more in-depth comments coming later.

Also, it is very helpful for reviewers on Phabricator if the you include more context in the diff with -U999999. (See http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

Apr 4 2016, 2:58 AM · Restricted Project

Jan 30 2016

bshastry updated the diff for D16403: Add scope information to CFG.

Updated patch to include full context.

Jan 30 2016, 4:12 AM · Restricted Project

Jan 21 2016

bshastry retitled D16403: Add scope information to CFG from to Add scope information to CFG.
Jan 21 2016, 6:17 AM · Restricted Project

Jan 7 2016

bshastry added a comment to D15611: [Patch 2/3]: Rebasing Ryan Govostes' STP patch for Clang SA.

What was the last outstanding issue with this patch (I believe it was related to either make or cmake changes)?
Has it been addressed?

Jan 7 2016, 3:07 AM · Restricted Project

Dec 17 2015

bshastry retitled D15612: [Patch 3/3]: Rebasing Ryan Govostes' STP patch for Clang SA from to [Patch 3/3]: Rebasing Ryan Govostes' STP patch for Clang SA.
Dec 17 2015, 7:40 AM · Restricted Project
bshastry retitled D15611: [Patch 2/3]: Rebasing Ryan Govostes' STP patch for Clang SA from to [Patch 2/3]: Rebasing Ryan Govostes' STP patch for Clang SA.
Dec 17 2015, 7:38 AM · Restricted Project
bshastry retitled D15609: [Patch 1/3]: Rebasing Ryan Govostes' STP patch for Clang SA from to [Patch 1/3]: Rebasing Ryan Govostes' STP patch for Clang SA.
Dec 17 2015, 7:35 AM · Restricted Project

Nov 20 2015

bshastry updated D14863: Show git revision of code scanned using scan-build.
Nov 20 2015, 2:18 AM · Restricted Project
bshastry updated D14863: Show git revision of code scanned using scan-build.
Nov 20 2015, 2:17 AM · Restricted Project
bshastry updated D14863: Show git revision of code scanned using scan-build.
Nov 20 2015, 2:16 AM · Restricted Project
bshastry retitled D14863: Show git revision of code scanned using scan-build from to Show git revision of code scanned using scan-build.
Nov 20 2015, 2:15 AM · Restricted Project