Page MenuHomePhabricator

bruntib (Tibor Brunner)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2019, 5:16 AM (90 w, 1 d)

Recent Activity

Aug 29 2020

bruntib updated the diff for D33825: [clang-tidy] signal handler must be plain old function check.

Note texts are now describing what kind of C++ constructs were used. The warning message also explains better the reason of the issue: "signal handlers must be plain old functions, C++-only constructs are not allowed"

Aug 29 2020, 8:13 AM · Restricted Project
bruntib added inline comments to D33825: [clang-tidy] signal handler must be plain old function check.
Aug 29 2020, 6:40 AM · Restricted Project
bruntib updated the diff for D33825: [clang-tidy] signal handler must be plain old function check.

Test file has been extended with the second line of the "note" diagnostic message which designates the location of the suspicious "C++ construct". The full clang-tidy output looks like this:

Aug 29 2020, 6:34 AM · Restricted Project

Aug 28 2020

bruntib updated the diff for D33825: [clang-tidy] signal handler must be plain old function check.

Update lincense.

Aug 28 2020, 8:30 AM · Restricted Project
bruntib updated the diff for D33825: [clang-tidy] signal handler must be plain old function check.

I rebased the patch so it compiles with master version of LLVM/Clang. I did no other change, so I would like if this patch would be committed on behalf of @NorenaLeonetti if the patch is acceptable.
I would kindly ask the reviewers to give some comments if any additional modification is needed. I run this checker on DuckDB project and this checker gave two reports on functions which shouldn't be used as signal handler:

Aug 28 2020, 7:49 AM · Restricted Project
bruntib commandeered D33825: [clang-tidy] signal handler must be plain old function check.

I'll rebase this patch and continue its development.

Aug 28 2020, 7:37 AM · Restricted Project

Aug 26 2020

bruntib added a comment to D83678: [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator.

I reverted some changes so this checker remains an alpha checker. This patch now contains only the elimination of the false positive case. I wonder if this change is acceptable.

Aug 26 2020, 2:26 AM · Restricted Project
bruntib updated the diff for D83678: [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator.
Aug 26 2020, 2:24 AM · Restricted Project

Jul 16 2020

bruntib added a comment to D83678: [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator.

Hi All,

Jul 16 2020, 3:19 AM · Restricted Project

Jul 13 2020

bruntib created D83678: [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator.
Jul 13 2020, 6:19 AM · Restricted Project

Jun 24 2020

bruntib added a comment to D80210: [analyzer] Turn off reports in system headers.

Thanks everyone for the investigation in this problem.
I find these suggestions reasonable, and I think this commented example is a strong beating card in our hands to convince our users that paths going through system headers are meaningful and important.
I'll start implementing this idea and we'll see how much it affects the results in real-world projects.

Jun 24 2020, 8:36 AM · Restricted Project

May 21 2020

bruntib added a comment to D80210: [analyzer] Turn off reports in system headers.

@baloghadamsoftware You're right, but I couldn't find a header file which (1) contains a bug which ClangSA reports, (2) is not an "expected-warning", (3) is inside an already existing directory so it could be considered a system header.

May 21 2020, 8:36 AM · Restricted Project

May 20 2020

bruntib updated the diff for D80210: [analyzer] Turn off reports in system headers.

@balazske Alright, I rephrased it according to your suggestion.

May 20 2020, 4:52 AM · Restricted Project

May 19 2020

bruntib created D80210: [analyzer] Turn off reports in system headers.
May 19 2020, 7:00 AM · Restricted Project

May 13 2020

bruntib added reviewers for D79883: Fix Z3 function calls regarding arithmetic operations: martong, mikhail.ramalho.
May 13 2020, 10:17 AM · Restricted Project
bruntib added a reviewer for D79883: Fix Z3 function calls regarding arithmetic operations: steakhal.
May 13 2020, 10:17 AM · Restricted Project
bruntib created D79883: Fix Z3 function calls regarding arithmetic operations.
May 13 2020, 10:17 AM · Restricted Project

Sep 6 2019

bruntib updated the diff for D67265: [clang-tidy] Magic number checker shouldn't warn on user defined string literals.

Usually I'm not a big fan of auto, but in this case it makes sense not to duplicate the type name in the same expression. I'll use this rule of thumb in the future, thanks :)

Sep 6 2019, 7:16 AM · Restricted Project
bruntib updated the diff for D67265: [clang-tidy] Magic number checker shouldn't warn on user defined string literals.

Thank you for the suggestion. I didn't know about this behavior of %check_clang_tidy.

Sep 6 2019, 6:20 AM · Restricted Project
bruntib created D67265: [clang-tidy] Magic number checker shouldn't warn on user defined string literals.
Sep 6 2019, 5:21 AM · Restricted Project

Aug 17 2019

bruntib added inline comments to D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message.
Aug 17 2019, 2:50 PM · Restricted Project, Restricted Project
bruntib updated the diff for D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message.

The checker message has been changed according to the suggestion.
The last parameter of checkNonNull() doesn't require a default or optional value, so it has been fixed.
The parameter has been renamed from Idx to IdxOfArg.

Aug 17 2019, 2:48 PM · Restricted Project, Restricted Project

Aug 16 2019

bruntib added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

Thank you for the valuable comments and the review!
I'm just planning to register to the bug tracker, because it is getting more relevant due to some other contributions as well.

Aug 16 2019, 8:44 AM · Restricted Project, Restricted Project
bruntib retitled D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message from NonNullParamChecker and CStringChecker parameter number in checker message to [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message.
Aug 16 2019, 1:48 AM · Restricted Project, Restricted Project
bruntib created D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message.
Aug 16 2019, 1:15 AM · Restricted Project, Restricted Project

Aug 14 2019

bruntib updated the diff for D65065: [clang-tidy] Possibility of displaying duplicate warnings.

Since now the order of diagnostic messages is deterministic, we can count on this order in the test file.

Aug 14 2019, 7:43 AM · Restricted Project, Restricted Project

Aug 6 2019

bruntib added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

This suggestion would result another strange behavior: if the user disables cert-err09-cpp because he or she doesn't want to see its reports, the other one (cert-err61-cpp) will still report the issue. So he or she has to disable both (or as many aliases it has).

Aug 6 2019, 8:18 AM · Restricted Project, Restricted Project
bruntib added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

Not exactly. The problem is that it is non-deterministic which checker reports the issue. For example before this patch, in the test file above there was only one report. However, sometimes the report message is:

Aug 6 2019, 7:59 AM · Restricted Project, Restricted Project

Aug 5 2019

bruntib added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

Alright, I modified the commit accordingly. Thank you for the suggestions.

Aug 5 2019, 7:21 AM · Restricted Project, Restricted Project
bruntib updated the diff for D65065: [clang-tidy] Possibility of displaying duplicate warnings.
Aug 5 2019, 7:17 AM · Restricted Project, Restricted Project

Jul 23 2019

bruntib added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

Yes, LessClangTidyError would really be the best place for this. The reason of my implementation was that I wanted to bind this feature to a command line option. I don't know if there was any design decision behind the current uniquing logic and I didn't want to break it if there was any. So would you be agree with having duplicate reports by default without any command line flag in case of alias checkers? I believe this would be the most painless solution, since in case of further improvements about including notes, fixes, etc. in the functor, the potential command line option controlling this would be unnecessarily complex. I don't know if there could be any use-case on those.
Thanks for the review!

Jul 23 2019, 4:52 AM · Restricted Project, Restricted Project

Jul 22 2019

bruntib created D65065: [clang-tidy] Possibility of displaying duplicate warnings.
Jul 22 2019, 1:08 AM · Restricted Project, Restricted Project

Mar 14 2019

bruntib updated the diff for D57893: [analyzer] Fix function macro crash.

I've uploaded another version of the last fix. The previous one contained an UB, although it worked practically.

Mar 14 2019, 1:40 AM · Restricted Project, Restricted Project

Mar 13 2019

bruntib updated the diff for D57893: [analyzer] Fix function macro crash.

I added a condition before std::next() invocations to check if the next element is inside the valid interval. This fixes the crash of the build-bot. Sorry for the ugly bug.
I don't know if there is a more elegant solution.

Mar 13 2019, 1:20 PM · Restricted Project, Restricted Project

Mar 12 2019

bruntib updated the diff for D57893: [analyzer] Fix function macro crash.
Mar 12 2019, 2:32 AM · Restricted Project, Restricted Project
bruntib added a comment to D57893: [analyzer] Fix function macro crash.

I rebased the patch on the current master.

Mar 12 2019, 2:29 AM · Restricted Project, Restricted Project

Mar 7 2019

bruntib updated the diff for D57891: [analyzer] Fix infinite recursion in printing macros.

I added a test case for this recursive case. There is also a TODO in the code indicating the place where an additional fix will be required.

Mar 7 2019, 2:34 AM · Restricted Project, Restricted Project

Feb 10 2019

bruntib updated the diff for D57893: [analyzer] Fix function macro crash.
Feb 10 2019, 12:38 PM · Restricted Project, Restricted Project

Feb 8 2019

bruntib updated the diff for D57893: [analyzer] Fix function macro crash.

There was another place where this crash could have happened.

Feb 8 2019, 7:40 AM · Restricted Project, Restricted Project
bruntib updated the diff for D57893: [analyzer] Fix function macro crash.

I've added a test case.

Feb 8 2019, 5:52 AM · Restricted Project, Restricted Project

Feb 7 2019

bruntib created D57893: [analyzer] Fix function macro crash.
Feb 7 2019, 7:30 AM · Restricted Project, Restricted Project
bruntib created D57892: [analyzer] Fix macro printer crash when macro comes from another translation unit.
Feb 7 2019, 7:18 AM · Restricted Project, Restricted Project
bruntib created D57891: [analyzer] Fix infinite recursion in printing macros.
Feb 7 2019, 7:09 AM · Restricted Project, Restricted Project
bruntib created D57890: [analyzer] Fix in self assignment checker.
Feb 7 2019, 6:08 AM · Restricted Project